View Issue Details

This bug affects 1 person(s).
 6
IDProjectCategoryView StatusLast Update
10621Bug reportsErgonomypublic2016-03-07 11:51
ReporterDenisChenu Assigned ToLouisGac 
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version2.50.x 
Fixed in Version2.50.x 
Summary10621: Empty label in "array NUMBER"
Description

2 issue :

  • there are an empty lable in array text : NEVER use an empty label
  • With a little screen only empty checkbox is shown
Steps To Reproduce

See screenshot

Additional Information

Why remove the label ? Is was added for something ... an
lable (no text node)
input (no text)
/label

Is really a bad thing.

TagsNo tags attached.
Attached Files
HTML_from_206.png (29,803 bytes)   
HTML_from_206.png (29,803 bytes)   
HTML_from_250.png (26,039 bytes)   
HTML_from_250.png (26,039 bytes)   
Bug heat6
Complete LimeSurvey version number (& build)160229
I will donate to the project if issue is resolvedNo
Browsernot relevant
Database type & versionnot relevant
Server OS (if known)not relevant
Webserver software & version (if known)not relevant
PHP Versionnot relevant

Relationships

related to 10530 closedLouisGac HTML for radio button form items inconsistent 

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2016-02-29 09:48

developer   ~35754

Same issue with Array number and Multiple scale

LouisGac

LouisGac

2016-03-03 17:43

developer   ~35909

Last edited: 2016-03-03 17:44

I'm going to have a deep look into it right now.

But first : it's using no-more-table pattern, the only, and not perfect, way to have responsive tables.

Responsiveness of tables is one of the most debated and studied subject of those last years. The conclusion is that there is no perfect solution. Tables display logic is not compatible with responsiveness. Tables should be absolutely avoid in modern design.

Again : People creating surveys should accept in the future to totally avoid to use arrays. Arrays were perfect for printed survey, they are not convenient at all for screens (for display reasons, and for data reasons)

So people who want responsive surveys should just not use arrays at all. We should make it clear : "If you use array : it implies your users will pass the survey in big screens, not in small ones. If you want your survey to work on small screens, don't use arrays question types."

Any array question can be explode in different questions.

DenisChenu

DenisChenu

2016-03-03 17:51

developer   ~35910

Maybe,

But before : there was the label

  • To have it for screenreader
  • To have it in all browser (Opera mini show all table in block)

There was a bug report fixed.

Actually : you remove the text node on the label withouty any reason. If you want : add sr-only for calss.

LouisGac

LouisGac

2016-03-03 17:51

developer   ~35911

Bug resolved :

You'll have this problem only if you resize the windows on the fly (not a normal behavior).

If you load the page with the correct size, it has the label. So if you reload your page after resizing it, the label will appears.

Of course, I could add a little bit of javascript so it react to the resizing of the windows. But it will make the javascript heavier, will add a listener to the resize event. IMHO, it's useless.

LouisGac

LouisGac

2016-03-03 17:52

developer   ~35912

maybe should I remove totally the label ?

DenisChenu

DenisChenu

2016-03-03 17:53

developer   ~35913

Last edited: 2016-03-03 17:55

???????

Seriously : RWD don't need javascript ....

Serousliy 2 : label is here : just add good class and it's done.

Why Javascript ? What for ?

PS: it's a template behaviour or a core behaviour ? If it's template : not an issue.

LouisGac

LouisGac

2016-03-03 17:55

developer   ~35914

yes, it needed javascript, to insert the possible HTML tags.
THe pure css methods can't allow to insert html tags.

LouisGac

LouisGac

2016-03-03 17:58

developer   ~35915

here the pure CSS Methods :
http://bootsnipp.com/snippets/featured/no-more-tables-respsonsive-table

And here the bug it was doing for subquestions with HTML :
https://bugs.limesurvey.org/view.php?id=10449

Here the fix to that bug :
https://github.com/LimeSurvey/LimeSurvey/commit/676db8bb654b6ba5a5504f57a719a36bb5982625

which required js.
No need to be aggressive. Just ask, so I can explain.

LouisGac

LouisGac

2016-03-03 18:01

developer   ~35916

and please, be kind to understand that I move like all the CSS and the JS in the template side. You'll be able to do more than ever in your own templates.
The only change in core is to provide a HTML flow Bootstrap ready.
You can speak about it with Tammo, he understands this point very well.

DenisChenu

DenisChenu

2016-03-03 18:02

developer   ~35917

Looking at HTML : seems OK (different from screenshot)

And it can not be a resize window ; screenshoit are from my ZTE OpenC / CyanogenMod 4" wide .....

What HTML tag ? For what part ? title ? Title must be updated each time : because EM can update label ....

DenisChenu

DenisChenu

2016-03-03 18:05

developer   ~35918

array text is OK, array number not OK

DenisChenu

DenisChenu

2016-03-03 18:21

developer   ~35919

Mine error : Array text is OK :
have
td
input
label class="hide"
/td

But not array number and multiple scale

LouisGac

LouisGac

2016-03-03 19:06

developer   ~35921

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=17757

c_schmitz

c_schmitz

2016-03-07 11:49

administrator   ~36035

Version 2.50+ Build 160307 released

Related Changesets

LimeSurvey: master adc1ad5a

2016-03-03 17:57:08

LouisGac

Details Diff
Fixed issue 10621: Empty label in "array NUMBER" Affected Issues
10621
mod - application/helpers/qanda_helper.php Diff File
mod - templates/default/scripts/template.js Diff File

LimeSurvey: master db3f5929

2016-03-03 18:05:54

LouisGac

Details Diff
Fixed issue 10621: Empty label in "array NUMBER", checkbox case Affected Issues
10621
mod - templates/default/scripts/template.js Diff File

Issue History

Date Modified Username Field Change
2016-02-29 09:42 DenisChenu New Issue
2016-02-29 09:42 DenisChenu File Added: Screenshot_2016-02-28-15-31-57.png
2016-02-29 09:44 DenisChenu File Added: HTML_from_206.png
2016-02-29 09:44 DenisChenu File Added: HTML_from_250.png
2016-02-29 09:48 DenisChenu Note Added: 35754
2016-02-29 09:48 DenisChenu File Added: Screenshot_2016-02-28-15-37-05.png
2016-03-03 17:43 LouisGac Note Added: 35909
2016-03-03 17:44 LouisGac Note Edited: 35909
2016-03-03 17:51 DenisChenu Note Added: 35910
2016-03-03 17:51 LouisGac Note Added: 35911
2016-03-03 17:52 LouisGac Note Added: 35912
2016-03-03 17:53 DenisChenu Note Added: 35913
2016-03-03 17:54 DenisChenu Note Edited: 35913
2016-03-03 17:55 LouisGac Note Added: 35914
2016-03-03 17:55 DenisChenu Note Edited: 35913
2016-03-03 17:58 LouisGac Note Added: 35915
2016-03-03 18:01 LouisGac Note Added: 35916
2016-03-03 18:01 LouisGac Status new => resolved
2016-03-03 18:01 LouisGac Resolution open => fixed
2016-03-03 18:01 LouisGac Assigned To => LouisGac
2016-03-03 18:02 DenisChenu Note Added: 35917
2016-03-03 18:05 DenisChenu Note Added: 35918
2016-03-03 18:20 DenisChenu Summary Empty label in "array text" => Empty label in "array NUMBER"
2016-03-03 18:21 DenisChenu Note Added: 35919
2016-03-03 18:21 DenisChenu Status resolved => new
2016-03-03 19:06 LouisGac Changeset attached => LimeSurvey master adc1ad5a
2016-03-03 19:06 LouisGac Changeset attached => LimeSurvey master db3f5929
2016-03-03 19:06 LouisGac Note Added: 35921
2016-03-03 19:06 LouisGac Status new => resolved
2016-03-07 11:48 c_schmitz Fixed in Version => 2.5
2016-03-07 11:49 c_schmitz Note Added: 36035
2016-03-07 11:49 c_schmitz Status resolved => closed
2016-03-07 11:51 DenisChenu Relationship added related to 10530