View Issue Details

This bug affects 1 person(s).
 6
IDProjectCategoryView StatusLast Update
10619Bug reportsSurvey takingpublic2016-03-08 12:34
ReporterDenisChenu Assigned ToLouisGac 
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version2.50.x 
Fixed in Version2.50.x 
Summary10619: Label for multiple text seem misplaced
Description

See screenshot : label have a lot of space after, just before his input. Seem to happen only woith Android browser ?

For multiple number : reproductible on firefox

Steps To Reproduce

Little screen

Additional Information

It's surely better to have

ul
li class="form-group"
label class="control-label cal-sm-X"
div class="col-sm-y"
input class="form-control
/div
/li
/ul

TagsNo tags attached.
Attached Files
Bug heat6
Complete LimeSurvey version number (& build)160229
I will donate to the project if issue is resolvedNo
BrowserAndroid browser (cyanogen 12)
Database type & versionnot relevant
Server OS (if known)not relevant
Webserver software & version (if known)not relevant
PHP Versionnot relevant

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2016-02-29 09:27

developer   ~35752

Thre br ? And what for sm-12 ? Who ask this ??????

LouisGac

LouisGac

2016-03-08 09:50

developer   ~36115

input.form-control in bootstrap are alway 100% width of the containing element.
So you must put them into a container with an col-xx-yy. On small screens (col-xs-yy), it must always be col-xs-12.

For big screens, what I first did was a complex way of calculating the yy value, on the base of the length of the longer label. But as you probably remember, it wasn't always producing a beautiful rendering for the question. So, what we decided (you were agree), was to give back the control to the user with specific parameters in the advanced question attributes (like "Label width: (1-12)").

Indeed, the label width and the input width depend one from the other, so only one should be defined in advanced question attribute. So I will use the yet existing "input box width", with a numerical field of max 12.

DenisChenu

DenisChenu

2016-03-08 10:02

developer   ~36116

Last edited: 2016-03-08 10:03

Yes : but 3 br ? Quick retest actually : seem disappear.

I rember the input-width/label-width discussion. ANd if i remind : i propose the default to large screen 6 / 6 :).

Actually i have a white screen on /admin/questions?sa=ajaxquestionattributes , undefined index with debug=2 on my test survey.

LouisGac

LouisGac

2016-03-08 10:39

developer   ~36119

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=17814

LouisGac

LouisGac

2016-03-08 10:40

developer   ~36120

So :

  • 2 new question attributes to set the number of columns on normal screens for label and input.
  • default values : 6 and 6
c_schmitz

c_schmitz

2016-03-08 12:34

administrator   ~36150

Version 250+ Build 160308 released

Related Changesets

LimeSurvey: master ea879fe7

2016-03-08 09:39:15

LouisGac

Details Diff
Fixed issue 10619: Label for multiple text seem misplaced Affected Issues
10619
mod - application/helpers/common_helper.php Diff File
mod - application/helpers/qanda_helper.php Diff File
mod - application/views/admin/survey/Question/advanced_settings_view.php Diff File
mod - application/views/survey/questions/multipleshorttext/item_inputtext.php Diff File
mod - application/views/survey/questions/multipleshorttext/item_textarea.php Diff File

Issue History

Date Modified Username Field Change
2016-02-29 09:23 DenisChenu New Issue
2016-02-29 09:23 DenisChenu File Added: Screenshot_2016-02-28-15-31-31.png
2016-02-29 09:25 DenisChenu Description Updated
2016-02-29 09:26 DenisChenu Summary Lable for multiple text seem misplaced => Label for multiple text seem misplaced
2016-02-29 09:27 DenisChenu File Added: Capture du 2016-02-29 09-26-01.png
2016-02-29 09:27 DenisChenu File Added: Capture du 2016-02-29 09-26-42.png
2016-02-29 09:27 DenisChenu Note Added: 35752
2016-03-07 18:26 LouisGac Category Survey design => Survey taking
2016-03-08 09:50 LouisGac Note Added: 36115
2016-03-08 10:02 DenisChenu Note Added: 36116
2016-03-08 10:03 DenisChenu Note Edited: 36116
2016-03-08 10:03 DenisChenu Note Edited: 36116
2016-03-08 10:39 LouisGac Changeset attached => LimeSurvey master ea879fe7
2016-03-08 10:39 LouisGac Note Added: 36119
2016-03-08 10:39 LouisGac Assigned To => LouisGac
2016-03-08 10:39 LouisGac Resolution open => fixed
2016-03-08 10:40 LouisGac Note Added: 36120
2016-03-08 10:45 LouisGac Status new => resolved
2016-03-08 12:33 c_schmitz Fixed in Version => 2.5
2016-03-08 12:34 c_schmitz Note Added: 36150
2016-03-08 12:34 c_schmitz Status resolved => closed