You want to add a condition here, so user without activate rights can't activate survey they created? Not sure what your proposed solution is.

Hi olle : beforeHasPermission event doc : https://manual.limesurvey.org/BeforeHasPermission
"This event is fired just before a permission is tested. "

Then according to a doc beforeHasPermission must be lauch for

• Super admin
• Owner of survey (or any other owner (template/label set if we add it in next year))

Actually it's false with

• Super admin : it can be a choice : super admin can deactivéte plugin , then not major issue
• Owner of a survey : i think this must be corrected
• Command : think it's best if command permission is always true

The exact real condition i need is "deactivate update of survey after activated" . I can do without fixing event, but think it's best if the core event is fixed.

Then i think

• beforeHasPermission must be tested for any user with remote control or GUI
• beforeHasPermission don't happen for Command because command is specific.

Denis
PS : issue : super admin have less right than owner of survey

Just move the check for owner to the HasPermissions() function.

Oh yes, better idea :)

Maybe in the core plugin in future : owner_id come from auth but start with core system:)

https://github.com/LimeSurvey/LimeSurvey/pull/451

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=17729

Version 2.60 Build 150307 released

The change you did breaks global permissions completely.
Now a user with no global permissions has access to everything, no limitation.

Fixed

Version 250+ Build 160308 released

Fix committed to 2.06lts branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=28054