View Issue Details

This bug affects 1 person(s).
 8
IDProjectCategoryView StatusLast Update
10523Bug reportsSurvey editingpublic2016-02-23 08:51
Reporterpmonstad Assigned Toollehar  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version2.50.x 
Fixed in Version2.50.x 
Summary10523: Double set of buttons
Description

If I try to import responses from Import responses from a deactivated survey table, the screen has two set of options: In the upper right corner, and in the middle of the screen. Buttons should only be in upper right corner to be consistent. See screenshot.

TagsNo tags attached.
Attached Files
Bug heat8
Complete LimeSurvey version number (& build)160218
I will donate to the project if issue is resolvedNo
BrowserChrome
Database type & versionirrelevant
Server OS (if known)irrelevant
Webserver software & version (if known)irrelevant
PHP Versionirrelevant

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2016-02-18 19:25

developer   ~35416

pmonstad : a question : what do you think of this : make all screen have 2 sets of button (same :
One at top like actually + one at bottom (like some screen in 2.06 part) .

It's a question.

pmonstad

pmonstad

2016-02-18 19:52

updater   ~35418

I'd prefer to have three buttons on each screen: Save, Save and close, Close. I'm not sure why there are some screens with an extra button "Return to...".

I think those three buttons should be enough. Screens are very compact, and I don't know of any screens where users have to scroll down a long list. If there are such screens it could be a point to repeat the buttons in bottom right corner.

The Return to... button should not be necessary as the close and Save and Close buttons should have the same effect. What is the difference between close and return to...?

If we can agree to one standard for button appearance on screen I think we have made the gui a lot more standardized. Now there a too many variations around the gui.

This is my opinion, but I feel there should we a discussion about this at this point in development. 2.5 seems to be focusing on gui and a standard layout on screens is very important.

pmonstad

pmonstad

2016-02-18 20:19

updater   ~35419

There are some screens where Save and Save and close should be replaced by Import. Two buttons in upper right corner: Import, Close.

ollehar

ollehar

2016-02-19 09:07

administrator   ~35421

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=17519

ollehar

ollehar

2016-02-19 09:08

administrator   ~35422

Denis, I was thinking about that too. The work-flow is from top to bottom - it would then be convenient to have a save button just below the last field. But the save button in the upper right corner is still useful, since it's everywhere.

DenisChenu

DenisChenu

2016-02-19 10:10

developer   ~35424

Hi olle : in all forms i found on web (example or not) : we have

The option block : fieldset / input / etc ....

At the end : the action button

Example 1 : http://getbootstrap.com/customize/
Example 2 : https://github.com/settings/profile
etc etc ....

SOmetimes we have :
Form1
action for form1
Form2
action for form2
Form3
action for form3
Actually : only LimeSurvey have action button on top. It's not standard ..... And really not usuable/accessible

I already put a bug with this , but closed

Really think the best is the screenshoit i send to you.

I already open a bug report for this : have 2 set of button : one standard + one quick access. But this bug was closed.

ollehar

ollehar

2016-02-19 10:20

administrator   ~35425

Well, if the form is several pages long I think it's motivated to have a fixed bar with save-buttons.

Maybe we can talk about it on the next meeting.

DenisChenu

DenisChenu

2016-02-19 10:22

developer   ~35426

I'm OK for a fixed bar (see default SkeltonQUest : previous/next can be at top in double).
But really think it's standard to have the button at end of the form.

c_schmitz

c_schmitz

2016-02-23 08:51

administrator   ~35581

Version 2.50+ Build 160222 released

Related Changesets

LimeSurvey: master 17138f98

2016-02-19 08:07:11

ollehar

Details Diff
Fixed issue 10523: Double set of buttons Affected Issues
10523
mod - application/views/admin/dataentry/import.php Diff File

Issue History

Date Modified Username Field Change
2016-02-18 18:02 pmonstad New Issue
2016-02-18 18:02 pmonstad File Added: Skjermbilde 2016-02-18 kl. 18.01.48.png
2016-02-18 19:25 DenisChenu Note Added: 35416
2016-02-18 19:52 pmonstad Note Added: 35418
2016-02-18 20:19 pmonstad Note Added: 35419
2016-02-19 08:55 ollehar Assigned To => ollehar
2016-02-19 08:55 ollehar Status new => assigned
2016-02-19 09:07 ollehar Changeset attached => LimeSurvey master 17138f98
2016-02-19 09:07 ollehar Note Added: 35421
2016-02-19 09:07 ollehar Resolution open => fixed
2016-02-19 09:08 ollehar Note Added: 35422
2016-02-19 09:09 ollehar Status assigned => resolved
2016-02-19 09:09 ollehar Fixed in Version => 2.5
2016-02-19 10:10 DenisChenu Note Added: 35424
2016-02-19 10:10 DenisChenu File Added: Capture du 2016-02-19 10-07-57.png
2016-02-19 10:20 ollehar Note Added: 35425
2016-02-19 10:22 DenisChenu Note Added: 35426
2016-02-23 08:51 c_schmitz Note Added: 35581
2016-02-23 08:51 c_schmitz Status resolved => closed
2019-11-01 17:25 c_schmitz Category Survey design => Survey editing