View Issue Details

Jump to NotesJump to History
This bug affects 1 person(s).
 6
IDProjectCategoryView StatusDate SubmittedLast Update
10496Bug reportsErgonomypublic2016-02-17 08:202016-02-17 18:11
ReporterDenisChenu Assigned ToLouisGac 
PriorityhighSeverityminor 
Status closedResolutionfixed 
Product Version2.50.x 
Summary10496: Question list in the left bar has problems with tag
Description

Tag in question text can break question list

Steps To Reproduce

Set a question text with
1234567890123456789012345678901234567890< div> < div>< div>Something Something Something Something< /div>< /div>< /div>
(remove the space from tag)
and look

Additional Information

https://github.com/LimeSurvey/LimeSurvey/blob/master/application/helpers/common_helper.php#L7483

TagsNo tags attached.
Attached Files
Capture du 2016-02-16 18-43-06.png (58,113 bytes)   
Capture du 2016-02-16 18-43-06.png (58,113 bytes)   
Bug heat6
Complete LimeSurvey version number (& build)160217
I will donate to the project if issue is resolvedNo
Browsernot relevant
Database type & versionnot relevant
Server OS (if known)not relevant
Webserver software & version (if known)not relevant
PHP Versionnot relevant

Relationships

Relationship GraphDependency Graph
related to 10497 closedollehar Question list in the left bar has problems with arabic survey 
child of 10436 closedLouisGac Question list in the left bar has problems with equations and doesn't show correct order of questions. 

Users monitoring this issue

There are no users monitoring this issue.

Activities

c_schmitz

c_schmitz

2016-02-17 09:49

administrator   ~35281

Problem is that abbreviation happens before stripping HTML here.
You need to strip HTML first, only then abbreviated/ellipsize the text
DenisChenu

DenisChenu

2016-02-17 09:54

developer   ~35282

I'm not sure than strip_tags remove script

But viewHelper can be updated to :
remove external function in viewHelper::flatEllipsizeText

stripJavascript + strip tags with $bFlat=true

update viewHelper::flatEllipsizeText to directly have
flatEllipsizeText($sString,$bFlat=true,$iAbbreviated=0,$sEllipsis='...',$fPosition = 1)
LouisGac

LouisGac

2016-02-17 09:59

developer   ~35283

https://github.com/LimeSurvey/LimeSurvey/commit/25cf5598fa9bfd67bd88a92e18d0dc9f7f3a8576
c_schmitz

c_schmitz

2016-02-17 18:11

administrator   ~35345

Version 2.50+ Build 160217 released

Issue History

Date Modified Username Field Change
2016-02-17 08:20 DenisChenu New Issue
2016-02-17 08:20 DenisChenu File Added: Capture du 2016-02-16 18-43-06.png
2016-02-17 08:20 DenisChenu Relationship added child of 10436
2016-02-17 09:49 c_schmitz Note Added: 35281
2016-02-17 09:49 c_schmitz Assigned To => LouisGac
2016-02-17 09:49 c_schmitz Status new => assigned
2016-02-17 09:49 c_schmitz Priority normal => high
2016-02-17 09:54 DenisChenu Note Added: 35282
2016-02-17 09:55 DenisChenu Relationship added related to 10497
2016-02-17 09:59 LouisGac Note Added: 35283
2016-02-17 09:59 LouisGac Status assigned => resolved
2016-02-17 09:59 LouisGac Resolution open => fixed
2016-02-17 18:11 c_schmitz Note Added: 35345
2016-02-17 18:11 c_schmitz Status resolved => closed