View Issue Details

Related ChangesetsJump to NotesJump to History
This issue affects 1 person(s).
 8
IDProjectCategoryView StatusDate SubmittedLast Update
10394Bug reportsSurvey takingpublic2016-02-11 17:522016-02-23 08:51
Reporterwingman123 Assigned Toollehar  
PriorityurgentSeverityminor 
Status closedResolutionfixed 
Product Version2.50.x 
Fixed in Version2.50.x 
Summary10394: Thousand Separator appears to be broken - causes other issues (numerical input)
Description

Within the Latest commit on Master 32ffbb41917, If in a "numerical input" type question the "Thousands Separator" attribute is set On then the following behavior is observed:

  • Any input box for numeric values (Array (numbers) or multiple numeric or just numeric inut) automatically is set to a Double (Example: enter 5 in numeric field and it becomes 0.05) This happens for any numeric input field on the page not just the question that had the Thousands Separator on. Appears to be an issue with the JS for numeric_input perhaps

Thanks

Steps To Reproduce

In latest revision of master 32ffbb41917
Use the survey attached or create your own survey with:

  • One group
  • Group contains a numeric input type question
  • Group contains another numeric input type or array(numbers)
  • Set one of the numeric input type questions to have the Thousands Separator on in the question attributes.
  • Observe number appear with two values after the decimal (enter 5 get 0.05). This should occur for all input fields on the page if testing group or survey
  • In my survey I've set q2 to have Thousand separator on
TagsNo tags attached.
Attached Files
limesurvey_survey_626565.lss (15,576 bytes)
Bug heat8
Complete LimeSurvey version number (& build)32ffbb41917
I will donate to the project if issue is resolvedNo
BrowserChrome, Firefox
Database type & versionPostgres 9.4.4
Server OS (if known)Mac OSX 10.11
Webserver software & version (if known)Apache/2.4.16
PHP Version5.6.13

Relationships

Relationship GraphDependency Graph
related to 09876 closedollehar Different bogus with thousand seperator 

Users monitoring this issue

There are no users monitoring this issue.

Activities

Mazi

Mazi

2016-02-12 11:12

updater   ~34991

Can you please provide the commit link if possible? Doing a quick search I couldn't find "32ffbb41917".
wingman123

wingman123

2016-02-12 15:58

reporter   ~35035

https://github.com/LimeSurvey/LimeSurvey/commit/32ffbb41917fe5129d7fc1ec972aec1bf44ee3e1

Sorry about that. But that was the one I had initially checked when making the ticket
Mazi

Mazi

2016-02-15 10:23

updater   ~35110

I am not sure if that commit is related to the error but maybe Louis already knows which file to look at to fix this.
wingman123

wingman123

2016-02-16 17:09

reporter   ~35240

well the code for the thousands separator is in numerical_input.js. I havent had a chance but thats where the behavior seems to be dictated
ollehar

ollehar

2016-02-19 11:06

administrator   ~35428

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=17527
ollehar

ollehar

2016-02-19 11:07

administrator   ~35429

Only numerical input with thousand separator set to yes should now be affected.
c_schmitz

c_schmitz

2016-02-23 08:51

administrator   ~35580

Version 2.50+ Build 160222 released

Related Changesets

LimeSurvey: master 65e6bbb1

2016-02-19 11:05

ollehar


Details Diff		 Fixed issue 10394: Thousand Separator appears to be broken - causes other issues (numerical input) Affected Issues
10394
mod - scripts/numerical_input.js Diff File

Issue History

Date Modified Username Field Change
2016-02-11 17:52 wingman123 New Issue
2016-02-11 17:52 wingman123 File Added: limesurvey_survey_626565.lss
2016-02-12 11:12 Mazi Note Added: 34991
2016-02-12 11:12 Mazi Assigned To => Mazi
2016-02-12 11:12 Mazi Status new => feedback
2016-02-12 15:58 wingman123 Note Added: 35035
2016-02-12 15:58 wingman123 Status feedback => assigned
2016-02-15 10:22 Mazi Assigned To Mazi => LouisGac
2016-02-15 10:23 Mazi Note Added: 35110
2016-02-15 11:18 c_schmitz Priority normal => urgent
2016-02-16 17:09 wingman123 Note Added: 35240
2016-02-17 14:45 c_schmitz Assigned To LouisGac => c_schmitz
2016-02-19 11:04 ollehar Assigned To c_schmitz => ollehar
2016-02-19 11:06 ollehar Changeset attached => LimeSurvey master 65e6bbb1
2016-02-19 11:06 ollehar Note Added: 35428
2016-02-19 11:06 ollehar Resolution open => fixed
2016-02-19 11:07 ollehar Note Added: 35429
2016-02-19 11:07 ollehar Status assigned => resolved
2016-02-19 11:07 ollehar Fixed in Version => 2.5
2016-02-19 12:38 DenisChenu Relationship added related to 09876
2016-02-23 08:51 c_schmitz Note Added: 35580
2016-02-23 08:51 c_schmitz Status resolved => closed