View Issue Details

This bug affects 1 person(s).
 10
IDProjectCategoryView StatusLast Update
10390Bug reportsOtherpublic2016-04-21 11:40
ReporterMazi Assigned Toollehar  
PriorityimmediateSeverityminor 
Status closedResolutionfixed 
Product Version2.50.x 
Target Version2.50.xFixed in Version2.50.x 
Summary10390: Commit to set default charset at global settings got lost
Description

Louis, I don't know when this got lost but you know the current LS 2.5 branch best so maybe you can merge this feature back in: https://github.com/LimeSurvey/LimeSurvey/commit/3d5da68f99caec193b6c04715b6a3dac4d22c59a

Child commit for missing config at config-defaults: https://github.com/LimeSurvey/LimeSurvey/commit/67aaf287d3bbc790d96ab56e2ea974a9058b5560
^- This is the only thing that needs to be added to config-defaults.php:
/**

  • characterset (string)
  • Default character set for file import/export
    */
    $config['characterset'] = 'auto';
TagsNo tags attached.
Bug heat10
Complete LimeSurvey version number (& build)160210
I will donate to the project if issue is resolvedNo
BrowserChrome
Database type & versionMySQL 5
Server OS (if known)Ubuntu
Webserver software & version (if known)Apache 2
PHP Version5.5

Users monitoring this issue

c_schmitz

Activities

LouisGac

LouisGac

2016-02-11 17:28

developer   ~34929

committed on 27 Nov 2012 ? That's really strange. Was it lost in 2.06 too ?

Mazi

Mazi

2016-02-11 20:13

updater   ~34962

It may have got lost even from 2.0 to 2.05.

But it is a rather small adjustment so hopefully easy to merge.

ollehar

ollehar

2016-04-19 13:13

administrator   ~37545

Is this feature complete? It only affects token import, but there are other areas where you can chose import/export characterset too, is it not?

ollehar

ollehar

2016-04-19 15:52

administrator   ~37554

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=18636

c_schmitz

c_schmitz

2016-04-21 11:40

administrator   ~37638

Version 2.50+ Build 160421 released

Related Changesets

LimeSurvey: master 80207a8c

2016-04-19 13:52:00

ollehar

Details Diff
Fixed issue 10390: Commit to set default charset at global settings got
lost
Affected Issues
10390
mod - application/config/config-defaults.php Diff File
mod - application/controllers/admin/dataentry.php Diff File
mod - application/controllers/admin/globalsettings.php Diff File
mod - application/controllers/admin/tokens.php Diff File
mod - application/views/admin/globalSettings_view.php Diff File
mod - application/views/admin/global_settings/_general.php Diff File
mod - application/views/admin/token/csvupload.php Diff File

Issue History

Date Modified Username Field Change
2016-02-11 13:34 Mazi New Issue
2016-02-11 13:34 Mazi Status new => assigned
2016-02-11 13:34 Mazi Assigned To => LouisGac
2016-02-11 17:28 LouisGac Note Added: 34929
2016-02-11 17:28 LouisGac Status assigned => feedback
2016-02-11 20:13 Mazi Note Added: 34962
2016-02-11 20:13 Mazi Status feedback => assigned
2016-03-03 19:29 LouisGac Priority normal => low
2016-04-14 09:59 Mazi Issue Monitored: c_schmitz
2016-04-14 10:09 c_schmitz Priority low => immediate
2016-04-19 12:37 ollehar Assigned To LouisGac => ollehar
2016-04-19 12:37 ollehar Sticky Issue No => Yes
2016-04-19 13:13 ollehar Note Added: 37545
2016-04-19 15:52 ollehar Changeset attached => LimeSurvey master 80207a8c
2016-04-19 15:52 ollehar Note Added: 37554
2016-04-19 15:52 ollehar Resolution open => fixed
2016-04-19 15:52 ollehar Status assigned => resolved
2016-04-19 15:52 ollehar Fixed in Version => 2.5
2016-04-19 16:03 c_schmitz Sticky Issue Yes => No
2016-04-21 11:40 c_schmitz Note Added: 37638
2016-04-21 11:40 c_schmitz Status resolved => closed
2021-08-02 17:23 guest Bug heat 8 => 10