View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 6
IDProjectCategoryView StatusDate SubmittedLast Update
10387Bug reportsSurvey participants (Tokens)public2016-02-11 13:002016-02-12 17:24
ReporterMazi Assigned Toc_schmitz  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version2.50.x 
Target Version2.50.xFixed in Version2.50.x 
Summary10387: Commit to extend DB field sizes got lost
Description

Quite a while ago a company (GV Bayern) sponsored some Limesurvey adjustments (paid development work). This included:

  • raising firstname and lastname tokens fields to 150 chars
  • same adjustment for CPDB (lime_participants)

While at the participants table the fields are now using varchar(150) this got lost for created token tables, see attached screenshot. There firstname and lastname are defined as varchar(40).
This may lead to incompatibilities when transferring participant details between the two tables.

Further incompatibilities:

  • email: token=text / CPDB=varchar(254)
  • attributes: token=varchar(255) / CPDB=text

This has to be fixed since the customer paid for it and the commit got lost/overwritten.

Steps To Reproduce

Just check the DB details...

Additional Information

See original commit here: https://github.com/LimeSurvey/LimeSurvey/commit/13ccda2163d5bd1d00889e2255b7aa6e02e111c8

TagsNo tags attached.
Attached Files
lime_tokens_table.png (12,025 bytes)   
lime_tokens_table.png (12,025 bytes)   
Bug heat6
Complete LimeSurvey version number (& build)160210
I will donate to the project if issue is resolvedNo
BrowserChrome
Database type & versionMySQL 5
Server OS (if known)Ubuntu
Webserver software & version (if known)Apache 2
PHP Version5.5

Users monitoring this issue

There are no users monitoring this issue.

Activities

LouisGac

LouisGac

2016-02-11 17:30

developer   ~34931

same question : this is a commit from 2012, was it lost in 2.06 too ?
Mazi

Mazi

2016-02-11 20:15

updater   ~34963

Same answer :-)

Hard to tell when exactly it got lost but it existed at 2.0.

Problem with this issue is that the token tables are only set up if needed so the SQL can not only be added to the update routine but also the function to create new token tables has to be adjusted (that's why back then I asked Carsten to take care of this one).
c_schmitz

c_schmitz

2016-02-12 12:59

administrator   ~35022

Last edited: 2016-02-12 12:59

I don't see where this got lost. All tables here have the specifications from that past patch - also the update procedures are all in place (dbversion 179)
Mazi

Mazi

2016-02-12 13:23

updater   ~35024

See attached screen shot: Token tables are not extended to 150 chars but that was what the user had paid for back then.
c_schmitz

c_schmitz

2016-02-12 13:32

administrator   ~35025

Last edited: 2016-02-12 13:32

Maybe a faulty update try in the past?
Token tables are properly updated here.
c_schmitz

c_schmitz

2016-02-12 16:19

administrator   ~35040

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=17366
c_schmitz

c_schmitz

2016-02-12 17:24

administrator   ~35045

Version 2.50+ Build 160213 released

Related Changesets

LimeSurvey: master d638a228

2016-02-12 15:19:14

c_schmitz

Details Diff 		Fixed issue 10387: Token firstname and lastname field length too short
Dev Also CPDB email field is set to text now to match the token email field		 Affected Issues
10387
mod - application/config/version.php Diff File
mod - application/helpers/update/updatedb_helper.php Diff File
mod - application/models/Token.php Diff File
mod - application/views/admin/homepagesettings/index.php Diff File
mod - application/views/admin/super/fullpagebar_view.php Diff File
mod - installer/sql/create-mssql.sql Diff File
mod - installer/sql/create-mysql.sql Diff File
mod - installer/sql/create-pgsql.sql Diff File

Issue History

Date Modified Username Field Change
2016-02-11 13:00 Mazi New Issue
2016-02-11 13:00 Mazi Status new => assigned
2016-02-11 13:00 Mazi Assigned To => c_schmitz
2016-02-11 13:00 Mazi File Added: lime_tokens_table.png
2016-02-11 13:19 Mazi Additional Information Updated
2016-02-11 17:30 LouisGac Note Added: 34931
2016-02-11 17:30 LouisGac Status assigned => feedback
2016-02-11 20:15 Mazi Note Added: 34963
2016-02-11 20:15 Mazi Status feedback => assigned
2016-02-12 12:30 Mazi Description Updated
2016-02-12 12:59 c_schmitz Note Added: 35022
2016-02-12 12:59 c_schmitz Note Edited: 35022
2016-02-12 13:00 c_schmitz Status assigned => closed
2016-02-12 13:00 c_schmitz Resolution open => unable to reproduce
2016-02-12 13:23 Mazi Note Added: 35024
2016-02-12 13:23 Mazi Status closed => feedback
2016-02-12 13:23 Mazi Resolution unable to reproduce => reopened
2016-02-12 13:32 c_schmitz Note Added: 35025
2016-02-12 13:32 c_schmitz Note Edited: 35025
2016-02-12 13:32 c_schmitz Status feedback => closed
2016-02-12 13:32 c_schmitz Resolution reopened => unable to reproduce
2016-02-12 16:10 c_schmitz Status closed => assigned
2016-02-12 16:19 c_schmitz Changeset attached => LimeSurvey master d638a228
2016-02-12 16:19 c_schmitz Note Added: 35040
2016-02-12 16:19 c_schmitz Resolution unable to reproduce => fixed
2016-02-12 16:50 c_schmitz Status assigned => resolved
2016-02-12 16:50 c_schmitz Fixed in Version => 2.5
2016-02-12 17:24 c_schmitz Note Added: 35045
2016-02-12 17:24 c_schmitz Status resolved => closed
2016-12-08 10:39 c_schmitz Category Tokens => Survey participants (Tokens)