View Issue Details

This bug affects 1 person(s).
 10
IDProjectCategoryView StatusLast Update
10337Bug reportsData Entry (non public)public2016-02-12 10:54
ReporterDrewskie Assigned ToDenisChenu  
PriorityhighSeveritypartial_block 
Status closedResolutionfixed 
Product Version2.50.x 
Fixed in Version2.50.x 
Summary10337: Deleting a survey returns error
Description

When deleting a survey the system returns an error. However the survey does get deleted.

Steps To Reproduce

Edit Survey
Select Tools
Select Delete Survey

TagsNo tags attached.
Attached Files
Delete Survey Error.JPG (46,217 bytes)   
Delete Survey Error.JPG (46,217 bytes)   
Bug heat10
Complete LimeSurvey version number (& build)160206
I will donate to the project if issue is resolvedNo
BrowserIE11
Database type & versionSQL 2008
Server OS (if known)Windows 2012
Webserver software & version (if known)IIS8
PHP Version5.4.24

Users monitoring this issue

Drewskie

Activities

LouisGac

LouisGac

2016-02-08 19:52

developer   ~34747

can't reproduce this bug.

Drewskie

Drewskie

2016-02-09 06:40

reporter   ~34763

Turned on debugging and have attached the result, hope this helps.

DenisChenu

DenisChenu

2016-02-09 08:30

developer   ~34767

Maybe somethnig with a big survey ? 2100 parameters seems strange .

LouisGac

LouisGac

2016-02-09 10:13

developer   ~34773

please, upload this template to a 2.06 and let us know if the same problem happen.

Drewskie

Drewskie

2016-02-09 10:22

reporter   ~34775

Last edited: 2016-02-09 10:23

2.06+ 160129 running same DB PHP and IIS deletes without an error.

DenisChenu

DenisChenu

2016-02-09 10:38

developer   ~34778

@LouiGac: it's something with lime_settings_global

With last_question_gid_user, last_question_user etc ....

Maybe
$criteria = new CDbCriteria;
$criteria->addInCondition('last_question_gid_user',$gidOfThisSrvey);
SettingsGlobal::model()->deleteAll($criteria);

LouisGac

LouisGac

2016-02-09 11:16

developer   ~34782

Last edited: 2016-02-09 11:18

Resolving IIS bugs is not a priority, unless IIS users make a donation.
so we'll resolve this bug when we'll have time.

DenisChenu

DenisChenu

2016-02-10 10:47

developer   ~34813

Last edited: 2016-02-10 13:14

If you don't want to fix : update status to new and "de assign" you :)

This part must be moved in model : RC/Plugin can delete survey too.

And must delete for all user ....

DenisChenu

DenisChenu

2016-02-10 13:09

developer   ~34819

@Drewskie : you set private ? We can open it for other user ?

DenisChenu

DenisChenu

2016-02-10 13:37

developer   ~34820

Last edited: 2016-02-10 13:41

There are another issue here too :
lastquestion{$otherUser}
and
last_questiongid{$otherUser}
is not deleted.

Deleted only for actual user

Another one : is surveyid is 18, you delete queXMLSectionHeight (for example)

DenisChenu

DenisChenu

2016-02-10 14:39

developer   ~34822

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=17270

DenisChenu

DenisChenu

2016-02-10 14:40

developer   ~34823

@Drewskie : i'm unsure it's OK with ms, but you can trye the patch https://github.com/LimeSurvey/LimeSurvey/commit/f2acf6ae2286e59d0599a07e32d497385b614e94

DenisChenu

DenisChenu

2016-02-10 15:54

developer   ~34824

DenisChenu

DenisChenu

2016-02-11 10:09

developer   ~34884

@Drewskie : need feedback

DenisChenu

DenisChenu

2016-02-11 14:26

developer   ~34904

No feedback : set to fixed until another user with mssql try it.
Open to public after delete PHP warning file

c_schmitz

c_schmitz

2016-02-12 10:54

administrator   ~34983

2.50+ Build 160212 released

Related Changesets

LimeSurvey: master f2acf6ae

2016-02-10 13:39:18

DenisChenu

Details Diff
Fixed issue 10337 : Delete survey don't delete all user's settings
Dev: Delete in model : deleted for RC and plugin (if using model)
Dev: Delete other user settings if linked with survey
Dev: use compare and addInCondition : better quote value for PG and ms
Affected Issues
10337
mod - application/controllers/admin/surveyadmin.php Diff File
mod - application/models/Survey.php Diff File

LimeSurvey: master 1ffc1571

2016-02-10 14:49:54

DenisChenu

Details Diff
Dev: fixed issue : broken index for admin for pgsql
Dev: Cast value when delete global setting fo IN condition : pgsql need it. Unsure for mssql
Affected Issues
10337
mod - application/controllers/admin/index.php Diff File
mod - application/models/Survey.php Diff File

Issue History

Date Modified Username Field Change
2016-02-08 08:07 Drewskie New Issue
2016-02-08 08:07 Drewskie File Added: Delete Survey Error.JPG
2016-02-08 08:08 Drewskie Issue Monitored: Drewskie
2016-02-08 19:52 LouisGac Note Added: 34747
2016-02-08 19:52 LouisGac Assigned To => LouisGac
2016-02-08 19:52 LouisGac Status new => feedback
2016-02-09 06:39 Drewskie File Added: CDbException_php.htm
2016-02-09 06:40 Drewskie Note Added: 34763
2016-02-09 06:40 Drewskie Status feedback => assigned
2016-02-09 08:30 DenisChenu Note Added: 34767
2016-02-09 10:13 LouisGac Note Added: 34773
2016-02-09 10:13 LouisGac Status assigned => feedback
2016-02-09 10:22 Drewskie Note Added: 34775
2016-02-09 10:22 Drewskie Status feedback => assigned
2016-02-09 10:23 Drewskie Note Edited: 34775
2016-02-09 10:38 DenisChenu Note Added: 34778
2016-02-09 11:16 LouisGac Note Added: 34782
2016-02-09 11:18 LouisGac Note Edited: 34782
2016-02-10 10:46 DenisChenu Assigned To LouisGac => DenisChenu
2016-02-10 10:47 DenisChenu Note Added: 34813
2016-02-10 13:09 DenisChenu Note Added: 34819
2016-02-10 13:13 DenisChenu Note Edited: 34813
2016-02-10 13:14 DenisChenu Note Edited: 34813
2016-02-10 13:37 DenisChenu Note Added: 34820
2016-02-10 13:41 DenisChenu Note Edited: 34820
2016-02-10 14:39 DenisChenu Changeset attached => LimeSurvey master f2acf6ae
2016-02-10 14:39 DenisChenu Note Added: 34822
2016-02-10 14:39 DenisChenu Resolution open => fixed
2016-02-10 14:40 DenisChenu Note Added: 34823
2016-02-10 14:40 DenisChenu Status assigned => feedback
2016-02-10 15:54 DenisChenu Note Added: 34824
2016-02-10 15:54 DenisChenu Changeset attached => LimeSurvey master 1ffc1571
2016-02-11 10:09 DenisChenu Note Added: 34884
2016-02-11 14:25 DenisChenu File Deleted: CDbException_php.htm
2016-02-11 14:25 DenisChenu View Status private => public
2016-02-11 14:26 DenisChenu Note Added: 34904
2016-02-11 14:26 DenisChenu Status feedback => resolved
2016-02-11 14:26 DenisChenu Fixed in Version => 2.5
2016-02-12 10:54 c_schmitz Note Added: 34983
2016-02-12 10:54 c_schmitz Status resolved => closed
2021-08-04 02:47 guest Bug heat 8 => 10