View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
10252 | Bug reports | Other | public | 2016-01-26 15:18 | 2016-02-03 09:17 |
Reporter | lowprofile | Assigned To | DenisChenu | ||
Priority | normal | Severity | partial_block | ||
Status | closed | Resolution | fixed | ||
Product Version | 2.06+ | ||||
Fixed in Version | 2.50.x | ||||
Summary | 10252: old style (1.92 - 2.05) URL mapping no longer working in 2.06 | ||||
Description | Up to version 2.05 the old style (1.92) urls were working along with the new style. This is possibly due to controller changes? old style in version 2.06 the old style is no longer working as can be seen in the demo new style (with get enabled?) | ||||
Steps To Reproduce | Create a survey in 2.06 /index.php?sid=xxxxxxx | ||||
Tags | No tags attached. | ||||
Bug heat | 6 | ||||
Complete LimeSurvey version number (& build) | 2.06 160123 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | chrome/firefox | ||||
Database type & version | Mysql | ||||
Server OS (if known) | redhat | ||||
Webserver software & version (if known) | apache | ||||
PHP Version | 5.3.3 | ||||
I have an idea for this. Add a new plugin event 'beforePublicPage' 'type'=> ... and some information Use this event to do a new plugin : if(App()-getQuery('sid')) Deactivate dby default, name it 'oldUrlCompat' \o/ i think we can do it without a new event :) |
|
Got it : limesurvey.sondages.pro/index.php?sid=714997 Make the pull request and the plugin today
Need to reconstruct the GET parameters (for enterUrl) |
|
Plugin is here : https://github.com/LimeSurvey/LimeSurvey/pull/424 |
|
I tested the plugin and while it works with the plugin, the new style URLS no longer work, and the link from the survey details no longer works (since it is a new style link) |
|
@lowprofile : with GET or PATH ? I test with PATH : seems to have no issue. ANd in teory : it must work with any url. We do something only if controller is surveys (survey listing) |
|
@lowprofile :can not reproduce: path: get: |
|
@lowprofile : waiting for you feedback : find the way to broke this. |
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=17053 |
|
2.5+ Build 160202 released |
|
LimeSurvey: master 19805ae7 2016-01-27 12:27 Details Diff |
Fixed issue 10252: old style (pre 2.0) URL mapping no longer working in 2.06 Dev: forward to survey controller if controller is surveys and sid is in GET param Dev: forward because redirect need query params reconstruction Dev: use redirect can be an option (or new plugin) |
Affected Issues 10252 |
|
add - application/core/plugins/oldUrlCompat/oldUrlCompat.php | Diff File | ||
LimeSurvey: master eca522b6 2016-02-02 12:08 Details Diff |
Merge pull request #424 from Shnoulle/fix_10252_oldUrlCompat Fixed issue 10252: old style (pre 2.0) URL mapping no longer working⦠Dev: still working with 2.5 Dev: not activate by default, can be acativated |
Affected Issues 10252 |
|
add - application/core/plugins/oldUrlCompat/oldUrlCompat.php | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2016-01-26 15:18 | lowprofile | New Issue | |
2016-01-27 09:11 | DenisChenu | Note Added: 34397 | |
2016-01-27 09:13 | DenisChenu | Note Edited: 34397 | |
2016-01-27 09:28 | DenisChenu | Assigned To | => DenisChenu |
2016-01-27 09:28 | DenisChenu | Status | new => assigned |
2016-01-27 09:29 | DenisChenu | Note Added: 34398 | |
2016-01-27 12:28 | DenisChenu | Note Added: 34399 | |
2016-01-28 20:47 | lowprofile | Note Added: 34407 | |
2016-01-29 08:47 | DenisChenu | Note Added: 34410 | |
2016-01-29 09:52 | DenisChenu | Note Added: 34411 | |
2016-01-29 09:53 | DenisChenu | Note Added: 34412 | |
2016-01-29 09:53 | DenisChenu | Status | assigned => feedback |
2016-01-29 09:54 | DenisChenu | Note Edited: 34411 | |
2016-01-29 09:54 | DenisChenu | Note Edited: 34411 | |
2016-02-02 12:08 | DenisChenu | Changeset attached | => LimeSurvey master 19805ae7 |
2016-02-02 12:08 | DenisChenu | Changeset attached | => LimeSurvey master eca522b6 |
2016-02-02 12:08 | DenisChenu | Note Added: 34469 | |
2016-02-02 12:08 | DenisChenu | Resolution | open => fixed |
2016-02-02 12:08 | DenisChenu | Status | feedback => resolved |
2016-02-02 12:08 | DenisChenu | Fixed in Version | => 2.5 |
2016-02-03 09:17 | c_schmitz | Note Added: 34486 | |
2016-02-03 09:17 | c_schmitz | Status | resolved => closed |