View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 6
IDProjectCategoryView StatusDate SubmittedLast Update
10213Bug reportsSurvey participants (Tokens)public2016-01-08 17:082016-01-22 08:54
Reporterwingman123 Assigned ToLouisGac 
PriorityhighSeveritycrash 
Status closedResolutionfixed 
Product Version2.06+ 
Summary10213: Lime2.5RC6 Cannot initialize token table
Description

Within Lime2.5RC6 I cannot initialize a token table. I've tried on Postgres and Mysql. Clicking Initialize refreshes the same page but doesn't carry out the action, might be a simple fix

Steps To Reproduce

Use Lime2.5RC6 with Postgres or mysql

  • Create or import a survey
  • Try to initialize a token table (nothing will happen)
  • Try hitting close button (nothing will happen)
TagsNo tags attached.
Attached Files
Screen Shot 2016-01-08 at 10.58.11 AM.png (93,967 bytes)   
Screen Shot 2016-01-08 at 10.58.11 AM.png (93,967 bytes)   
Bug heat6
Complete LimeSurvey version number (& build)Lime2.5 RC6 - 28549d50b1a
I will donate to the project if issue is resolvedNo
BrowserChrome, Firefox
Database type & versionPostgres 9.4.4, MySQLVer 14.14 Distrib 5.6.27
Server OS (if known)Mac OSX 10.11
Webserver software & version (if known)Apache/2.4.16
PHP Version5.6.13

Users monitoring this issue

There are no users monitoring this issue.

Activities

wingman123

wingman123

2016-01-08 22:26

reporter   ~34256

Bug appears to have occured in this commit
https://github.com/LimeSurvey/LimeSurvey/commit/5e8182158813b1196424a78d65284082d0cf2e85

Not sure if intentional. Looking into it further
wingman123

wingman123

2016-01-08 22:38

reporter   ~34257

if (Yii::app()->request->getPost('createtable') == "Y") // Update table, must be CRSF controlled

The offending line. But im not sure if there was going to be some other logic change in order to utilize a POST instead of a GET. A temp fix is reverting to (Yii::app()->request->getQuery('createtable') == "Y") //
DenisChenu

DenisChenu

2016-01-09 17:45

developer   ~34258

There was a security fix for 2.06 : table updating managing MUST be CRSF token.

We must send POST here, and not GET
wingman123

wingman123

2016-01-09 18:10

reporter   ~34259

Ok that makes sense, so the request should be modified to work with POST then
LouisGac

LouisGac

2016-01-13 11:50

developer   ~34272

Fix committed to 2.5 branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=16835
LouisGac

LouisGac

2016-01-13 11:51

developer   ~34273

thanks for reporting.

Related Changesets

LimeSurvey: 2.5 6796f27f

2016-01-13 10:50:16

LouisGac

Details Diff 		Fixed issue 10213: initialise tokens Affected Issues
10213
mod - application/views/admin/token/tokenwarning.php Diff File

Issue History

Date Modified Username Field Change
2016-01-08 17:08 wingman123 New Issue
2016-01-08 17:08 wingman123 File Added: Screen Shot 2016-01-08 at 10.58.11 AM.png
2016-01-08 22:26 wingman123 Note Added: 34256
2016-01-08 22:38 wingman123 Note Added: 34257
2016-01-09 17:45 DenisChenu Note Added: 34258
2016-01-09 18:10 wingman123 Note Added: 34259
2016-01-13 11:06 LouisGac Assigned To => LouisGac
2016-01-13 11:06 LouisGac Status new => assigned
2016-01-13 11:50 LouisGac Changeset attached => LimeSurvey 2.5 6796f27f
2016-01-13 11:50 LouisGac Note Added: 34272
2016-01-13 11:50 LouisGac Resolution open => fixed
2016-01-13 11:51 LouisGac Note Added: 34273
2016-01-13 11:51 LouisGac Status assigned => resolved
2016-01-22 08:54 c_schmitz Status resolved => closed
2016-12-08 10:39 c_schmitz Category Tokens => Survey participants (Tokens)