View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 6
IDProjectCategoryView StatusDate SubmittedLast Update
10183Bug reportsSurvey editingpublic2015-12-23 16:572016-01-08 15:35
ReporterDenisChenu Assigned ToLouisGac 
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version2.50.x 
Summary10183: [usuability] Broiwser helper don't show when there are an error
Description

When using the save button : browser helper aren't shown

Steps To Reproduce

A way :

  • Go to a label set
  • Put ABC in Valeur de l'évaluation/assessement value
  • Click on "Save change"/"Sauvegarder les changement"
Additional Information

Send 2 screenshot

  • With the actual button
  • With click on real button
TagsNo tags attached.
Attached Files
actualButton.png (167,065 bytes)
RealButton.png (172,937 bytes)
Capture du 2015-12-28 13-20-54.png (43,441 bytes)   
Capture du 2015-12-28 13-20-54.png (43,441 bytes)   
inputblue_onfocus.png (22,496 bytes)   
inputblue_onfocus.png (22,496 bytes)   
inputred_out_focus.png (15,560 bytes)   
inputred_out_focus.png (15,560 bytes)   
Bug heat6
Complete LimeSurvey version number (& build)151223
I will donate to the project if issue is resolvedNo
BrowserFirefox 43.0
Database type & versionnot relevant
Server OS (if known)not relevant
Webserver software & version (if known)not relevant
PHP Versionnot relevant

Users monitoring this issue

There are no users monitoring this issue.

Activities

LouisGac

LouisGac

2015-12-28 12:24

developer   ~34119

Fix committed to 2.5 branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=16705
DenisChenu

DenisChenu

2015-12-28 13:21

developer   ~34121

Hi,

Fixed. Just a remark for validity.

lime-admin.css : line 586 : we force bg color. This remove the default "validty" alert.
Send a screenshot without this line.

Maybe we need to update more bootstrap css
http://getbootstrap.com/css/#forms-control-validation
LouisGac

LouisGac

2015-12-28 13:24

developer   ~34122

well, that's a very good remark. I didn't noticed it.
LouisGac

LouisGac

2015-12-28 16:02

developer   ~34123

well, after a deep look into the validation system, it seems that is the normal behavior.

Red stroke is used by bootstrap only for wrong input NOT being focus. If the input is on focus, it just has the validity error message.

You can test it : enter in Firefox a string value inside an integer input (like in label), click anywhere else, the input become red. I will attach some files to show it
DenisChenu

DenisChenu

2015-12-28 18:26

developer   ~34125

Last edited: 2015-12-28 18:36

Seems to be bootstrap choice to remove :invalid system here : https://github.com/twbs/bootstrap/commit/90d4343f66d1cdafe24b6de0dbb6ae64312df323

Think it's really a great helper for user.

bootstrap 2 have a :invlid selector. http://getbootstrap.com/2.3.2/base-css.html#forms

We can update it in plugin, but think it's a false good idea by bootstrap.

PS : with FF : no red system even on focus or hover.
PS: same with midori (have some issue in chromium-browser and Defora 23 actually).
c_schmitz

c_schmitz

2016-01-08 15:35

administrator   ~34191

Version 2.5RC6 released

Related Changesets

LimeSurvey: 2.5 dec60205

2015-12-28 12:24

LouisGac


Details Diff		 Fixed issue 10183: return false after trigger click for firefox Affected Issues
10183
mod - application/controllers/admin/labels.php Diff File
mod - application/views/admin/labels/labelsetsbar_view.php Diff File
mod - application/views/admin/super/fullpagebar_view.php Diff File
mod - application/views/admin/templates/templateeditorbar_view.php Diff File
mod - application/views/admin/usergroup/usergroupbar_view.php Diff File
mod - styles/Sea_Green/scripts/save.js Diff File

Issue History

Date Modified Username Field Change
2015-12-23 16:57 DenisChenu New Issue
2015-12-23 16:57 DenisChenu File Added: actualButton.png
2015-12-23 16:58 DenisChenu File Added: RealButton.png
2015-12-28 12:24 LouisGac Changeset attached => LimeSurvey 2.5 dec60205
2015-12-28 12:24 LouisGac Note Added: 34119
2015-12-28 12:24 LouisGac Assigned To => LouisGac
2015-12-28 12:24 LouisGac Resolution open => fixed
2015-12-28 12:24 LouisGac Status new => resolved
2015-12-28 13:21 DenisChenu Note Added: 34121
2015-12-28 13:21 DenisChenu File Added: Capture du 2015-12-28 13-20-54.png
2015-12-28 13:24 LouisGac Note Added: 34122
2015-12-28 16:02 LouisGac Note Added: 34123
2015-12-28 16:02 LouisGac File Added: inputblue_onfocus.png
2015-12-28 16:02 LouisGac File Added: inputred_out_focus.png
2015-12-28 18:26 DenisChenu Note Added: 34125
2015-12-28 18:36 DenisChenu Note Edited: 34125
2016-01-08 15:35 c_schmitz Note Added: 34191
2016-01-08 15:35 c_schmitz Status resolved => closed
2019-11-01 17:25 c_schmitz Category Survey design => Survey editing