Relationship Graph View Issue Dependency Graph
related to child of duplicate of

View Issue Details

IDProjectCategoryView StatusLast Update
14936Bug reports[All Projects] Survey editingpublic2019-10-19 10:07
ReporterDenisChenu Assigned ToDenisChenu  
PriorityhighSeverityminor 
Status closedResolutionfixed 
Product Version3.17.x 
Target VersionFixed in Version3.17.x 
Summary14936: Preview group : relevance on question broken
Description

When previewing group : relevance on question is not apply. Make it difficult to fix relevance …

Steps To Reproduce

Import included survey
Preview first group : see what happen
If relevance is OK (some times it was)
Start survey, click next, close windows
Preview question group again

Additional Information

Previously : relevance to group is set to forced tru, and relevance to question to forced tru only when preview question.

TagsNo tags attached.
Complete LimeSurvey version number (& build)3.17.2 github
I will donate to the project if issue is resolvedNo
BrowserFF 66
Database & DB-Versionnot relevant?
Server OS (if known)not relevant ?
Webserver software & version (if known)not relevant ?
PHP Versionphp7.2

Activities

DenisChenu

DenisChenu

2019-05-24 13:38

developer  

limesurvey_survey_noRelevanceOnPreviewGroup.lss (22,899 bytes)
DenisChenu

DenisChenu

2019-05-24 13:39

developer  

dominikvitt

dominikvitt

2019-06-18 13:37

developer   ~52441

@DenisChenu:
This issue first occurred after your commit:
https://github.com/LimeSurvey/LimeSurvey/commit/fa2fae1efa728f569cbcb98dae52fea5a8778c77

Do you have any workaround for this?

DenisChenu

DenisChenu

2019-06-18 14:32

developer   ~52442

Last edited: 2019-06-18 14:33

View 2 revisions

Maybe at the bad place … session must be killed sure, maybe move it here : https://github.com/LimeSurvey/LimeSurvey/blob/master/application/controllers/survey/index.php#L73

Preview group or question must NEVER use existing $SESSION['survey'.$surveyid]['srid'] even if survey is activated

DenisChenu

DenisChenu

2019-06-18 19:26

developer   ~52451

This is NOT related to this commit …
Revert to previous : still buggy …
https://bugs.limesurvey.org/view.php?id=14987#c52446

DenisChenu

DenisChenu

2019-06-19 11:50

developer   ~52453

Ready to go : https://github.com/LimeSurvey/LimeSurvey/pull/1298

DenisChenu

DenisChenu

2019-06-28 12:27

developer   ~52626

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=29009

Related Changesets

LimeSurvey: master f8fb291c

2019-06-19 14:00:53

DenisChenu


Committer: GitHub Details Diff
Fixed issue 14936: Preview group : relevance on question broken (#1298)

Fixed issue 14987: Preview question not working
Dev: LimeExpressionManager:sPreviewMode
Dev: setVariableAndTokenMappingsForExpressionManager must have preview when it call
Dev: Don't need 1st step : preview must do whole
Dev: preview don't need checkForDataSecurityAccepted
Affected Issues
14936, 14987
mod - application/helpers/SurveyRuntimeHelper.php Diff File
mod - application/helpers/expressions/em_manager_helper.php Diff File

Issue History

Date Modified Username Field Change
2019-05-24 13:38 DenisChenu New Issue
2019-05-24 13:38 DenisChenu File Added: limesurvey_survey_noRelevanceOnPreviewGroup.lss
2019-05-24 13:39 DenisChenu File Added: Capture d’écran du 2019-05-24 13-39-06.png
2019-05-31 11:04 DenisChenu Relationship added has duplicate 14956
2019-06-17 18:17 cdorin Assigned To => dominikvitt
2019-06-17 18:17 cdorin Priority none => high
2019-06-17 18:17 cdorin Status new => assigned
2019-06-17 18:19 cdorin Relationship added related to 14987
2019-06-17 18:23 cdorin Relationship added related to 14988
2019-06-18 13:37 dominikvitt Note Added: 52441
2019-06-18 14:30 DenisChenu Assigned To dominikvitt => DenisChenu
2019-06-18 14:32 DenisChenu Note Added: 52442
2019-06-18 14:33 DenisChenu Note Edited: 52442 View Revisions
2019-06-18 19:26 DenisChenu Note Added: 52451
2019-06-19 11:50 DenisChenu Note Added: 52453
2019-06-19 14:01 DenisChenu Status assigned => resolved
2019-06-19 14:01 DenisChenu Resolution open => fixed
2019-06-19 14:01 DenisChenu Fixed in Version => 3.17.x
2019-06-28 12:27 DenisChenu Changeset attached => LimeSurvey master f8fb291c
2019-06-28 12:27 DenisChenu Note Added: 52626
2019-10-19 10:07 DenisChenu Status resolved => closed
2019-11-01 17:25 c_schmitz Category Survey design => Survey editing