Dependency Graph
View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
12353 | Bug reports | Survey taking | public | 2017-04-27 15:02 | 2017-07-21 17:11 |
Reporter | ollehar | Assigned To | |||
Priority | none | Severity | minor | ||
Status | closed | Resolution | fixed | ||
Summary | 12353: Sample survey - some EM not executed | ||||
Description | See attached survey, compare with master branch. Some EM is not executed in develop, it seems. | ||||
Tags | No tags attached. | ||||
Attached Files | |||||
Bug heat | 8 | ||||
Complete LimeSurvey version number (& build) | develop | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | - | ||||
Database type & version | - | ||||
Server OS (if known) | - | ||||
Webserver software & version (if known) | - | ||||
PHP Version | 7.1 | ||||
related to | 12360 | closed | DenisChenu | Big difference in HTML produced with previous develop version |
first observation: the problem already affected the answers_html branch |
|
What do you mean about answers_html branch . answers_html never exist really : http://testing.sondages.pro/answershtml/index.php/863316 on 99bdf08b23081d833b7dc497b3bb0ca9361ccf0c |
|
I mean that when reverting until the merge with answers_html (8/11/2016), the bug is already there. But it's just a quick observation, it sill needs more investigation. |
|
Strange, because i'm sure it work with some simple part (i tested it ....) |
|
Test with the attached survey, if you have time. |
|
Commit broke situation :
@olle : bad merging here ... I try replacing EM_core + EM_helper + qanda : better for HTML, but EM still broken. |
|
good catch Denis! thank you very much |
|
Well, fuck. |
|
Yezp, and more : i try to replace directly the 2 em files and the qanda : seems this didn't solve this issue .... :/ double f** |
|
The problem might be in a view, rather. I will check it today. |
|
I can't reproduce the problem with the merge. It still works for me in this commit: b46e70ee3a3b042fa27ffb876ba6e75234cfc5e9 |
|
For me, the EM worked before the twig-layout merge in develop branch: 71685ac145af96adfbe85d9eb22d36488f80516e
|
|
Also note that right after twig-layout merge, it's broken in one way, but in the most recent commit, it's broken in another way. |
|
First broken in this commit: Dev: replaced {QUESTION_TEXT} by twig logic. |
|
Arg, why it broke yesterday and not today .... maybe twig cache ? Sorry @olle for false alarm .... |
|
thx olle. |
|
This is the commit: 6ff35720d3854de4b230792670247d8bf25aa779 If you do "git checkout HEAD^" from that commit, it should work, meaning it's the breaking commit. |
|
Maybe just add the "raw" filter from Twig? https://twig.sensiolabs.org/doc/2.x/filters/raw.html |
|
Yes, adding "raw" seems to fix it: {{ aQuestion.text | raw}} |
|
Uh, nvm. It only fixes it in THAT commit, but not in the most recent commit, since there's a different problem there. |
|
New theory: When removing the templatereplace() function from SurveyRuntimeHelper, the EM ProcessString() is never called: |
|
Is it really a good idea to remove templatereplace entirely? Wouldn't it be better to just put Twig inside templatereplace instead? There's a lot of different logic in there. |
|
all the logic in templatereplace() has been moved to twig views. |
|
Fix committed to develop branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=22710 |
|
Version 3.0.0-beta.1 released |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2017-04-27 15:02 | ollehar | New Issue | |
2017-04-27 15:02 | ollehar | Status | new => assigned |
2017-04-27 15:02 | ollehar | Assigned To | => LouisGac |
2017-04-27 15:02 | ollehar | File Added: ls205_sample_survey_english.lss | |
2017-04-27 15:02 | ollehar | File Added: Selection_193.png | |
2017-04-27 15:02 | ollehar | File Added: Selection_192.png | |
2017-04-27 17:37 |
|
Sticky Issue | No => Yes |
2017-05-02 11:08 |
|
Note Added: 43513 | |
2017-05-02 15:03 | DenisChenu | Note Added: 43518 | |
2017-05-02 15:07 |
|
Note Added: 43519 | |
2017-05-02 15:08 | DenisChenu | Note Added: 43520 | |
2017-05-02 15:19 | ollehar | Note Added: 43521 | |
2017-05-02 16:33 | DenisChenu | Note Added: 43527 | |
2017-05-02 16:33 | DenisChenu | Relationship added | related to 12360 |
2017-05-02 16:37 |
|
Note Added: 43528 | |
2017-05-02 17:03 | ollehar | Note Added: 43530 | |
2017-05-02 17:41 | DenisChenu | Note Added: 43534 | |
2017-05-03 09:44 | ollehar | Note Added: 43536 | |
2017-05-03 10:59 | ollehar | Assigned To | LouisGac => ollehar |
2017-05-03 11:14 | ollehar | Note Added: 43538 | |
2017-05-03 11:27 | ollehar | Note Added: 43539 | |
2017-05-03 11:27 | ollehar | Assigned To | ollehar => LouisGac |
2017-05-03 11:28 | ollehar | Note Added: 43540 | |
2017-05-03 11:39 | ollehar | Note Added: 43541 | |
2017-05-03 11:41 | DenisChenu | Note Added: 43542 | |
2017-05-03 11:42 |
|
Note Added: 43543 | |
2017-05-03 11:45 | ollehar | Note Added: 43544 | |
2017-05-03 11:46 | ollehar | Note Added: 43545 | |
2017-05-03 11:48 | ollehar | Note Added: 43546 | |
2017-05-03 11:50 | ollehar | Note Added: 43547 | |
2017-05-03 11:57 | ollehar | Note Added: 43548 | |
2017-05-03 12:33 | ollehar | Note Added: 43552 | |
2017-05-03 12:45 |
|
Note Added: 43553 | |
2017-05-03 15:52 |
|
Changeset attached | => LimeSurvey develop 6654103f |
2017-05-03 15:52 |
|
Note Added: 43558 | |
2017-05-03 15:52 |
|
Resolution | open => fixed |
2017-05-03 17:00 |
|
Sticky Issue | Yes => No |
2017-05-03 17:00 |
|
Status | assigned => resolved |
2017-07-21 17:11 | c_schmitz | Note Added: 44189 | |
2017-07-21 17:11 | c_schmitz | Status | resolved => closed |