View Issue Details

This bug affects 1 person(s).
 4
IDProjectCategoryView StatusLast Update
09014Feature requestsImport/Exportpublic2014-06-16 14:15
Reporterronny_todgers Assigned To 
PrioritynormalSeverityfeature 
Status newResolutionopen 
Summary09014: Import of tab survey file always reports a null error and genuine errors reported only as "array"
Description

the recent fix to issue 08894: Error when importing an invalid file
has broken the import for txt survey files.

Importing a correctly formatted txt file produces an empty error report, and Importing a broken file produces an error report simply showing the word "array"

This seems to be because the errors are now stored in an array in $sErrorMessage rather than the original behaviour of that being used for a string description and the individual errors being stored in $aImportResults['error'].

I have had to hack the importSurvey_view.php file to be able to see the errors though the problem is clearly not in that file but in the recent changes to surveyAdmin.php as this is a new bug when I recently upgraded.

I could probably fix this but risk recreating whatever problem c-schmitz was fixing last month. It seems perhaps the correct solution might be modifying the reporting rather than returning the error storage to how it was?

TagsNo tags attached.
Attached Files
no_error.txt (13,624 bytes)   
class	type/scale	name	relevance	text	help	language	validation	mandatory	other	default	same_default	allowed_filetypes	alphasort	answer_width	array_filter	array_filter_exclude	array_filter_style	assessment_value	category_separator	choice_title	code_filter	commented_checkbox	commented_checkbox_auto	date_format	date_max	date_min	display_columns	display_rows	dropdown_dates	dropdown_dates_minute_step	dropdown_dates_month_style	dropdown_prefix	dropdown_prepostfix	dropdown_separators	dropdown_size	dualscale_headerA	dualscale_headerB	em_validation_q	em_validation_q_tip	em_validation_sq	em_validation_sq_tip	equals_num_value	exclude_all_others	exclude_all_others_auto	hidden	hide_tip	input_boxes	location_city	location_country	location_defaultcoordinates	location_mapheight	location_mapservice	location_mapwidth	location_mapzoom	location_nodefaultfromip	location_postal	location_state	max_answers	max_filesize	max_num_of_files	max_num_value	max_num_value_n	maximum_chars	min_answers	min_num_of_files	min_num_value	min_num_value_n	multiflexible_checkbox	multiflexible_max	multiflexible_min	multiflexible_step	num_value_int_only	numbers_only	other_comment_mandatory	other_numbers_only	other_replace_text	page_break	parent_order	prefix	printable_help	public_statistics	random_group	random_order	rank_title	repeat_headings	reverse	samechoiceheight	samelistheight	scale_export	show_comment	show_grand_total	show_title	show_totals	showpopups	slider_accuracy	slider_default	slider_layout	slider_max	slider_middlestart	slider_min	slider_rating	slider_reset	slider_separator	slider_showminmax	statistics_graphtype	statistics_showgraph	statistics_showmap	suffix	text_input_width	time_limit	time_limit_action	time_limit_countdown_message	time_limit_disable_next	time_limit_disable_prev	time_limit_message	time_limit_message_delay	time_limit_message_style	time_limit_timer_style	time_limit_warning	time_limit_warning_2	time_limit_warning_2_display_time	time_limit_warning_2_message	time_limit_warning_2_style	time_limit_warning_display_time	time_limit_warning_message	time_limit_warning_style	use_dropdown
S		sid		135891																																																																																																																											
S		owner_id		1																																																																																																																											
S		admin		Administrator																																																																																																																											
S		active		N																																																																																																																											
S		adminemail		john@delosis.com																																																																																																																											
S		anonymized		N																																																																																																																											
S		format		G																																																																																																																											
S		savetimings		N																																																																																																																											
S		template		citronade																																																																																																																											
S		language		en																																																																																																																											
S		datestamp		N																																																																																																																											
S		usecookie		N																																																																																																																											
S		allowregister		N																																																																																																																											
S		allowsave		Y																																																																																																																											
S		autoredirect		N																																																																																																																											
S		allowprev		N																																																																																																																											
S		printanswers		N																																																																																																																											
S		ipaddr		N																																																																																																																											
S		refurl		N																																																																																																																											
S		datecreated		2014-05-01																																																																																																																											
S		publicstatistics		N																																																																																																																											
S		publicgraphs		N																																																																																																																											
S		listpublic		N																																																																																																																											
S		htmlemail		Y																																																																																																																											
S		sendconfirmation		Y																																																																																																																											
S		tokenanswerspersistence		N																																																																																																																											
S		assessments		N																																																																																																																											
S		usecaptcha		D																																																																																																																											
S		usetokens		N																																																																																																																											
S		bounce_email		john@delosis.com																																																																																																																											
S		tokenlength		15																																																																																																																											
S		showxquestions		Y																																																																																																																											
S		showgroupinfo		B																																																																																																																											
S		shownoanswer		Y																																																																																																																											
S		showqnumcode		X																																																																																																																											
S		bounceprocessing		N																																																																																																																											
S		showwelcome		Y																																																																																																																											
S		showprogress		Y																																																																																																																											
S		nokeyboard		N																																																																																																																											
S		alloweditaftercompletion		N																																																																																																																											
SL		surveyls_title		TEST		en																																																																																																																									
SL		surveyls_email_invite_subj		Invitation to participate in a survey		en																																																																																																																									
SL		surveyls_email_invite		Dear {FIRSTNAME},<br /> <br /> you have been invited to participate in a survey.<br /> <br /> The survey is titled:<br /> "{SURVEYNAME}"<br /> <br /> "{SURVEYDESCRIPTION}"<br /> <br /> To participate, please click on the link below.<br /> <br /> Sincerely,<br /> <br /> {ADMINNAME} ({ADMINEMAIL})<br /> <br /> ----------------------------------------------<br /> Click here to do the survey:<br /> {SURVEYURL}<br /> <br /> If you do not want to participate in this survey and don't want to receive any more invitations please click the following link:<br /> {OPTOUTURL}<br /> <br /> If you are blacklisted but want to participate in this survey and want to receive invitations please click the following link:<br /> {OPTINURL}		en																																																																																																																									
SL		surveyls_email_remind_subj		Reminder to participate in a survey		en																																																																																																																									
SL		surveyls_email_remind		Dear {FIRSTNAME},<br /> <br /> Recently we invited you to participate in a survey.<br /> <br /> We note that you have not yet completed the survey, and wish to remind you that the survey is still available should you wish to take part.<br /> <br /> The survey is titled:<br /> "{SURVEYNAME}"<br /> <br /> "{SURVEYDESCRIPTION}"<br /> <br /> To participate, please click on the link below.<br /> <br /> Sincerely,<br /> <br /> {ADMINNAME} ({ADMINEMAIL})<br /> <br /> ----------------------------------------------<br /> Click here to do the survey:<br /> {SURVEYURL}<br /> <br /> If you do not want to participate in this survey and don't want to receive any more invitations please click the following link:<br /> {OPTOUTURL}		en																																																																																																																									
SL		surveyls_email_register_subj		Survey registration confirmation		en																																																																																																																									
SL		surveyls_email_register		Dear {FIRSTNAME},<br /> <br /> You, or someone using your email address, have registered to participate in an online survey titled {SURVEYNAME}.<br /> <br /> To complete this survey, click on the following URL:<br /> <br /> {SURVEYURL}<br /> <br /> If you have any questions about this survey, or if you did not register to participate and believe this email is in error, please contact {ADMINNAME} at {ADMINEMAIL}.		en																																																																																																																									
SL		surveyls_email_confirm_subj		Confirmation of your participation in our survey		en																																																																																																																									
SL		surveyls_email_confirm		Dear {FIRSTNAME},<br /> <br /> this email is to confirm that you have completed the survey titled {SURVEYNAME} and your response has been saved. Thank you for participating.<br /> <br /> If you have any further questions about this email, please contact {ADMINNAME} on {ADMINEMAIL}.<br /> <br /> Sincerely,<br /> <br /> {ADMINNAME}		en																																																																																																																									
SL		surveyls_dateformat		9		en																																																																																																																									
SL		email_admin_notification_subj		Response submission for survey {SURVEYNAME}		en																																																																																																																									
SL		email_admin_notification		Hello,<br /> <br /> A new response was submitted for your survey '{SURVEYNAME}'.<br /> <br /> Click the following link to reload the survey:<br /> {RELOADURL}<br /> <br /> Click the following link to see the individual response:<br /> {VIEWRESPONSEURL}<br /> <br /> Click the following link to edit the individual response:<br /> {EDITRESPONSEURL}<br /> <br /> View statistics by clicking here:<br /> {STATISTICSURL}		en																																																																																																																									
SL		email_admin_responses_subj		Response submission for survey {SURVEYNAME} with results		en																																																																																																																									
SL		email_admin_responses		Hello,<br /> <br /> A new response was submitted for your survey '{SURVEYNAME}'.<br /> <br /> Click the following link to reload the survey:<br /> {RELOADURL}<br /> <br /> Click the following link to see the individual response:<br /> {VIEWRESPONSEURL}<br /> <br /> Click the following link to edit the individual response:<br /> {EDITRESPONSEURL}<br /> <br /> View statistics by clicking here:<br /> {STATISTICSURL}<br /> <br /> <br /> The following answers were given by the participant:<br /> {ANSWERTABLE}		en																																																																																																																									
G	G0	TEST	1			en																																																																																																																									
Q	Y	testage	1			en			N		1																																																																																															1																					
no_error.txt (13,624 bytes)   
genunine_error.txt (13,625 bytes)   
class	type/scale	name	relevance	text	help	language	validation	mandatory	other	default	same_default	allowed_filetypes	alphasort	answer_width	array_filter	array_filter_exclude	array_filter_style	assessment_value	category_separator	choice_title	code_filter	commented_checkbox	commented_checkbox_auto	date_format	date_max	date_min	display_columns	display_rows	dropdown_dates	dropdown_dates_minute_step	dropdown_dates_month_style	dropdown_prefix	dropdown_prepostfix	dropdown_separators	dropdown_size	dualscale_headerA	dualscale_headerB	em_validation_q	em_validation_q_tip	em_validation_sq	em_validation_sq_tip	equals_num_value	exclude_all_others	exclude_all_others_auto	hidden	hide_tip	input_boxes	location_city	location_country	location_defaultcoordinates	location_mapheight	location_mapservice	location_mapwidth	location_mapzoom	location_nodefaultfromip	location_postal	location_state	max_answers	max_filesize	max_num_of_files	max_num_value	max_num_value_n	maximum_chars	min_answers	min_num_of_files	min_num_value	min_num_value_n	multiflexible_checkbox	multiflexible_max	multiflexible_min	multiflexible_step	num_value_int_only	numbers_only	other_comment_mandatory	other_numbers_only	other_replace_text	page_break	parent_order	prefix	printable_help	public_statistics	random_group	random_order	rank_title	repeat_headings	reverse	samechoiceheight	samelistheight	scale_export	show_comment	show_grand_total	show_title	show_totals	showpopups	slider_accuracy	slider_default	slider_layout	slider_max	slider_middlestart	slider_min	slider_rating	slider_reset	slider_separator	slider_showminmax	statistics_graphtype	statistics_showgraph	statistics_showmap	suffix	text_input_width	time_limit	time_limit_action	time_limit_countdown_message	time_limit_disable_next	time_limit_disable_prev	time_limit_message	time_limit_message_delay	time_limit_message_style	time_limit_timer_style	time_limit_warning	time_limit_warning_2	time_limit_warning_2_display_time	time_limit_warning_2_message	time_limit_warning_2_style	time_limit_warning_display_time	time_limit_warning_message	time_limit_warning_style	use_dropdown
S		sid		135891																																																																																																																											
S		owner_id		1																																																																																																																											
S		admin		Administrator																																																																																																																											
S		active		N																																																																																																																											
S		adminemail		john@delosis.com																																																																																																																											
S		anonymized		N																																																																																																																											
S		format		G																																																																																																																											
S		savetimings		N																																																																																																																											
S		template		citronade																																																																																																																											
S		language		en																																																																																																																											
S		datestamp		N																																																																																																																											
S		usecookie		N																																																																																																																											
S		allowregister		N																																																																																																																											
S		allowsave		Y																																																																																																																											
S		autoredirect		N																																																																																																																											
S		allowprev		N																																																																																																																											
S		printanswers		N																																																																																																																											
S		ipaddr		N																																																																																																																											
S		refurl		N																																																																																																																											
S		datecreated		2014-05-01																																																																																																																											
S		publicstatistics		N																																																																																																																											
S		publicgraphs		N																																																																																																																											
S		listpublic		N																																																																																																																											
S		htmlemail		Y																																																																																																																											
S		sendconfirmation		Y																																																																																																																											
S		tokenanswerspersistence		N																																																																																																																											
S		assessments		N																																																																																																																											
S		usecaptcha		D																																																																																																																											
S		usetokens		N																																																																																																																											
S		bounce_email		john@delosis.com																																																																																																																											
S		tokenlength		15																																																																																																																											
S		showxquestions		Y																																																																																																																											
S		showgroupinfo		B																																																																																																																											
S		shownoanswer		Y																																																																																																																											
S		showqnumcode		X																																																																																																																											
S		bounceprocessing		N																																																																																																																											
S		showwelcome		Y																																																																																																																											
S		showprogress		Y																																																																																																																											
S		nokeyboard		N																																																																																																																											
S		alloweditaftercompletion		N																																																																																																																											
SL		surveyls_title		TEST		en																																																																																																																									
SL		surveyls_email_invite_subj		Invitation to participate in a survey		en																																																																																																																									
SL		surveyls_email_invite		Dear {FIRSTNAME},<br /> <br /> you have been invited to participate in a survey.<br /> <br /> The survey is titled:<br /> "{SURVEYNAME}"<br /> <br /> "{SURVEYDESCRIPTION}"<br /> <br /> To participate, please click on the link below.<br /> <br /> Sincerely,<br /> <br /> {ADMINNAME} ({ADMINEMAIL})<br /> <br /> ----------------------------------------------<br /> Click here to do the survey:<br /> {SURVEYURL}<br /> <br /> If you do not want to participate in this survey and don't want to receive any more invitations please click the following link:<br /> {OPTOUTURL}<br /> <br /> If you are blacklisted but want to participate in this survey and want to receive invitations please click the following link:<br /> {OPTINURL}		en																																																																																																																									
SL		surveyls_email_remind_subj		Reminder to participate in a survey		en																																																																																																																									
SL		surveyls_email_remind		Dear {FIRSTNAME},<br /> <br /> Recently we invited you to participate in a survey.<br /> <br /> We note that you have not yet completed the survey, and wish to remind you that the survey is still available should you wish to take part.<br /> <br /> The survey is titled:<br /> "{SURVEYNAME}"<br /> <br /> "{SURVEYDESCRIPTION}"<br /> <br /> To participate, please click on the link below.<br /> <br /> Sincerely,<br /> <br /> {ADMINNAME} ({ADMINEMAIL})<br /> <br /> ----------------------------------------------<br /> Click here to do the survey:<br /> {SURVEYURL}<br /> <br /> If you do not want to participate in this survey and don't want to receive any more invitations please click the following link:<br /> {OPTOUTURL}		en																																																																																																																									
SL		surveyls_email_register_subj		Survey registration confirmation		en																																																																																																																									
SL		surveyls_email_register		Dear {FIRSTNAME},<br /> <br /> You, or someone using your email address, have registered to participate in an online survey titled {SURVEYNAME}.<br /> <br /> To complete this survey, click on the following URL:<br /> <br /> {SURVEYURL}<br /> <br /> If you have any questions about this survey, or if you did not register to participate and believe this email is in error, please contact {ADMINNAME} at {ADMINEMAIL}.		en																																																																																																																									
SL		surveyls_email_confirm_subj		Confirmation of your participation in our survey		en																																																																																																																									
SL		surveyls_email_confirm		Dear {FIRSTNAME},<br /> <br /> this email is to confirm that you have completed the survey titled {SURVEYNAME} and your response has been saved. Thank you for participating.<br /> <br /> If you have any further questions about this email, please contact {ADMINNAME} on {ADMINEMAIL}.<br /> <br /> Sincerely,<br /> <br /> {ADMINNAME}		en																																																																																																																									
SL		surveyls_dateformat		9		en																																																																																																																									
SL		email_admin_notification_subj		Response submission for survey {SURVEYNAME}		en																																																																																																																									
SL		email_admin_notification		Hello,<br /> <br /> A new response was submitted for your survey '{SURVEYNAME}'.<br /> <br /> Click the following link to reload the survey:<br /> {RELOADURL}<br /> <br /> Click the following link to see the individual response:<br /> {VIEWRESPONSEURL}<br /> <br /> Click the following link to edit the individual response:<br /> {EDITRESPONSEURL}<br /> <br /> View statistics by clicking here:<br /> {STATISTICSURL}		en																																																																																																																									
SL		email_admin_responses_subj		Response submission for survey {SURVEYNAME} with results		en																																																																																																																									
SL		email_admin_responses		Hello,<br /> <br /> A new response was submitted for your survey '{SURVEYNAME}'.<br /> <br /> Click the following link to reload the survey:<br /> {RELOADURL}<br /> <br /> Click the following link to see the individual response:<br /> {VIEWRESPONSEURL}<br /> <br /> Click the following link to edit the individual response:<br /> {EDITRESPONSEURL}<br /> <br /> View statistics by clicking here:<br /> {STATISTICSURL}<br /> <br /> <br /> The following answers were given by the participant:<br /> {ANSWERTABLE}		en																																																																																																																									
G	G0	TEST	1			en																																																																																																																									
Q	Y	test_age	1			en			N		1																																																																																															1																					
genunine_error.txt (13,625 bytes)   
Bug heat4
Story point estimate
Users affected %

Users monitoring this issue

jdvalentine

Activities

jdvalentine

jdvalentine

2014-06-16 14:07

reporter   ~30100

Last edited: 2014-06-16 14:15

I fixed this by replacing line 6 of importSurvey_view.php.

// So after this line:
<div class='errorheader'><?php $clang->eT("Error");?></div>
// write:

    <?php
        if(is_array($sErrorMessage))
        {   
            foreach($sErrorMessage as $error) 
                echo $error."<br />";
        } else 
        {   
            echo $sErrorMessage;
        }   
  ?><br /><br />

</code>

(no matter what I do I can't make this look right in this notes box, as it seems to strip some HTML. Look here: http://pastebin.com/kUCd45wf)

This is the same approach used when outputting error after success, further down the page.

Issue History

Date Modified Username Field Change
2014-05-01 16:53 ronny_todgers New Issue
2014-05-01 16:53 ronny_todgers File Added: no_error.txt
2014-05-01 16:53 ronny_todgers File Added: genunine_error.txt
2014-06-16 14:07 jdvalentine Note Added: 30100
2014-06-16 14:07 jdvalentine Issue Monitored: jdvalentine
2014-06-16 14:09 jdvalentine Note Edited: 30100
2014-06-16 14:09 jdvalentine Note Edited: 30100
2014-06-16 14:10 jdvalentine Note Edited: 30100
2014-06-16 14:12 jdvalentine Note Edited: 30100
2014-06-16 14:15 jdvalentine Note Edited: 30100