View Issue Details

This bug affects 1 person(s).
 6
IDProjectCategoryView StatusLast Update
08634Bug reportsSurvey takingpublic2014-02-04 13:32
Reportermdekker Assigned Tomdekker  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version2.05+ 
Target Version2.05+Fixed in Version2.05+ 
Summary08634: Resuming a saved survey goes to wrong page
Description

When resuming a token based survey, currently i seem to always go back one step.

Steps To Reproduce

Create a survey with tokens, allow save and token based persistence.
Go to page 2, put some answer and save the survey.
Close browser (to clear any session)
Use the token link again
You are now at the first page again. Clicking next, you will see the already answers question(s) from the second page.

TagsNo tags attached.
Bug heat6
Complete LimeSurvey version number (& build)83259e954b1d0f4d3662065c1e7b
I will donate to the project if issue is resolvedNo
Browser
Database type & version.
Server OS (if known).
Webserver software & version (if known).
PHP Version.

Users monitoring this issue

There are no users monitoring this issue.

Activities

mdekker

mdekker

2014-01-30 16:22

reporter   ~28284

Fix seems really easy, need to test what happens when saving on last page.

DenisChenu

DenisChenu

2014-01-30 19:51

developer   ~28287

Last edited: 2014-01-31 09:16

The $step-- was already in 1.92, maybe it not needed now ?

Denis

Think it's in loadanswers function.
PS: yes we have $thisstep=$value-1; but really don't know why and when we need it (and when it's used to relly set step -1).

mdekker

mdekker

2014-02-03 09:39

reporter   ~28425

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=13824

mdekker

mdekker

2014-02-03 09:46

reporter   ~28426

Could not find where the step -1 was really used. Seemed not to affect anything when i changed it. Did some tests and the change seems to work fine. If anyone finds errors, please reopen and I will see what I can do.

c_schmitz

c_schmitz

2014-02-04 13:32

administrator   ~28507

Version 2.05+ Build 140204 released

Related Changesets

LimeSurvey: master 697e348e

2014-02-03 08:32:30

mdekker

Details Diff
Fixed 08634: Resuming a saved survey goes to wrong page
dev: removed unused method fro Save.php
Affected Issues
08634
mod - application/helpers/SurveyRuntimeHelper.php Diff File
mod - application/libraries/Save.php Diff File

Issue History

Date Modified Username Field Change
2014-01-30 16:13 mdekker New Issue
2014-01-30 16:22 mdekker Note Added: 28284
2014-01-30 19:51 DenisChenu Note Added: 28287
2014-01-30 19:56 DenisChenu Note Edited: 28287
2014-01-31 09:16 DenisChenu Note Edited: 28287
2014-02-03 09:39 mdekker Changeset attached => LimeSurvey master 697e348e
2014-02-03 09:39 mdekker Note Added: 28425
2014-02-03 09:39 mdekker Assigned To => mdekker
2014-02-03 09:39 mdekker Resolution open => fixed
2014-02-03 09:46 mdekker Note Added: 28426
2014-02-03 09:46 mdekker Status new => resolved
2014-02-03 09:46 mdekker Fixed in Version => 2.05+
2014-02-04 13:32 c_schmitz Note Added: 28507
2014-02-04 13:32 c_schmitz Status resolved => closed