View Issue Details

This bug affects 1 person(s).
 6
IDProjectCategoryView StatusLast Update
08332Bug reportsTheme editorpublic2013-11-07 15:00
ReporterMazi Assigned Toc_schmitz  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version2.00+ 
Target Version2.00+Fixed in Version2.00+ 
Summary08332: JS files are not imported during template import
Description

When importing a template from ZIP, the included JS files are not imported.

Steps To Reproduce

Import a template ZIP file and search for e.g. template.js

TagsNo tags attached.
Bug heat6
Complete LimeSurvey version number (& build)131009
I will donate to the project if issue is resolvedNo
BrowserChrome
Database type & versionMySQL 5
Server OS (if known)Linux
Webserver software & version (if known)Apache 2
PHP Version5.3.1

Relationships

child of 08038 closedDenisChenu Can't upload image files to a custom template 

Users monitoring this issue

There are no users monitoring this issue.

Activities

c_schmitz

c_schmitz

2013-11-04 12:11

administrator   ~27077

Caused by fix for 08038

DenisChenu

DenisChenu

2013-11-04 12:24

developer   ~27078

Don't understand ?
I don't touch at template_helper.php.
Why it can change something ?

I have this problem on some server, but it's a server security (no js file in upload by php).

Mazi

Mazi

2013-11-04 13:01

updater   ~27080

This issues suddenly shows up on a server where I have never had any problems with importing JS files.

c_schmitz

c_schmitz

2013-11-04 14:24

administrator   ~27081

It is caused by the changes to config-defaults.php

https://github.com/LimeSurvey/LimeSurvey/commit/a69a383c772fe1bba2f9b786e5cae16d2e85bdce

DenisChenu

DenisChenu

2013-11-04 14:35

developer   ~27082

Yes,

See : using allowedresourcesuploads and not allowedtemplateuploads

Maybe we have to test if css and js file are in allowedtemplateuploads, if not allow template.css/template.js template-rtl.css ?

c_schmitz

c_schmitz

2013-11-04 16:43

administrator   ~27083

Fix committed to 2.05 branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=13406

c_schmitz

c_schmitz

2013-11-07 15:00

administrator   ~27129

Version 2.00+ Build 131107 released.

Related Changesets

LimeSurvey: 2.05 6470cb89

2013-11-04 11:11:42

c_schmitz

Details Diff
Fixed issue 08332: JS files are not imported during template import Affected Issues
08332
mod - application/helpers/admin/template_helper.php Diff File

Issue History

Date Modified Username Field Change
2013-11-04 11:25 Mazi New Issue
2013-11-04 11:25 Mazi Status new => assigned
2013-11-04 11:25 Mazi Assigned To => c_schmitz
2013-11-04 12:11 c_schmitz Relationship added child of 08038
2013-11-04 12:11 c_schmitz Note Added: 27077
2013-11-04 12:16 c_schmitz Status assigned => resolved
2013-11-04 12:16 c_schmitz Fixed in Version => 2.00+
2013-11-04 12:16 c_schmitz Resolution open => fixed
2013-11-04 12:24 DenisChenu Note Added: 27078
2013-11-04 13:01 Mazi Note Added: 27080
2013-11-04 14:24 c_schmitz Note Added: 27081
2013-11-04 14:35 DenisChenu Note Added: 27082
2013-11-04 16:43 c_schmitz Changeset attached => LimeSurvey 2.05 6470cb89
2013-11-04 16:43 c_schmitz Note Added: 27083
2013-11-07 15:00 c_schmitz Note Added: 27129
2013-11-07 15:00 c_schmitz Status resolved => closed
2015-12-11 14:40 c_schmitz Category Templates => Theme editor