View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 10
IDProjectCategoryView StatusDate SubmittedLast Update
08267Bug reportsPrint Viewpublic2013-10-12 14:172013-11-07 15:00
Reportermfaber Assigned Toc_schmitz  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version2.05 RC 
Fixed in Version2.00+ 
Summary08267: Conditions in print view are incorrect when referring to 5-point choice question
Description

When a condition is set so the question is only display when a previous 5-point question is ANSWER1 or ANSWER2 or ANSWER3
the condition printed is

answer only if answer was at question1 AND answer was at question1 AND answer was at question1.

Actual answer is missing and answers should be ORed instead of ANDed

Steps To Reproduce

import attached survey
have a look at the print version

TagsNo tags attached.
Attached Files
limesurvey_survey_671624.lss (15,011 bytes)
Bug heat10
Complete LimeSurvey version number (& build)131012
I will donate to the project if issue is resolvedNo
BrowserFF
Database type & versionMySQL 5.0.10
Server OS (if known)Win7
Webserver software & version (if known)Apache/2.4.3 (Win32)
PHP VersionPhP 5.4.7

Relationships

Relationship GraphDependency Graph
related to 07299 closedc_schmitz Unable to Print View 
has duplicate 08269 closedc_schmitz Conditions in print view appear multiple times 

Users monitoring this issue

There are no users monitoring this issue.

Activities

c_schmitz

c_schmitz

2013-10-22 22:01

administrator   ~26931

Ok, that's some fugly code that needs a proper rewrite. Thing is I am not sure that it is worth it for 2.05 anymore. I am for moving this to target version 2.1.
c_schmitz

c_schmitz

2013-10-22 22:08

administrator   ~26932

08269 is the same issue/origin so I will close it.
mfaber

mfaber

2013-10-22 23:11

reporter   ~26935

Realistically 2.1 is several months maybe even a year away. Maybe we can at least have a quick fix :) so the print version is usable again. It used to work quite well in 2.0+.
For me, features that just stop working in a new version are the biggest nuissance software has to offer :-P.
c_schmitz

c_schmitz

2013-10-22 23:30

administrator   ~26936

Are you sure? I am pretty confident this bug is in 2.0, too.
mfaber

mfaber

2013-10-23 00:06

reporter   ~26937

Just checked out master and the problem is indeed there :(
However, the bug with the conditions appearing multiple times seems to have been introduced with a commit from 24 february 2013.

https://github.com/LimeSurvey/LimeSurvey/commit/3edb91ee8416ce7d2d64ee2d5943043538e96cc2
c_schmitz

c_schmitz

2013-10-23 00:35

administrator   ~26938

Good catch, I will have another look.
c_schmitz

c_schmitz

2013-10-23 13:48

administrator   ~26944

Fix committed to 2.05 branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=13344
c_schmitz

c_schmitz

2013-10-23 13:50

administrator   ~26945

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=13345
c_schmitz

c_schmitz

2013-10-23 13:51

administrator   ~26946

Thank you, that helped alot.
mfaber

mfaber

2013-10-23 18:57

reporter   ~26963

Thanks for the fix :)
c_schmitz

c_schmitz

2013-11-07 15:00

administrator   ~27134

Version 2.00+ Build 131107 released.

Related Changesets

LimeSurvey: 2.05 035720f4

2013-10-23 11:47:56

c_schmitz

Details Diff 		Fixed issue 08267: Conditions in print view are incorrect and duplicated when referring to certain question types Affected Issues
08267
mod - application/controllers/admin/printablesurvey.php Diff File

LimeSurvey: master 1dd7ceed

2013-10-23 11:50:42

c_schmitz

Details Diff 		Fixed issue 08267: Conditions in print view are incorrect and duplicated when referring to certain question types Affected Issues
08267
mod - application/controllers/admin/printablesurvey.php Diff File

Issue History

Date Modified Username Field Change
2013-10-12 14:17 mfaber New Issue
2013-10-12 16:21 mfaber Description Updated
2013-10-12 16:21 mfaber Steps to Reproduce Updated
2013-10-12 16:21 mfaber File Added: limesurvey_survey_671624.lss
2013-10-12 17:00 mfaber Summary Conditions in print view are falsely ANDed together when they should be ORed => Conditions in print view are incorrect when referring to 5-point choice question
2013-10-12 17:05 mfaber Issue cloned: 08269
2013-10-12 17:05 mfaber Relationship added related to 08269
2013-10-12 17:06 mfaber Product Version 2.00+ => 2.05 RC
2013-10-22 20:55 c_schmitz Assigned To => c_schmitz
2013-10-22 20:55 c_schmitz Status new => assigned
2013-10-22 22:01 c_schmitz Note Added: 26931
2013-10-22 22:01 c_schmitz Status assigned => new
2013-10-22 22:02 c_schmitz Assigned To c_schmitz =>
2013-10-22 22:08 c_schmitz Note Added: 26932
2013-10-22 22:08 c_schmitz Relationship replaced has duplicate 08269
2013-10-22 23:11 mfaber Note Added: 26935
2013-10-22 23:30 c_schmitz Note Added: 26936
2013-10-23 00:06 mfaber Note Added: 26937
2013-10-23 00:35 c_schmitz Note Added: 26938
2013-10-23 00:35 c_schmitz Assigned To => c_schmitz
2013-10-23 00:35 c_schmitz Status new => assigned
2013-10-23 10:39 c_schmitz Relationship added related to 07299
2013-10-23 13:48 c_schmitz Changeset attached => LimeSurvey 2.05 035720f4
2013-10-23 13:48 c_schmitz Note Added: 26944
2013-10-23 13:48 c_schmitz Resolution open => fixed
2013-10-23 13:50 c_schmitz Changeset attached => LimeSurvey master 1dd7ceed
2013-10-23 13:50 c_schmitz Note Added: 26945
2013-10-23 13:51 c_schmitz Note Added: 26946
2013-10-23 13:51 c_schmitz Status assigned => resolved
2013-10-23 13:51 c_schmitz Fixed in Version => 2.00+
2013-10-23 18:57 mfaber Note Added: 26963
2013-11-07 15:00 c_schmitz Note Added: 27134
2013-11-07 15:00 c_schmitz Status resolved => closed