The UI might be counterintuitive, but I think this is more of a feature request than a bug.

You might think it adds the group itself, but it actually adds the group's users (those currently in the group). In fact, the button says "Add group users," not "Add user group."

In other words, if you add more users to the group later, they won't be added to the survey. So, it doesn't make sense for empty groups to appear there.

image.png (10,245 bytes)   

image.png (10,245 bytes)   

I don't see any PR, and I think this is an issue. I have a group with 2 users, and when I select the group and click on "Add group users" I expect these users to be added. Not that I add one user from this group first, and then I am able to add the group.

https://github.com/LimeSurvey/LimeSurvey/pull/4710

At last this was a JS issue, related to pjax.
Not a functionality thing.

surveypermissions.js was not getting loaded at the first time.
These kind of screens generally load via pjax.
You go into the survey overview, and then to the permissions screen via pjax. In that case, the JS wasn't loding.

When adding a user (which think submits a form without needing the JS), the page reloads directly (without pjax) and then it starts working because the JS does gets loaded without pjax.

I think this kind of errors are not the first time they happens.
Maybe we could add a test that:

• scans all source code
• looks for this kind of statements App()->getClientScript()->registerScriptFile(App()->getConfig('adminscripts') . 'surveypermissions.js', CClientScript::POS_END);
• Fail if the argument CClientScript::POS_XXXX is not used.

So devs are forced to decide if they want to add it in the head or end.

I think this kind of errors are not the first time they happens.

:+1:

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=39343

Fixed in Release 6.16.9+260217

Also posting here that the fix causes another issue: https://github.com/LimeSurvey/LimeSurvey/pull/4710#issuecomment-4083814102

It seems that when initially visiting another route and navigating to the Survey permissions view indirectly via the sidemenu, for example, the following error is thrown, also breaking form submission logic on other views thereafter:
Uncaught TypeError: $(...).tablesorter is not a function surveypermissions.js:10:26.

Reverting the change fixes it. I believe this is due to the way packages are loaded into a view, a similar issue to this PR actually. Visiting the Survey permissiosn route directly works as expected, no error given.

@gabrieljenik can you take a look at this please?