It's not a global issue : it must be done for each parameter, and move to controller.

It's a way to fix when when update.

Telle me how i can create a PR for fixing such situatuation : https://github.com/LimeSurvey/LimeSurvey/blob/master/application/models/QuestionBaseDataSet.php#L41

An App::getSurveyId ?

App::getId($string); where string can be survey, question, questiongroup ?

My idea

Use a getParam (and setParam in https://github.com/LimeSurvey/LimeSurvey/blob/master/application/core/LSYii_Application.php)

1. in __conctruct https://github.com/LimeSurvey/LimeSurvey/blob/1db969d592e05a1c48e3e610946e193e5bfd5ded/application/core/LSYii_Application.php#L74
   • Set sid, gid, qid and maybe some other
   • Allow : integer + null + '' and mlaybve some specific (new ?)
   • Send 400 if not
   • Control if gid is inside current sid and qid inside sif and gid (like we do in 2.6)
2. Add a App()->getParam(['sid','gid','qid']);
   • return current poaram or null

I can not start without discussion. I really dislike to work for nothing.

@c_schmitz could you please provide your opinion here?

Start for survey ID here https://github.com/LimeSurvey/LimeSurvey/pull/4469

Looks fine to me.

I add getGid and getQid after

And in my opinion : qid must use sid if exist (then we are sure it's related to the good survey), and maybe if sid is not set : set it.