View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
19960 | Bug reports | Survey participants (Tokens) | public | 2025-02-12 12:48 | 2025-02-21 21:04 |
Reporter | tassoman | Assigned To | gabrieljenik | ||
Priority | none | Severity | minor | ||
Status | in code review | Resolution | open | ||
Product Version | 6.6.x | ||||
Summary | 19960: Registration Form spamming19 | ||||
Description | When you set "public registration" attribute on, survey starts asking personal data (see: 19958) when you register https://limesurvey.local/index.php/register/index?sid=938936 you're sending a POST request. | ||||
Steps To Reproduce | Steps to reproduceCreate a survey Expected resultAs administrator I want survey participant to register only once per session. Actual resultEmail address in POST data gets automatically spammed at each request. | ||||
Tags | participants, public registration, spam | ||||
Bug heat | 10 | ||||
Complete LimeSurvey version number (& build) | 6.10.x | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | Any | ||||
Database type & version | Any | ||||
Server OS (if known) | Any | ||||
Webserver software & version (if known) | Any | ||||
PHP Version | 8.2 | ||||
We allow same email used again and again ? |
|
Hello @DenisChenu actually, the same token gets spammed many times. Maybe only one request per session is not enough, when people can't receive instantly their email for example. |
|
It is true, someone could spam someone else's email account using Limesurvey. But only one participant is being created with the same email address. |
|
I'm sorry I wrong typed Expected result. As you noted, registration is ok, happens only once. Correct user story is: Implementation suggestion:
Optional UI-UX interface
|
|
If you want to do very well perfectly. Form should trigger "invited datetime" only first time when not existant. On token creation. Instead of using a new configuration value, maybe already existent reminder notification rules can be used.
But I'm still in favour for a configurable time in seconds. |
|
Oh yes : in 3.X : we send "Already registered" but no email. New global configuration ? Throttle to 3600s by default ? No need JS |
|
We need to keep this :it's a good solution. But need a throttle (and a different message) byè config.php (for starting, adding it in GUI are a feature) |
|
Right now the solution avoids spam. Only sends email once. |
|
It was a feature request done between 3 and 5 : receive the email when registered a second time with same email. |
|
There is a sent field on the token tables. |
|
And we update it when we send email by register.
Yes, or by a config.php setting (best IMHO) |
|
That would be a bigger scope, a Feature Request. |
|
Is it necessary to save how many times a token was sent? I agree too much implementation. |
|
That may create confusion in the reminder system. What we wouldn't be able to do is control how many times per day (or absolute) to be sent. @tibor.pacalat we need a decision here. Thanks! |
|
@gabrieljenik I would say once per day max is fine. Can we also provide feedback to the user? |
|
Yes, we would send different messages for the different situations |
|
No, just limit by hour, you write day : i think best is to set a value in hour (maybe minute) to do not send it each second. Just : if now - sent < app()->getConfig('register_throttle') There are no mimit by X , just don't send it each miliseocnds. I think one hour by default is great. Like when trying to register on any website : you can ask a second code after X minutes. |
|
Adding a minimum delay between each sending is what needs to be done to avoid large-scale spam and the blocking of the email address. |
|
Updated the PR. https://github.com/LimeSurvey/LimeSurvey/pull/4170/files#diff-6f4ac27feb3ec162fd8a3d164030e24d3d121a2df9768a626ce18d9e4649fbc4R352 Shall we plan that on another ticket @tibor.pacalat? Thoughts? |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2025-02-12 12:48 | tassoman | New Issue | |
2025-02-12 12:49 | tassoman | Tag Attached: public registration | |
2025-02-12 12:49 | tassoman | Tag Attached: participants | |
2025-02-12 12:49 | tassoman | Tag Attached: spam | |
2025-02-12 13:06 | tassoman | Issue Monitored: tassoman | |
2025-02-12 13:06 | tassoman | Bug heat | 0 => 2 |
2025-02-12 13:14 | DenisChenu | Note Added: 82010 | |
2025-02-12 13:14 | DenisChenu | Bug heat | 2 => 4 |
2025-02-12 16:10 | tassoman | Note Added: 82012 | |
2025-02-12 16:10 | tassoman | Bug heat | 4 => 6 |
2025-02-12 17:37 | tibor.pacalat | Note Added: 82016 | |
2025-02-12 17:37 | tibor.pacalat | Bug heat | 6 => 8 |
2025-02-12 17:37 | tibor.pacalat | Assigned To | => gabrieljenik |
2025-02-12 17:37 | tibor.pacalat | Status | new => assigned |
2025-02-12 18:23 | tassoman | Note Added: 82017 | |
2025-02-12 18:33 | tassoman | Note Added: 82018 | |
2025-02-12 19:27 | DenisChenu | Note Added: 82019 | |
2025-02-17 20:16 | gabrieljenik | Assigned To | gabrieljenik => DenisChenu |
2025-02-17 20:16 | gabrieljenik | Status | assigned => ready for code review |
2025-02-17 20:16 | gabrieljenik | Note Added: 82050 | |
2025-02-17 20:16 | gabrieljenik | Bug heat | 8 => 10 |
2025-02-18 10:06 | DenisChenu | Status | ready for code review => in code review |
2025-02-18 10:06 | DenisChenu | Note Added: 82055 | |
2025-02-18 10:06 | DenisChenu | Assigned To | DenisChenu => gabrieljenik |
2025-02-20 16:57 | gabrieljenik | Note Added: 82103 | |
2025-02-20 17:03 | DenisChenu | Note Added: 82106 | |
2025-02-21 14:15 | gabrieljenik | Note Added: 82109 | |
2025-02-21 14:16 | gabrieljenik | Note Edited: 82109 | |
2025-02-21 14:40 | DenisChenu | Note Added: 82110 | |
2025-02-21 15:03 | gabrieljenik | Note Added: 82111 | |
2025-02-21 15:14 | tassoman | Note Added: 82112 | |
2025-02-21 15:23 | gabrieljenik | Note Added: 82113 | |
2025-02-21 15:41 | tibor.pacalat | Note Added: 82114 | |
2025-02-21 15:46 | gabrieljenik | Note Added: 82116 | |
2025-02-21 17:32 | DenisChenu | Note Added: 82121 | |
2025-02-21 17:34 | DenisChenu | Note Added: 82122 | |
2025-02-21 21:04 | gabrieljenik | Note Added: 82125 |