View Issue Details

Jump to NotesJump to History
This bug affects 1 person(s).
 6
IDProjectCategoryView StatusDate SubmittedLast Update
19822Bug reportsPluginspublic2024-11-03 11:132024-11-08 09:11
Reporterbismark Assigned Totibor.pacalat  
PrioritynoneSeverityminor 
Status in code reviewResolutionopen 
Product Version6.6.x 
Summary19822: Subquestions should be deleted by delete() method
Description

we need to trigger afterModelDelete for answers and subquestions.
In the case of subquestions Question->deleteAllSubquestions() is responsible for deleting subquestions.
deleting Subquestions by Question::model()->deleteAll($criteria) does not trigger afterModelDelete

use $question->delete() instead

Code in application/models/Question.php #505

Steps To Reproduce

Steps to reproduce

(Replace this text with detailed step-by-step instructions on how to reproduce the issue)

Expected result

(Write here what you expected to happen)

Actual result

(Write here what happened instead)

TagsNo tags attached.
Bug heat6
Complete LimeSurvey version number (& build)6.6.6
I will donate to the project if issue is resolvedNo
Browser
Database type & versionmysql
Server OS (if known)
Webserver software & version (if known)
PHP Version8.0

Relationships

Relationship GraphDependency Graph
related to 19821 in code reviewtibor.pacalat Answer should be deleted by delete() method 

Users monitoring this issue

There are no users monitoring this issue.

Activities

bismark

bismark

2024-11-03 11:18

reporter   ~81332

https://github.com/LimeSurvey/LimeSurvey/pull/4013
Mazi

Mazi

2024-11-03 18:14

updater   ~81333

Last edited: 2024-11-03 18:14

@tibor.pacalat, can you please review our fix or ask @DenisChenu or @gabrieljenik to have a look?
DenisChenu

DenisChenu

2024-11-08 09:09

developer   ~81355

@tibor.pacalat : we can not assign to reporter, we can in previous mantis version.

Issue History

Date Modified Username Field Change
2024-11-03 11:13 bismark New Issue
2024-11-03 11:13 bismark Issue generated from: 19821
2024-11-03 11:18 bismark Note Added: 81332
2024-11-03 11:18 bismark Bug heat 0 => 2
2024-11-03 18:13 Mazi Assigned To => tibor.pacalat
2024-11-03 18:13 Mazi Status new => assigned
2024-11-03 18:14 Mazi Note Added: 81333
2024-11-03 18:14 Mazi Bug heat 2 => 4
2024-11-03 18:14 Mazi Note Edited: 81333
2024-11-04 11:28 tibor.pacalat Assigned To tibor.pacalat => DenisChenu
2024-11-04 11:29 tibor.pacalat Status assigned => ready for code review
2024-11-04 11:36 DenisChenu Status ready for code review => in code review
2024-11-08 09:08 DenisChenu Assigned To DenisChenu => tibor.pacalat
2024-11-08 09:09 DenisChenu Note Added: 81355
2024-11-08 09:09 DenisChenu Bug heat 4 => 6
2024-11-08 09:11 Mazi Relationship added related to 19821