I think the release of ZF1 Future has already been made.

Now... If we use this in Vendor we have to delete the current classes definitions being used in the codebase, as to not have duplicates.

If someone is using them in their code, they are probably doing through an include/require just like Lime:
(See attachment)
So if we delete the includes, we can break quite a few things.

The only way for the old code to continue working is if we leave "dummy" files instead of the current ones, including some comments. The classes will be loaded through the autoload related to the vendor. This is not a great solution.

If not, the best would be to do this on DEV so it can be a major release and there we are able to make backward non-compatible changes.

Thoughts?

image.png (25,934 bytes)   

image.png (25,934 bytes)   

Do it in Dev, then.

https://github.com/LimeSurvey/LimeSurvey/pull/4109

@gabrieljenik I merged master into your branch in attempt to fix the failed workflows, but it is still broken (reran the jobs twice). Can you please take a look at it and fix it, even if it is not related with this PR?

Hi @tibor.pacalat.

We fixed couple of issues but got to a point that I prefer to have someone else to look at the issues.

https://github.com/LimeSurvey/LimeSurvey/actions/runs/12430902171/job/34707246728?pr=4109#step:7:71

The errors that appear now are not clear to me why they started appearing.
It doesn't seem to have anything to do with the PR.
But I don't see any other changes that could cause that either.

Maybe Tim or Kevin can review those errors (I see they are the last 2 persons updating one of the impacted files)?