View Issue Details

This bug affects 1 person(s).
 8
IDProjectCategoryView StatusLast Update
19691Bug reportsOtherpublic2024-09-27 17:10
Reportertibor.pacalat Assigned Togabrieljenik  
PrioritynoneSeverityminor 
Status resolvedResolutionfixed 
Product Version6.6.x 
Summary19691: php8.3 compatibility - pchart
Description

Main ticket https://bugs.limesurvey.org/view.php?id=19632

pchart
FILE: /var/www/html/limesurvey/vendor/pchart/pChart.class.php
FILE: /var/www/html/limesurvey/vendor/pchart/pData.class.php

Steps To Reproduce

Steps to reproduce

(Replace this text with detailed step-by-step instructions on how to reproduce the issue)

Expected result

(Write here what you expected to happen)

Actual result

(Write here what happened instead)

TagsNo tags attached.
Bug heat8
Complete LimeSurvey version number (& build)6.6.1+240806
I will donate to the project if issue is resolvedNo
Browser
Database type & version.
Server OS (if known)
Webserver software & version (if known)
PHP Version.

Relationships

child of 19632 assignedgabrieljenik Make Limesurvey compatible with php8.3 

Users monitoring this issue

There are no users monitoring this issue.

Activities

gabrieljenik

gabrieljenik

2024-09-11 16:18

manager   ~80965

Supposedly moving from v1 to v2, the newest one is 2.1.4, from January 2014: pChart 2.0 - a PHP charting library
I understand that the one currently being used, which is in vendor but not with composer, already has custom code.
Corrected the essentials for PHP 8.3 directly on the version available.

https://github.com/LimeSurvey/LimeSurvey/pull/3959

DenisChenu

DenisChenu

2024-09-11 17:03

developer   ~80970

@gabrieljenik : pchart is not deprecated ? We still use it ?

No security issue in pchart ? upset …

DenisChenu

DenisChenu

2024-09-12 11:25

developer   ~80985

Did you test moving to pchart2 ?
Used for pdf statistics ? We use only 2 charts if i don't make error.

Mazi

Mazi

2024-09-12 14:53

updater   ~80989

@DenisChenu, if I remember correctly, years ago it was discussed switching to pchart 2.x But there were issues with the license. It had changed and we not be able to use it for free, see http://www.pchart.net/license

DenisChenu

DenisChenu

2024-09-12 15:09

developer   ~80990

Oh ! Yes right !

And complex …

The pChart library is released under two different licenses. If your application is not a commercial one (eg: you make no money by redistributing it) then the GNU GPLv3 license (General Public License) applies. This license allows you to freely integrate this library in your applications, modify the code and redistribute it in bundled packages as long as your application is also distributed with the GPL license.

tibor.pacalat

tibor.pacalat

2024-09-17 16:27

administrator   ~81037

@gabrieljenik can you please make this PR to master?

gabrieljenik

gabrieljenik

2024-09-19 17:08

manager   ~81057

https://github.com/LimeSurvey/LimeSurvey/pull/3967

DenisChenu

DenisChenu

2024-09-19 17:16

developer   ~81058

round(intval($value) and not intval(round($value))

Or just remove the rouind here ?

Issue History

Date Modified Username Field Change
2024-08-08 14:15 tibor.pacalat New Issue
2024-08-14 20:36 gabrieljenik Assigned To => gabrieljenik
2024-08-14 20:36 gabrieljenik Status new => assigned
2024-09-11 16:18 gabrieljenik Assigned To gabrieljenik => tibor.pacalat
2024-09-11 16:18 gabrieljenik Status assigned => ready for code review
2024-09-11 16:18 gabrieljenik Note Added: 80965
2024-09-11 16:18 gabrieljenik Bug heat 0 => 2
2024-09-11 16:18 gabrieljenik Assigned To tibor.pacalat => DenisChenu
2024-09-11 17:03 DenisChenu Note Added: 80970
2024-09-11 17:03 DenisChenu Bug heat 2 => 4
2024-09-12 11:24 DenisChenu Assigned To DenisChenu => tibor.pacalat
2024-09-12 11:25 DenisChenu Assigned To tibor.pacalat => gabrieljenik
2024-09-12 11:25 DenisChenu Status ready for code review => in code review
2024-09-12 11:25 DenisChenu Note Added: 80985
2024-09-12 11:25 DenisChenu Relationship added child of 19632
2024-09-12 14:53 Mazi Note Added: 80989
2024-09-12 14:53 Mazi Bug heat 4 => 6
2024-09-12 15:09 DenisChenu Note Added: 80990
2024-09-17 16:27 tibor.pacalat Note Added: 81037
2024-09-17 16:27 tibor.pacalat Bug heat 6 => 8
2024-09-19 17:08 gabrieljenik Note Added: 81057
2024-09-19 17:16 DenisChenu Note Added: 81058
2024-09-27 17:10 tibor.pacalat Status in code review => resolved
2024-09-27 17:10 tibor.pacalat Resolution open => fixed