|
|
Wait for https://github.com/LimeSurvey/LimeSurvey/pull/3962/files#diff-dd112c5ab9db770198b42e2ee8da336aa2cc98b42a2da4bad2fa1daf3e30d0cbL476 merged |
|
|
|
https://bugs.limesurvey.org/view.php?id=19685 was merged into master, any progress on this ticket? |
|
|
|
if ($this->engine === self::ENGINE_MCRYPT) {
https://github.com/LimeSurvey/LimeSurvey/blob/a02f1db896f843994e7c1302c75ee4ef2d92b049/vendor/phpseclib/phpseclib/phpseclib/Crypt/Common/SymmetricKey.php#L2351
False positive.
Used only for pte7.X compatibility. |
|
|
|
For a second advice before move to fixed |
|
|
|
if ($this->engine === self::ENGINE_MCRYPT) {
https://github.com/LimeSurvey/LimeSurvey/blob/a02f1db896f843994e7c1302c75ee4ef2d92b049/vendor/phpseclib/phpseclib/phpseclib/Crypt/Common/SymmetricKey.php#L2351
False positive.
Was this in the impact log?
Got lost. L2351 is not the referred if.
Can you expand a bit more? What is to analyze? What is the incompatibility? |
|
|
|
From YOUR file on
@tibor.pacalat use your file to create new related issue.
I think this one are already OK with PHP8.3
FILE: /var/www/html/limesurvey/vendor/phpseclib/phpseclib/phpseclib/Crypt/Common/SymmetricKey.php
--------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 46 ERRORS AFFECTING 26 LINES
--------------------------------------------------------------------------------------------------------------------------------------------------------
1278 | ERROR | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
1278 | ERROR | Function mcrypt_generic_init() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
1311 | ERROR | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
1311 | ERROR | Function mcrypt_generic_init() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
1314 | ERROR | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
1314 | ERROR | Function mcrypt_generic() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
1319 | ERROR | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
1319 | ERROR | Function mcrypt_generic() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
1328 | ERROR | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
1328 | ERROR | Function mcrypt_generic() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
1340 | ERROR | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
1340 | ERROR | Function mcrypt_generic() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
1343 | ERROR | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
1343 | ERROR | Function mcrypt_generic_init() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
1669 | ERROR | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
1669 | ERROR | Function mcrypt_generic_init() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
1697 | ERROR | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
1697 | ERROR | Function mcrypt_generic() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
1702 | ERROR | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
1702 | ERROR | Function mcrypt_generic() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
1713 | ERROR | Function mdecrypt_generic() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
1716 | ERROR | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
1716 | ERROR | Function mcrypt_generic_init() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
2269 | ERROR | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
2269 | ERROR | Function mcrypt_list_algorithms() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
2384 | ERROR | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
2384 | ERROR | Function mcrypt_module_close() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
2385 | ERROR | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
2385 | ERROR | Function mcrypt_module_close() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
2390 | ERROR | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
2390 | ERROR | Function mcrypt_module_close() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
2503 | ERROR | The constant "MCRYPT_MODE_ECB" is deprecated since PHP 7.1 and removed since PHP 7.2
2504 | ERROR | The constant "MCRYPT_MODE_CBC" is deprecated since PHP 7.1 and removed since PHP 7.2
2506 | ERROR | The constant "MCRYPT_MODE_CFB" is deprecated since PHP 7.1 and removed since PHP 7.2
2507 | ERROR | The constant "MCRYPT_MODE_NOFB" is deprecated since PHP 7.1 and removed since PHP 7.2
2508 | ERROR | The constant "MCRYPT_MODE_OFB" is deprecated since PHP 7.1 and removed since PHP 7.2
2509 | ERROR | The constant "MCRYPT_MODE_STREAM" is deprecated since PHP 7.1 and removed since PHP 7.2
2512 | ERROR | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
2512 | ERROR | Function mcrypt_module_open() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
2513 | ERROR | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
2513 | ERROR | Function mcrypt_module_open() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
2519 | ERROR | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
2519 | ERROR | Function mcrypt_module_open() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
2519 | ERROR | The constant "MCRYPT_MODE_ECB" is deprecated since PHP 7.1 and removed since PHP 7.2
2524 | ERROR | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
2524 | ERROR | Function mcrypt_generic_init() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
|
|
|
|
Got lost. L2351 is not the referred if.
What is L2351 ? |
|
|
|
What is L2351 ?
The last part of the link you sent.
https://github.com/LimeSurvey/LimeSurvey/blob/a02f1db896f843994e7c1302c75ee4ef2d92b049/vendor/phpseclib/phpseclib/phpseclib/Crypt/Common/SymmetricKey.php#L2351
|
|
|
|
Ah OK :)
Yes : what i mean : all mcrypt_* are restricted with if ($this->engine === self::ENGINE_MCRYPT) {
Set to engine start are L2351 , orfder of testing are this one
- self::ENGINE_LIBSODIUM,
- self::ENGINE_OPENSSL_GCM,
- self::ENGINE_OPENSSL,
- self::ENGINE_MCRYPT,
- self::ENGINE_EVAL
|
|
|
|
OK, I would just test this then. If any deprecation is found, we will stumble upon it. |
|
|
|
But more : for this one : deprecated since 7.2 then : i really think it's a false positive. |
|
|
|
But more : for this one : deprecated since 7.2 then : i really think it's a false positive.
Ohh you are right |
|
|
|
No change needed |
|
