View Issue Details

This bug affects 1 person(s).
 6
IDProjectCategoryView StatusLast Update
19690Bug reportsOtherpublic2024-10-08 17:03
Reportertibor.pacalat Assigned Togabrieljenik  
PrioritynoneSeverityminor 
Status ready for code reviewResolutionopen 
Product Version6.6.x 
Summary19690: php8.3 compatibility - phpseclib
Description

Main ticket https://bugs.limesurvey.org/view.php?id=19632

phpseclib
FILE: /var/www/html/limesurvey/vendor/phpseclib/phpseclib/phpseclib/Crypt/Common/SymmetricKey.php

Steps To Reproduce

Steps to reproduce

(Replace this text with detailed step-by-step instructions on how to reproduce the issue)

Expected result

(Write here what you expected to happen)

Actual result

(Write here what happened instead)

TagsNo tags attached.
Bug heat6
Complete LimeSurvey version number (& build)6.6.1+240806
I will donate to the project if issue is resolvedNo
Browser
Database type & version.
Server OS (if known)
Webserver software & version (if known)
PHP Version.

Relationships

child of 19632 assignedgabrieljenik Make Limesurvey compatible with php8.3 

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2024-09-20 15:36

developer   ~81069

Wait for https://github.com/LimeSurvey/LimeSurvey/pull/3962/files#diff-dd112c5ab9db770198b42e2ee8da336aa2cc98b42a2da4bad2fa1daf3e30d0cbL476 merged

tibor.pacalat

tibor.pacalat

2024-10-02 16:28

administrator   ~81143

https://bugs.limesurvey.org/view.php?id=19685 was merged into master, any progress on this ticket?

DenisChenu

DenisChenu

2024-10-03 17:39

developer   ~81157

if ($this->engine === self::ENGINE_MCRYPT) {

https://github.com/LimeSurvey/LimeSurvey/blob/a02f1db896f843994e7c1302c75ee4ef2d92b049/vendor/phpseclib/phpseclib/phpseclib/Crypt/Common/SymmetricKey.php#L2351

False positive.
Used only for pte7.X compatibility.

DenisChenu

DenisChenu

2024-10-03 17:39

developer   ~81158

For a second advice before move to fixed

gabrieljenik

gabrieljenik

2024-10-08 14:48

manager   ~81179

if ($this->engine === self::ENGINE_MCRYPT) {

https://github.com/LimeSurvey/LimeSurvey/blob/a02f1db896f843994e7c1302c75ee4ef2d92b049/vendor/phpseclib/phpseclib/phpseclib/Crypt/Common/SymmetricKey.php#L2351

False positive.

Was this in the impact log?

Got lost. L2351 is not the referred if.
Can you expand a bit more? What is to analyze? What is the incompatibility?

DenisChenu

DenisChenu

2024-10-08 16:08

developer   ~81181

From YOUR file on
@tibor.pacalat use your file to create new related issue.

I think this one are already OK with PHP8.3

FILE: /var/www/html/limesurvey/vendor/phpseclib/phpseclib/phpseclib/Crypt/Common/SymmetricKey.php
--------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 46 ERRORS AFFECTING 26 LINES
--------------------------------------------------------------------------------------------------------------------------------------------------------
 1278 | ERROR | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
 1278 | ERROR | Function mcrypt_generic_init() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
 1311 | ERROR | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
 1311 | ERROR | Function mcrypt_generic_init() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
 1314 | ERROR | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
 1314 | ERROR | Function mcrypt_generic() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
 1319 | ERROR | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
 1319 | ERROR | Function mcrypt_generic() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
 1328 | ERROR | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
 1328 | ERROR | Function mcrypt_generic() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
 1340 | ERROR | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
 1340 | ERROR | Function mcrypt_generic() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
 1343 | ERROR | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
 1343 | ERROR | Function mcrypt_generic_init() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
 1669 | ERROR | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
 1669 | ERROR | Function mcrypt_generic_init() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
 1697 | ERROR | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
 1697 | ERROR | Function mcrypt_generic() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
 1702 | ERROR | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
 1702 | ERROR | Function mcrypt_generic() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
 1713 | ERROR | Function mdecrypt_generic() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
 1716 | ERROR | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
 1716 | ERROR | Function mcrypt_generic_init() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
 2269 | ERROR | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
 2269 | ERROR | Function mcrypt_list_algorithms() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
 2384 | ERROR | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
 2384 | ERROR | Function mcrypt_module_close() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
 2385 | ERROR | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
 2385 | ERROR | Function mcrypt_module_close() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
 2390 | ERROR | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
 2390 | ERROR | Function mcrypt_module_close() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
 2503 | ERROR | The constant "MCRYPT_MODE_ECB" is deprecated since PHP 7.1 and removed since PHP 7.2
 2504 | ERROR | The constant "MCRYPT_MODE_CBC" is deprecated since PHP 7.1 and removed since PHP 7.2
 2506 | ERROR | The constant "MCRYPT_MODE_CFB" is deprecated since PHP 7.1 and removed since PHP 7.2
 2507 | ERROR | The constant "MCRYPT_MODE_NOFB" is deprecated since PHP 7.1 and removed since PHP 7.2
 2508 | ERROR | The constant "MCRYPT_MODE_OFB" is deprecated since PHP 7.1 and removed since PHP 7.2
 2509 | ERROR | The constant "MCRYPT_MODE_STREAM" is deprecated since PHP 7.1 and removed since PHP 7.2
 2512 | ERROR | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
 2512 | ERROR | Function mcrypt_module_open() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
 2513 | ERROR | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
 2513 | ERROR | Function mcrypt_module_open() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
 2519 | ERROR | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
 2519 | ERROR | Function mcrypt_module_open() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
 2519 | ERROR | The constant "MCRYPT_MODE_ECB" is deprecated since PHP 7.1 and removed since PHP 7.2
 2524 | ERROR | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
 2524 | ERROR | Function mcrypt_generic_init() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
DenisChenu

DenisChenu

2024-10-08 16:08

developer   ~81182

Got lost. L2351 is not the referred if.

What is L2351 ?

gabrieljenik

gabrieljenik

2024-10-08 16:38

manager   ~81183

What is L2351 ?

The last part of the link you sent.

https://github.com/LimeSurvey/LimeSurvey/blob/a02f1db896f843994e7c1302c75ee4ef2d92b049/vendor/phpseclib/phpseclib/phpseclib/Crypt/Common/SymmetricKey.php#L2351

DenisChenu

DenisChenu

2024-10-08 16:48

developer   ~81184

Ah OK :)

Yes : what i mean : all mcrypt_* are restricted with if ($this->engine === self::ENGINE_MCRYPT) {

Set to engine start are L2351 , orfder of testing are this one

  1. self::ENGINE_LIBSODIUM,
  2. self::ENGINE_OPENSSL_GCM,
  3. self::ENGINE_OPENSSL,
  4. self::ENGINE_MCRYPT,
  5. self::ENGINE_EVAL
gabrieljenik

gabrieljenik

2024-10-08 16:51

manager   ~81185

OK, I would just test this then. If any deprecation is found, we will stumble upon it.

DenisChenu

DenisChenu

2024-10-08 16:52

developer   ~81186

But more : for this one : deprecated since 7.2 then : i really think it's a false positive.

gabrieljenik

gabrieljenik

2024-10-08 17:03

manager   ~81187

But more : for this one : deprecated since 7.2 then : i really think it's a false positive.

Ohh you are right

Issue History

Date Modified Username Field Change
2024-08-08 14:14 tibor.pacalat New Issue
2024-09-11 12:33 tibor.pacalat Assigned To => DenisChenu
2024-09-11 12:33 tibor.pacalat Status new => assigned
2024-09-12 11:23 DenisChenu Relationship added related to 19632
2024-09-12 11:23 DenisChenu Relationship replaced child of 19632
2024-09-20 15:36 DenisChenu Note Added: 81069
2024-09-20 15:36 DenisChenu Bug heat 0 => 2
2024-10-02 16:28 tibor.pacalat Note Added: 81143
2024-10-02 16:28 tibor.pacalat Bug heat 2 => 4
2024-10-03 17:39 DenisChenu Note Added: 81157
2024-10-03 17:39 DenisChenu Assigned To DenisChenu => gabrieljenik
2024-10-03 17:39 DenisChenu Status assigned => ready for code review
2024-10-03 17:39 DenisChenu Note Added: 81158
2024-10-08 14:48 gabrieljenik Note Added: 81179
2024-10-08 14:48 gabrieljenik Bug heat 4 => 6
2024-10-08 16:08 DenisChenu Note Added: 81181
2024-10-08 16:08 DenisChenu Note Added: 81182
2024-10-08 16:38 gabrieljenik Note Added: 81183
2024-10-08 16:48 DenisChenu Note Added: 81184
2024-10-08 16:51 gabrieljenik Note Added: 81185
2024-10-08 16:52 DenisChenu Note Added: 81186
2024-10-08 17:03 gabrieljenik Note Added: 81187