View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
19686 | Bug reports | Other | public | 2024-08-08 14:09 | 2024-09-18 17:04 |
Reporter | tibor.pacalat | Assigned To | tibor.pacalat | ||
Priority | none | Severity | minor | ||
Status | closed | Resolution | won't fix | ||
Product Version | 6.6.x | ||||
Summary | 19686: php8.3 compatibility - robthree/twofactorauth | ||||
Description | Main ticket https://bugs.limesurvey.org/view.php?id=19632 robthree/twofactorauth | ||||
Steps To Reproduce | Steps to reproduce(Replace this text with detailed step-by-step instructions on how to reproduce the issue) Expected result(Write here what you expected to happen) Actual result(Write here what happened instead) | ||||
Tags | No tags attached. | ||||
Bug heat | 6 | ||||
Complete LimeSurvey version number (& build) | 6.6.1+240806 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | |||||
Database type & version | . | ||||
Server OS (if known) | |||||
Webserver software & version (if known) | |||||
PHP Version | . | ||||
child of | 19632 | assigned | gabrieljenik | Make Limesurvey compatible with php8.3 |
See https://github.com/LimeSurvey/LimeSurvey/pull/3960/files#r1756475043 |
|
Fixes to this are already included in 19685. The TwoFactor lib has been updated by its author. But the newest version doesn't support versions older than 8.2. 2) Adapt the plugin so:
3) Use a different TwoFactorAuth lib Either way, we would need to move the chnage we did in 19685 and include them in this PR. I would say go with Alternative #1. (technical solution for this PHP upgrade) |
|
:+1: for me here ! |
|
@c_schmitz what do you think what would be the best solution here? I agree to go with #1 proposed solution, but I am not sure if there are some additional implications for our software if we do it this way that I am not aware of. |
|
Quick update. Nothing is needed here. Although there is impact, those are for deprecations. If that part of the code is not used, shall we still update it? As per the impacts on the library that we commented, they are on the demo folder, so not real impact. Thoughts? |
|
We don't have a test for 2FA ? |
|
Ok, is there some work to be done for this ticket, or we can close it? |
|
I think you can close it. If we found an issue when testing, we will re open it. |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2024-08-08 14:09 | tibor.pacalat | New Issue | |
2024-09-11 12:34 | tibor.pacalat | Assigned To | => gabrieljenik |
2024-09-11 12:34 | tibor.pacalat | Status | new => assigned |
2024-09-11 12:34 | tibor.pacalat | Assigned To | gabrieljenik => DenisChenu |
2024-09-12 11:17 | DenisChenu | Relationship added | child of 19632 |
2024-09-12 11:17 | DenisChenu | Assigned To | DenisChenu => tibor.pacalat |
2024-09-12 11:17 | DenisChenu | Assigned To | tibor.pacalat => gabrieljenik |
2024-09-12 11:18 | DenisChenu | Note Added: 80982 | |
2024-09-12 11:18 | DenisChenu | Bug heat | 0 => 2 |
2024-09-12 21:54 | gabrieljenik | Note Added: 81008 | |
2024-09-12 21:54 | gabrieljenik | Bug heat | 2 => 4 |
2024-09-12 21:54 | gabrieljenik | Assigned To | gabrieljenik => DenisChenu |
2024-09-12 21:54 | gabrieljenik | Status | assigned => ready for code review |
2024-09-12 21:59 | gabrieljenik | Note Edited: 81008 | |
2024-09-12 22:00 | gabrieljenik | Assigned To | DenisChenu => gabrieljenik |
2024-09-12 22:00 | gabrieljenik | Status | ready for code review => assigned |
2024-09-12 22:00 | gabrieljenik | Note Edited: 81008 | |
2024-09-12 22:01 | gabrieljenik | Note Edited: 81008 | |
2024-09-12 22:02 | gabrieljenik | Note Edited: 81008 | |
2024-09-13 08:57 | DenisChenu | Note Added: 81009 | |
2024-09-13 12:04 | tibor.pacalat | Note Added: 81011 | |
2024-09-13 12:04 | tibor.pacalat | Bug heat | 4 => 6 |
2024-09-13 22:37 | gabrieljenik | Note Added: 81026 | |
2024-09-13 22:37 | gabrieljenik | Assigned To | gabrieljenik => tibor.pacalat |
2024-09-13 22:37 | gabrieljenik | Status | assigned => ready for testing |
2024-09-16 08:36 | DenisChenu | Note Added: 81027 | |
2024-09-18 15:39 | tibor.pacalat | Note Added: 81043 | |
2024-09-18 15:55 | gabrieljenik | Note Added: 81046 | |
2024-09-18 17:04 | tibor.pacalat | Status | ready for testing => closed |
2024-09-18 17:04 | tibor.pacalat | Resolution | open => won't fix |