This affects all global settings that are On/Off and cast to Boolean:
createsample
rpc_publish_api
add_access_control_header

Problem is as follows:
On => "1", Off => "0"
value is cast to Boolean when storing the setting
On => true, Off => false
db field is text and php converts boolean to string, true => "1" and false => ""
so, true gets stored in db as "1", false gets stored in db as an empty string, but the code expects to load a "1" or a "0"

other global settings that appear as On/Off , but are unaffected fall under the following cases:

• values changed to Y/N: "1" => "Y", "0" => "N" (already strings)
• values cast to integer: "1" => 1, "0" => 0 (which end up as "1" and "0" when cast back to strings)
• values used directly: "1", "0" (already strings)

So there are 4 different ways of handling a checkbox present

could just remove cast to boolean if there are no objections

https://github.com/LimeSurvey/LimeSurvey/pull/3765

Needed fort 5 https://github.com/LimeSurvey/LimeSurvey/blob/07e3666d4114709dd7570dbff8e990823a82a4d1/application/controllers/admin/globalsettings.php#L391 ?

Seems here since years, why it appear now ?

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=36146

@mfavetti can you port this to 5.x as well?

@tibor.pacalat

no need, doesn't affect 5.x

@DenisChenu

i did not look into this too deeply, but visually, 5.x used some sort of on/off slider and 6.x uses a button group

must be some difference in implementation between the two types of inputs

:+1: thanks

Fixed in Release 6.4.11+240304