View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 12
IDProjectCategoryView StatusDate SubmittedLast Update
18832Bug reportsSurvey participants (Tokens)public2023-05-19 16:362023-10-13 15:26
ReporterMazi Assigned Toollehar  
PrioritynoneSeverityblock 
Status resolvedResolutionfixed 
Product Version5.6.x 
Summary18832: Participants can't re-enter a submitted survey if setting is using "inherit" at participant settings
Description

If I allow participants to re-enter an already submitted survey, this only works fine if the participant setting is explicitly set. When defining this at the global survey settings and setting the local setting at survey level to "inherit", this is not taken into account.

Steps To Reproduce

Steps to reproduce

Create a closed survey with a single test token.
At the global survey settings set the surveys to

  • be non anonymous
  • allow token persistance
  • allow to re-enter a submitted survey to edit submitted data

At survey level set the same settings to "inherit".

Start the survey with your token and submit the data set.
At the participant overview you will NOT see the icon to start the survey again.

Now go to the local survey's participant settings and explicitly set the survey to

  • be non anonymous
  • allow token persistance
  • allow to re-enter a submitted survey to edit submitted data

Go back to the participant overview -> The icon to take the survey now shows up.

Expected result

Be able to re-enter a survey if the required settings are defined like that at the global survey settings.

Actual result

Icon to re-enter the survey is not shown.

TagsNo tags attached.
Bug heat12
Complete LimeSurvey version number (& build)Version 5.6.21+230518
I will donate to the project if issue is resolvedNo
BrowserChrome
Database type & versionMySQL
Server OS (if known)
Webserver software & version (if known)
PHP Version8.1

Users monitoring this issue

There are no users monitoring this issue.

Activities

Mazi

Mazi

2023-05-25 16:48

updater   ~75228

@ollehar, can we assign this one? It is pretty anoying and buggy for a new project we are starting soon.
Mazi

Mazi

2023-06-23 11:56

updater   ~75831

@ollehar, any feedback?!
gabrieljenik

gabrieljenik

2023-07-13 18:14

manager   ~76080

v5: https://github.com/LimeSurvey/LimeSurvey/pull/3285
gabrieljenik

gabrieljenik

2023-07-26 14:39

manager   ~76272

We have positively tested this.
@mazi Can you help test as well as this is kind of sensitive?
gabrieljenik

gabrieljenik

2023-07-26 14:39

manager   ~76273

@tibor.pacalat as well :)
Mazi

Mazi

2023-07-26 15:45

updater   ~76274

@gabrieljenik, I am sorry but I am on vacation the next 10 days.
guest

guest

2023-07-26 15:55

viewer   ~76275

Fix committed to 5.x branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=35267
tibor.pacalat

tibor.pacalat

2023-07-26 15:56

administrator   ~76276

I am able to see the icon, re-enter the survey with the existing token and edit the answers with the settings as they are in the description.

Tested and merged.
LimeBot

LimeBot

2023-07-31 12:32

administrator   ~76361

Fixed in Release 5.6.32+230731
gabrieljenik

gabrieljenik

2023-07-31 13:42

manager   ~76366

Master PR: https://github.com/LimeSurvey/LimeSurvey/pull/3312
gabrieljenik

gabrieljenik

2023-08-02 15:19

manager   ~76400

Tests for v5: https://github.com/LimeSurvey/LimeSurvey/pull/3324
For master they were included in the Master PR
gabrieljenik

gabrieljenik

2023-08-08 14:23

manager   ~76490

Master tested OK.
As this is quite sensitive matter, @tibor.pacalat can I ask you to give a try yourself as well?
tibor.pacalat

tibor.pacalat

2023-08-08 19:10

administrator   ~76494

I am getting error when I try to save survey settings:
POST http://ls-ce/index.php?r=admin/database/index/updatesurveylocalesettings 500 (Internal Server Error)

I'll talk to Kevin, could be my local setup.
gabrieljenik

gabrieljenik

2023-08-08 23:55

manager   ~76497

Make debug=2 and paste the stacktrace please.
tibor.pacalat

tibor.pacalat

2023-08-09 10:14

administrator   ~76498

https://github.com/LimeSurvey/LimeSurvey/pull/3324 needs code review.
The issue above was resolved when I merged master into your branch (master fix).
Tested it and it works as expected now.
guest

guest

2023-08-09 10:27

viewer   ~76499

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=35323
guest

guest

2023-08-09 10:27

viewer   ~76500

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=35322
gabrieljenik

gabrieljenik

2023-08-09 13:57

manager   ~76504

https://github.com/LimeSurvey/LimeSurvey/pull/3324 needs code review.

OK, I have asked to @Ollehar now
ollehar

ollehar

2023-08-09 14:19

administrator   ~76510

Hm why do two PRs if you can cherry-pick from master to 5.x branch? I was hoping to avoid the administration. :d
gabrieljenik

gabrieljenik

2023-08-09 14:42

manager   ~76515

I don't know. I was just following the same principles as with everything else we push
ollehar

ollehar

2023-08-09 15:03

administrator   ~76516

Oh yeah, you're right. I was still stuck in the other discussion regarding cherry-pick. All good.
LimeBot

LimeBot

2023-08-14 09:30

administrator   ~76557

Fixed in Release 6.2.2+230814
gabrieljenik

gabrieljenik

2023-08-14 14:11

manager   ~76565

This is the current status (https://bugs.limesurvey.org/view.php?id=18832#c76498):

https://github.com/LimeSurvey/LimeSurvey/pull/3324 needs code review.
Tested it and it works as expected now.

Related Changesets

LimeSurvey: 5.x 3744cff3

2023-07-26 15:55:04

Gabriel Jenik


Committer: GitHub Details Diff 		Fixed issue 18832: Participants can't re-enter a submitted survey if setting is using "inherit" at participant settings (#3285)

Co-authored-by: lapiudevgit <devgit@lapiu.biz>		 Affected Issues
18832
mod - application/helpers/expressions/em_manager_helper.php Diff File
mod - application/models/TokenDynamic.php Diff File
mod - tests/functional/backend/NoGreenBarTest.php Diff File

LimeSurvey: master 9275126f

2023-08-09 10:27:35

Gabriel Jenik


Committer: GitHub Details Diff 		Fixed issue 18832: Participants can't re-enter a submitted survey if setting is using "inherit" at participant settings (#3312)

Co-authored-by: lapiudevgit <devgit@lapiu.biz>
Co-authored-by: tiborpacalat <129872163+tiborpacalat@users.noreply.github.com>		 Affected Issues
18832
mod - application/helpers/expressions/em_manager_helper.php Diff File
mod - application/models/TokenDynamic.php Diff File
mod - tests/functional/backend/NoGreenBarTest.php Diff File
add - tests/unit/models/TokenDynamicTest.php Diff File

LimeSurvey: master 9275126f

2023-08-09 10:27:35

Gabriel Jenik


Committer: GitHub Details Diff 		Fixed issue 18832: Participants can't re-enter a submitted survey if setting is using "inherit" at participant settings (#3312)

Co-authored-by: lapiudevgit <devgit@lapiu.biz>
Co-authored-by: tiborpacalat <129872163+tiborpacalat@users.noreply.github.com>		 Affected Issues
18832
mod - application/helpers/expressions/em_manager_helper.php Diff File
mod - application/models/TokenDynamic.php Diff File
mod - tests/functional/backend/NoGreenBarTest.php Diff File
add - tests/unit/models/TokenDynamicTest.php Diff File

Issue History

Date Modified Username Field Change
2023-05-19 16:36 Mazi New Issue
2023-05-25 16:48 Mazi Note Added: 75228
2023-05-25 16:48 Mazi Bug heat 0 => 2
2023-06-23 11:56 Mazi Note Added: 75831
2023-07-07 22:12 gabrieljenik Assigned To => gabrieljenik
2023-07-07 22:12 gabrieljenik Status new => assigned
2023-07-13 18:14 gabrieljenik Assigned To gabrieljenik => DenisChenu
2023-07-13 18:14 gabrieljenik Status assigned => ready for code review
2023-07-13 18:14 gabrieljenik Note Added: 76080
2023-07-13 18:14 gabrieljenik Bug heat 2 => 4
2023-07-13 18:33 DenisChenu Assigned To DenisChenu =>
2023-07-13 18:33 DenisChenu Status ready for code review => ready for testing
2023-07-26 14:39 gabrieljenik Assigned To => gabrieljenik
2023-07-26 14:39 gabrieljenik Status ready for testing => in testing
2023-07-26 14:39 gabrieljenik Note Added: 76272
2023-07-26 14:39 gabrieljenik Assigned To gabrieljenik => tibor.pacalat
2023-07-26 14:39 gabrieljenik Note Added: 76273
2023-07-26 15:45 Mazi Note Added: 76274
2023-07-26 15:55 Changeset attached => LimeSurvey 5.x 3744cff3
2023-07-26 15:55 guest Note Added: 76275
2023-07-26 15:55 guest Bug heat 4 => 6
2023-07-26 15:56 tibor.pacalat Status in testing => resolved
2023-07-26 15:56 tibor.pacalat Resolution open => fixed
2023-07-26 15:56 tibor.pacalat Note Added: 76276
2023-07-26 15:56 tibor.pacalat Bug heat 6 => 8
2023-07-27 19:14 gabrieljenik Issue cloned: 18993
2023-07-31 12:32 LimeBot Note Added: 76361
2023-07-31 12:32 LimeBot Status resolved => closed
2023-07-31 12:32 LimeBot Bug heat 8 => 10
2023-07-31 13:42 gabrieljenik Assigned To tibor.pacalat => gabrieljenik
2023-07-31 13:42 gabrieljenik Status closed => ready for testing
2023-07-31 13:42 gabrieljenik Note Added: 76366
2023-08-02 15:19 gabrieljenik Note Added: 76400
2023-08-08 14:23 gabrieljenik Note Added: 76490
2023-08-08 14:23 gabrieljenik Assigned To gabrieljenik => tibor.pacalat
2023-08-08 14:23 gabrieljenik Status ready for testing => in testing
2023-08-08 19:10 tibor.pacalat Note Added: 76494
2023-08-08 23:55 gabrieljenik Note Added: 76497
2023-08-09 10:14 tibor.pacalat Note Added: 76498
2023-08-09 10:27 Changeset attached => LimeSurvey master 9275126f
2023-08-09 10:27 Changeset attached => LimeSurvey master 9275126f
2023-08-09 10:27 guest Note Added: 76499
2023-08-09 10:27 guest Note Added: 76500
2023-08-09 13:57 gabrieljenik Note Added: 76504
2023-08-09 14:19 ollehar Note Added: 76510
2023-08-09 14:19 ollehar Bug heat 10 => 12
2023-08-09 14:42 gabrieljenik Note Added: 76515
2023-08-09 15:03 ollehar Note Added: 76516
2023-08-14 09:30 LimeBot Note Added: 76557
2023-08-14 09:30 LimeBot Status in testing => closed
2023-08-14 14:11 gabrieljenik Assigned To tibor.pacalat => ollehar
2023-08-14 14:11 gabrieljenik Status closed => ready for code review
2023-08-14 14:11 gabrieljenik Note Added: 76565
2023-10-13 15:26 tibor.pacalat Status ready for code review => resolved