View Issue Details

This bug affects 1 person(s).
 14
IDProjectCategoryView StatusLast Update
18593Bug reportsQuestion themepublic2023-09-18 09:10
Reportergabrieljenik Assigned Totibor.pacalat  
PrioritynormalSeveritycrash 
Status closedResolutionfixed 
Product Version5.5.x 
Summary18593: Float attributes are not supported anymore
Description

I ported a question theme to LS5.
Float question attributes failed to load on the question editor.

{success: false, message: "AdvancedSettingWidget cannot find the view "float".",…}
error
: 
{code: 500, type: "CException", errorCode: 0,…}
code
: 
500
errorCode
: 
0
file
: 
"/var/app/current/third_party/yiisoft/yii/framework/web/widgets/CWidget.php"
line
: 
246
message
: 
"AdvancedSettingWidget cannot find the view \"float\"."
trace
: 
"#0 /var/app/current/application/extensions/AdvancedSettingWidget/AdvancedSettingWidget.php(55): CWidget->render('float', Array, true)\n#1 /var/app/current/third_party/yiisoft/yii/framework/web/CBaseController.php(182): AdvancedSettingWidget->run()\n#2 /var/app/current/application/views/questionAdministration/advancedSettings.php(14): CBaseController->widget('ext.AdvancedSet...', Array)\n#3 /var/app/current/third_party/yiisoft/yii/framework/web/CBaseController.php(126): require('/var/app/curren...')\n#4 /var/app/current/third_party/yiisoft/yii/framework/web/CBaseController.php(95): CBaseController->renderInternal('/var/app/curren...', Array, true)\n#5 /var/app/current/third_party/yiisoft/yii/framework/web/CController.php(872): CBaseController->renderFile('/var/app/curren...', Array, true)\n#6 /var/app/current/application/controllers/QuestionAdministrationController.php(1754): CController->renderPartial('advancedSetting...', Array)\n#7 [internal function]: QuestionAdministrationController->actionGetAdvancedSettingsHTML(454239, 'P', 'MultipleChoiceW...', '0')\n#8 /var/app/current/third_party/yiisoft/yii/framework/web/actions/CAction.php(115): ReflectionMethod->invokeArgs(Object(QuestionAdministrationController), Array)\n#9 /var/app/current/third_party/yiisoft/yii/framework/web/actions/CInlineAction.php(47): CAction->runWithParamsInternal(Object(QuestionAdministrationController), Object(ReflectionMethod), Array)\n#10 /var/app/current/third_party/yiisoft/yii/framework/web/CController.php(308): CInlineAction->runWithParams(Array)\n#11 /var/app/current/third_party/yiisoft/yii/framework/web/CController.php(286): CController->runAction(Object(CInlineAction))\n#12 /var/app/current/third_party/yiisoft/yii/framework/web/CController.php(265): CController->runActionWithFilters(Object(CInlineAction), Array)\n#13 /var/app/current/application/controllers/LSBaseController.php(160): CController->run('getAdvancedSett...')\n#14 /var/app/current/third_party/yiisoft/yii/framework/web/CWebApplication.php(282): LSBaseController->run('getAdvancedSett...')\n#15 /var/app/current/third_party/yiisoft/yii/framework/web/CWebApplication.php(141): CWebApplication->runController('questionAdminis...')\n#16 /var/app/current/third_party/yiisoft/yii/framework/base/CApplication.php(185): CWebApplication->processRequest()\n#17 /var/app/current/index.php(192): CApplication->run()\n#18 {main}"
traces
: 
[{file: "/var/app/current/application/extensions/AdvancedSettingWidget/AdvancedSettingWidget.php",…},…]
0
: 
{file: "/var/app/current/application/extensions/AdvancedSettingWidget/AdvancedSettingWidget.php",…}
1
: 
{file: "/var/app/current/third_party/yiisoft/yii/framework/web/CBaseController.php", line: 182,…}
2
: 
{file: "/var/app/current/application/views/questionAdministration/advancedSettings.php", line: 14,…}
3
: 
{file: "/var/app/current/third_party/yiisoft/yii/framework/web/CBaseController.php", line: 126,…}
4
: 
{file: "/var/app/current/third_party/yiisoft/yii/framework/web/CBaseController.php", line: 95,…}
5
: 
{file: "/var/app/current/third_party/yiisoft/yii/framework/web/CController.php", line: 872,…}
6
: 
{file: "/var/app/current/application/controllers/QuestionAdministrationController.php", line: 1754,…}
7
: 
{function: "actionGetAdvancedSettingsHTML", class: "QuestionAdministrationController", type: "->",…}
8
: 
{file: "/var/app/current/third_party/yiisoft/yii/framework/web/actions/CAction.php", line: 115,…}
9
: 
{file: "/var/app/current/third_party/yiisoft/yii/framework/web/actions/CInlineAction.php", line: 47,…}
10
: 
{file: "/var/app/current/third_party/yiisoft/yii/framework/web/CController.php", line: 308,…}
11
: 
{file: "/var/app/current/third_party/yiisoft/yii/framework/web/CController.php", line: 286,…}
12
: 
{file: "/var/app/current/third_party/yiisoft/yii/framework/web/CController.php", line: 265,…}
13
: 
{file: "/var/app/current/application/controllers/LSBaseController.php", line: 160, function: "run",…}
14
: 
{file: "/var/app/current/third_party/yiisoft/yii/framework/web/CWebApplication.php", line: 282,…}
15
: 
{file: "/var/app/current/third_party/yiisoft/yii/framework/web/CWebApplication.php", line: 141,…}
16
: 
{file: "/var/app/current/third_party/yiisoft/yii/framework/base/CApplication.php", line: 185,…}
17
: 
{file: "/var/app/current/index.php", line: 192, function: "run", class: "CApplication", type: "->",…}
type
: 
"CException"
message
: 
"AdvancedSettingWidget cannot find the view \"float\"."
success
: 
false
Steps To Reproduce

Steps to reproduce

Create a theme in LS3 with a float question attribute

Expected result

Be ok to use it in LS5

Actual result

Loading the question on question editor fails

TagsNo tags attached.
Bug heat14
Complete LimeSurvey version number (& build)5.x
I will donate to the project if issue is resolvedNo
Browser
Database type & versionMysql
Server OS (if known)
Webserver software & version (if known)
PHP Version7

Users monitoring this issue

duvemyster

Activities

DenisChenu

DenisChenu

2023-01-12 18:27

developer   ~73452

What is a «float question attribute» ?

Feature request : https://manual.limesurvey.org/NewQuestionAttributes#Input_type ?

gabrieljenik

gabrieljenik

2023-01-12 20:02

manager   ~73454

What is a «float question attribute» ?

Similar to an integer question attribute.

Feature request : https://manual.limesurvey.org/NewQuestionAttributes#Input_type ?

It was available in LS3.

DenisChenu

DenisChenu

2023-01-13 09:53

developer   ~73457

It was available in LS3.

Seems never used by core attribute … API or not ? @ollehar ?

ollehar

ollehar

2023-01-13 12:13

administrator   ~73458

If it worked in LS3 there's no reason it shouldn't work in LS5, right?

gabrieljenik

gabrieljenik

2023-01-13 14:34

manager   ~73461

The float view on the advanced widget was included on LS3 on this commit.
https://github.com/LimeSurvey/LimeSurvey/commit/b93de5ab6d5afa3804a5bd64ddf5025b28a56beb

Somehow that view is not available on LS5.
Maybe needed as to not get the same bug again in LS5?

DenisChenu

DenisChenu

2023-01-13 14:55

developer   ~73462

Updated manual

DenisChenu

DenisChenu

2023-01-13 14:58

developer   ~73463

I add float type for min/max, but if i don't make error : there are an issue with min/max currently

gabrieljenik

gabrieljenik

2023-01-16 17:54

manager   ~73480

Sorry, got lost.
Is this bug OK to be confirmed?

ollehar

ollehar

2023-01-27 13:01

administrator   ~73591

Seems never used by core attribute … API or not ? @ollehar ?

I believe this is a regression and that it should be added to LS5, yes.

DenisChenu

DenisChenu

2023-01-28 10:05

developer   ~73595

If it worked in LS3 there's no reason it shouldn't work in LS5, right?

:)

gabrieljenik

gabrieljenik

2023-06-08 16:33

manager   ~75480

PR for v5: https://github.com/LimeSurvey/LimeSurvey/pull/3202
When merged, will do master

tibor.pacalat

tibor.pacalat

2023-06-14 16:12

administrator   ~75633

I need a custom question theme that uses a float question attribute to test this.

tibor.pacalat

tibor.pacalat

2023-08-09 16:40

administrator   ~76525

@gabrieljenik I need a custom question theme that uses a float question attribute to test this.

gabrieljenik

gabrieljenik

2023-08-30 19:56

manager   ~76796

Master: https://github.com/LimeSurvey/LimeSurvey/pull/3411

gabrieljenik

gabrieljenik

2023-08-30 19:57

manager   ~76797

LSS and QuestionTheme for testing
@tibor.pacalat

float.zip (4,614 bytes)
gabrieljenik

gabrieljenik

2023-08-30 19:57

manager   ~76798

We have already tested it on our end

image.png (8,634 bytes)   
image.png (8,634 bytes)   
image-2.png (14,274 bytes)   
image-2.png (14,274 bytes)   
guest

guest

2023-09-07 13:41

viewer   ~76895

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=35442

guest

guest

2023-09-07 13:50

viewer   ~76896

Fix committed to 5.x branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=35443

LimeBot

LimeBot

2023-09-18 09:10

administrator   ~77103

Fixed in Release 6.2.7+230918

Related Changesets

LimeSurvey: master 1a5abb13

2023-09-07 13:41:36

Gabriel Jenik


Committer: GitHub Details Diff
Fixed issue 18593: Float attributes are not supported anymore (#3411)

Co-authored-by: lapiudevgit <devgit@lapiu.biz>
Affected Issues
18593
mod - application/extensions/AdvancedSettingWidget/AdvancedSettingWidget.php Diff File
add - application/extensions/AdvancedSettingWidget/views/float.php Diff File

LimeSurvey: 5.x 15257031

2023-09-07 13:41:59

Gabriel Jenik


Committer: GitHub Details Diff
Fixed issue 18593: Float attributes are not supported anymore (#3202)

Co-authored-by: lapiudevgit <devgit@lapiu.biz>
Affected Issues
18593
mod - application/extensions/AdvancedSettingWidget/AdvancedSettingWidget.php Diff File
add - application/extensions/AdvancedSettingWidget/views/float.php Diff File

Issue History

Date Modified Username Field Change
2023-01-12 18:25 gabrieljenik New Issue
2023-01-12 18:27 DenisChenu Note Added: 73452
2023-01-12 18:27 DenisChenu Bug heat 0 => 2
2023-01-12 20:02 gabrieljenik Note Added: 73454
2023-01-12 20:02 gabrieljenik Bug heat 2 => 4
2023-01-13 09:53 DenisChenu Note Added: 73457
2023-01-13 12:13 ollehar Note Added: 73458
2023-01-13 12:13 ollehar Bug heat 4 => 6
2023-01-13 12:13 ollehar Priority none => normal
2023-01-13 14:34 gabrieljenik Note Added: 73461
2023-01-13 14:55 DenisChenu Note Added: 73462
2023-01-13 14:58 DenisChenu Note Added: 73463
2023-01-16 17:54 gabrieljenik Note Added: 73480
2023-01-16 17:54 gabrieljenik Status new => acknowledged
2023-01-27 13:01 ollehar Note Added: 73591
2023-01-27 13:31 gabrieljenik Assigned To => gabrieljenik
2023-01-27 13:31 gabrieljenik Status acknowledged => confirmed
2023-01-28 10:05 DenisChenu Note Added: 73595
2023-06-08 16:33 gabrieljenik Note Added: 75480
2023-06-08 16:34 gabrieljenik Assigned To gabrieljenik => DenisChenu
2023-06-08 16:34 gabrieljenik Status confirmed => ready for code review
2023-06-08 18:15 DenisChenu Assigned To DenisChenu =>
2023-06-08 18:15 DenisChenu Status ready for code review => ready for testing
2023-06-14 16:12 tibor.pacalat Note Added: 75633
2023-06-14 16:12 tibor.pacalat Bug heat 6 => 8
2023-08-09 16:40 tibor.pacalat Note Added: 76525
2023-08-15 21:15 duvemyster Issue Monitored: duvemyster
2023-08-15 21:15 duvemyster Bug heat 8 => 10
2023-08-30 19:56 gabrieljenik Note Added: 76796
2023-08-30 19:57 gabrieljenik Note Added: 76797
2023-08-30 19:57 gabrieljenik File Added: surveys_archive (7).zip
2023-08-30 19:57 gabrieljenik File Added: float.zip
2023-08-30 19:57 gabrieljenik Note Added: 76798
2023-08-30 19:57 gabrieljenik File Added: image.png
2023-08-30 19:57 gabrieljenik File Added: image-2.png
2023-08-30 19:58 gabrieljenik Assigned To => tibor.pacalat
2023-09-07 13:41 Changeset attached => LimeSurvey master 1a5abb13
2023-09-07 13:41 guest Note Added: 76895
2023-09-07 13:41 guest Bug heat 10 => 12
2023-09-07 13:50 Changeset attached => LimeSurvey 5.x 15257031
2023-09-07 13:50 guest Note Added: 76896
2023-09-13 15:01 tibor.pacalat Status ready for testing => resolved
2023-09-13 15:01 tibor.pacalat Resolution open => fixed
2023-09-18 09:10 LimeBot Note Added: 77103
2023-09-18 09:10 LimeBot Status resolved => closed
2023-09-18 09:10 LimeBot Bug heat 12 => 14