View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 18593 | Bug reports | Question theme | public | 2023-01-12 18:25 | 2023-09-18 09:10 |
| Reporter | gabrieljenik | Assigned To | tibor.pacalat | ||
| Priority | normal | Severity | crash | ||
| Status | closed | Resolution | fixed | ||
| Product Version | 5.5.x | ||||
| Summary | 18593: Float attributes are not supported anymore | ||||
| Description | I ported a question theme to LS5. | ||||
| Steps To Reproduce | Steps to reproduceCreate a theme in LS3 with a float question attribute Expected resultBe ok to use it in LS5 Actual resultLoading the question on question editor fails | ||||
| Tags | No tags attached. | ||||
| Bug heat | 14 | ||||
| Complete LimeSurvey version number (& build) | 5.x | ||||
| I will donate to the project if issue is resolved | No | ||||
| Browser | |||||
| Database type & version | Mysql | ||||
| Server OS (if known) | |||||
| Webserver software & version (if known) | |||||
| PHP Version | 7 | ||||
|
What is a «float question attribute» ? Feature request : https://manual.limesurvey.org/NewQuestionAttributes#Input_type ? |
|
Similar to an integer question attribute.
It was available in LS3. |
|
Seems never used by core attribute … API or not ? @ollehar ? |
|
|
If it worked in LS3 there's no reason it shouldn't work in LS5, right? |
|
|
The float view on the advanced widget was included on LS3 on this commit. Somehow that view is not available on LS5. |
|
|
Updated manual |
|
|
I add float type for min/max, but if i don't make error : there are an issue with min/max currently |
|
|
Sorry, got lost. |
|
I believe this is a regression and that it should be added to LS5, yes. |
|
:) |
|
|
PR for v5: https://github.com/LimeSurvey/LimeSurvey/pull/3202 |
|
|
I need a custom question theme that uses a float question attribute to test this. |
|
|
@gabrieljenik I need a custom question theme that uses a float question attribute to test this. |
|
|
LSS and QuestionTheme for testing |
|
|
We have already tested it on our end |
|
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=35442 |
|
|
Fix committed to 5.x branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=35443 |
|
|
Fixed in Release 6.2.7+230918 |
|
|
LimeSurvey: master 1a5abb13 2023-09-07 15:41 Gabriel Jenik Committer: GitHub Details Diff |
Fixed issue 18593: Float attributes are not supported anymore (#3411) Co-authored-by: lapiudevgit <devgit@lapiu.biz> |
Affected Issues 18593 |
|
| mod - application/extensions/AdvancedSettingWidget/AdvancedSettingWidget.php | Diff File | ||
| add - application/extensions/AdvancedSettingWidget/views/float.php | Diff File | ||
|
LimeSurvey: 5.x 15257031 2023-09-07 15:41 Gabriel Jenik Committer: GitHub Details Diff |
Fixed issue 18593: Float attributes are not supported anymore (#3202) Co-authored-by: lapiudevgit <devgit@lapiu.biz> |
Affected Issues 18593 |
|
| mod - application/extensions/AdvancedSettingWidget/AdvancedSettingWidget.php | Diff File | ||
| add - application/extensions/AdvancedSettingWidget/views/float.php | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2023-01-12 18:25 | gabrieljenik | New Issue | |
| 2023-01-12 18:27 | DenisChenu | Note Added: 73452 | |
| 2023-01-12 18:27 | DenisChenu | Bug heat | 0 => 2 |
| 2023-01-12 20:02 | gabrieljenik | Note Added: 73454 | |
| 2023-01-12 20:02 | gabrieljenik | Bug heat | 2 => 4 |
| 2023-01-13 09:53 | DenisChenu | Note Added: 73457 | |
| 2023-01-13 12:13 | ollehar | Note Added: 73458 | |
| 2023-01-13 12:13 | ollehar | Bug heat | 4 => 6 |
| 2023-01-13 12:13 | ollehar | Priority | none => normal |
| 2023-01-13 14:34 | gabrieljenik | Note Added: 73461 | |
| 2023-01-13 14:55 | DenisChenu | Note Added: 73462 | |
| 2023-01-13 14:58 | DenisChenu | Note Added: 73463 | |
| 2023-01-16 17:54 | gabrieljenik | Note Added: 73480 | |
| 2023-01-16 17:54 | gabrieljenik | Status | new => acknowledged |
| 2023-01-27 13:01 | ollehar | Note Added: 73591 | |
| 2023-01-27 13:31 | gabrieljenik | Assigned To | => gabrieljenik |
| 2023-01-27 13:31 | gabrieljenik | Status | acknowledged => confirmed |
| 2023-01-28 10:05 | DenisChenu | Note Added: 73595 | |
| 2023-06-08 16:33 | gabrieljenik | Note Added: 75480 | |
| 2023-06-08 16:34 | gabrieljenik | Assigned To | gabrieljenik => DenisChenu |
| 2023-06-08 16:34 | gabrieljenik | Status | confirmed => ready for code review |
| 2023-06-08 18:15 | DenisChenu | Assigned To | DenisChenu => |
| 2023-06-08 18:15 | DenisChenu | Status | ready for code review => ready for testing |
| 2023-06-14 16:12 | tibor.pacalat | Note Added: 75633 | |
| 2023-06-14 16:12 | tibor.pacalat | Bug heat | 6 => 8 |
| 2023-08-09 16:40 | tibor.pacalat | Note Added: 76525 | |
| 2023-08-15 21:15 | duvemyster | Issue Monitored: duvemyster | |
| 2023-08-15 21:15 | duvemyster | Bug heat | 8 => 10 |
| 2023-08-30 19:56 | gabrieljenik | Note Added: 76796 | |
| 2023-08-30 19:57 | gabrieljenik | Note Added: 76797 | |
| 2023-08-30 19:57 | gabrieljenik | File Added: surveys_archive (7).zip | |
| 2023-08-30 19:57 | gabrieljenik | File Added: float.zip | |
| 2023-08-30 19:57 | gabrieljenik | Note Added: 76798 | |
| 2023-08-30 19:57 | gabrieljenik | File Added: image.png | |
| 2023-08-30 19:57 | gabrieljenik | File Added: image-2.png | |
| 2023-08-30 19:58 | gabrieljenik | Assigned To | => tibor.pacalat |
| 2023-09-07 13:41 | Changeset attached | => LimeSurvey master 1a5abb13 | |
| 2023-09-07 13:41 | guest | Note Added: 76895 | |
| 2023-09-07 13:41 | guest | Bug heat | 10 => 12 |
| 2023-09-07 13:50 | Changeset attached | => LimeSurvey 5.x 15257031 | |
| 2023-09-07 13:50 | guest | Note Added: 76896 | |
| 2023-09-13 15:01 | tibor.pacalat | Status | ready for testing => resolved |
| 2023-09-13 15:01 | tibor.pacalat | Resolution | open => fixed |
| 2023-09-18 09:10 | LimeBot | Note Added: 77103 | |
| 2023-09-18 09:10 | LimeBot | Status | resolved => closed |
| 2023-09-18 09:10 | LimeBot | Bug heat | 12 => 14 |