View Issue Details

This bug affects 1 person(s).
 8
IDProjectCategoryView StatusLast Update
18503Bug reportsLabel setspublic2022-12-21 14:10
ReporterMazi Assigned Togabrieljenik  
PrioritynormalSeverityminor 
Status ready for mergeResolutionfixed 
Product Version5.4.x 
Summary18503: Search for label sets broken at LS 5.4.11
Description

When adding a label set e.g. at the "edit responses" screen, the loaded label sets can not be searched. The search field seems to be disabled, you can not click into it, see screenshot.

Steps To Reproduce

Steps to reproduce

Create a single choice question and go to "edit answers". The select to load from a label set.

Expected result

See list of label sets with search field on top.

Actual result

Search field is present but you can not click into it and thus can't use it.

TagsNo tags attached.
Bug heat8
Complete LimeSurvey version number (& build)Version 5.4.11+221114
I will donate to the project if issue is resolvedNo
Browser
Database type & versionMariaDB 10.1.48
Server OS (if known)
Webserver software & version (if known)
PHP Version8.1.12

Users monitoring this issue

User List There are no users monitoring this issue.

Activities

Mazi

Mazi

2022-11-22 13:36

updater  

image.png (16,047 bytes)   
image.png (16,047 bytes)   
ollehar

ollehar

2022-11-28 12:34

administrator   ~72914

Fix needs a unit test.

Mazi

Mazi

2022-11-28 12:49

updater   ~72915

Why?
For a feature that had been working fine before?!

ollehar

ollehar

2022-11-29 09:56

administrator   ~72927

Last edited: 2022-11-29 09:57

Unit tests are for preventing future regressions. :) So that we know it wont' break again. In a "healthy" project, every bug would have a new automated test. But we don't have the resources yet.

Question editor is fundamental, so would be nice if it's fully covered.

gabrieljenik

gabrieljenik

2022-12-15 23:22

manager   ~73158

https://github.com/LimeSurvey/LimeSurvey/pull/2796

DenisChenu

DenisChenu

2022-12-16 11:30

developer   ~73161

:+1:

gabrieljenik

gabrieljenik

2022-12-21 14:10

manager   ~73237

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34180

Related Changesets

LimeSurvey: master 3f37eaf9

2022-12-21 14:09:56

gabrieljenik


Committer: GitHub Details Diff
Fixed issue 18503: Label sets: When adding a label set e.g. at the edit responses screen, the loaded label sets can not be searched (#2796)

Co-authored-by: lapiudevgit <devgit@lapiu.biz>
Affected Issues
18503
mod - assets/scripts/admin/questionEditor.js Diff File

Issue History

Date Modified Username Field Change
2022-11-22 13:36 Mazi New Issue
2022-11-22 13:36 Mazi File Added: image.png
2022-11-28 12:34 ollehar Priority none => normal
2022-11-28 12:34 ollehar Note Added: 72914
2022-11-28 12:34 ollehar Bug heat 0 => 2
2022-11-28 12:49 Mazi Note Added: 72915
2022-11-28 12:49 Mazi Bug heat 2 => 4
2022-11-29 09:56 ollehar Note Added: 72927
2022-11-29 09:57 ollehar Note Edited: 72927
2022-11-29 09:57 ollehar Note Edited: 72927
2022-11-29 09:57 ollehar Note Edited: 72927
2022-12-02 21:54 gabrieljenik Status new => confirmed
2022-12-07 19:38 gabrieljenik Assigned To => gabrieljenik
2022-12-07 19:38 gabrieljenik Status confirmed => assigned
2022-12-15 23:22 gabrieljenik Status assigned => ready for code review
2022-12-15 23:22 gabrieljenik Note Added: 73158
2022-12-15 23:22 gabrieljenik Bug heat 4 => 6
2022-12-15 23:22 gabrieljenik Assigned To gabrieljenik => DenisChenu
2022-12-16 11:30 DenisChenu Assigned To DenisChenu =>
2022-12-16 11:30 DenisChenu Status ready for code review => ready for testing
2022-12-16 11:30 DenisChenu Note Added: 73161
2022-12-16 11:30 DenisChenu Bug heat 6 => 8
2022-12-20 19:44 gabrieljenik Assigned To => ollehar
2022-12-20 19:44 gabrieljenik Status ready for testing => ready for merge
2022-12-21 14:10 gabrieljenik Changeset attached => LimeSurvey master 3f37eaf9
2022-12-21 14:10 gabrieljenik Note Added: 73237
2022-12-21 14:10 gabrieljenik Assigned To ollehar => gabrieljenik
2022-12-21 14:10 gabrieljenik Resolution open => fixed