Here : speed is OK because server are local
But with external SQL server : take long time

I have 4 server on the same network, on public and one internal. 2 for production + 2 for prepoduction , proxy for high availability, SQL server on same network but another server.

The 5.X is the preprod for testing version : the link to the DB server are same all other configuration are same. And BD is just some week old.

For 5.X : i'm connected directly by internal VPN : less network
For 3.X : external + my own VPN (AirVPN) +

Survey listing on 5.X : 20.48 s
Same survey listing on 3.X 2.56s

… it's REALLY unusuable

Idea one : Use a static array for template (like we do for Survey)

Idea : better action : move some needed action to findByPk only (when we get THE survey)
See related

better action : move some needed action to findByPk only (when we get THE survey)

Can we maybe do a lazy load of the template by overriding the getter?

Can we maybe do a lazy load of the template by overriding the getter?

We only need checking valid template and get all options only in findByPk not in findAll (search)

I muts check with Dev: #18556: Possible optimisation when lot of survey #2791

This part : https://github.com/LimeSurvey/LimeSurvey/pull/2791/files#diff-0268c3e4648700cef058f99725fd5364a285bd35701d30cfda885a81ce1c86a4R172-R175

We only need checking valid template and get all options only in findByPk not in findAll (search)

The code being executed is $model->template = xxxx in findByPk.
By having a special getter we can delay that an have that XXX being loaded only when $model->template is being called.

Just commenting that.

Looking at SQL debug : seems we call https://github.com/LimeSurvey/LimeSurvey/blob/5e5dc6d6e6dbe4fdec88664bc2f748a918503519/application/models/Survey.php#L824 each time in Surey listing too …
Really uneeded.

200 times group settings … 400 times user 1 …

Still have 20 times : (2 x number of survey shown, with 5 : 10 times)

system.db.CDbCommand.query(SELECT *) WHERE (`t`.`gsid`=1))

41 times (have 42 surveys )

system.db.CDbCommand.query(SELECT * FROM `lime_users` `t` WHERE `t`.`uid`=1 LIMIT 1)

13 times for a lot of template

system.db.CDbCommand.query(SELECT `template`.`id` AS `t1_c0`, `template`.`name` AS `t1_c1`, `template`.`folder` AS `t1_c2`, `template`.`title` AS `t1_c3`, `template`.`creation_date` AS `t1_c4`, `template`.`author` AS `t1_c5`, `template`.`author_email` AS `t1_c6`, `template`.`author_url` AS `t1_c7`, `template`.`copyright` AS `t1_c8`, `template`.`license` AS `t1_c9`, `template`.`version` AS `t1_c10`, `template`.`api_version` AS `t1_c11`, `template`.`view_folder` AS `t1_c12`, `template`.`files_folder` AS `t1_c13`, `template`.`description` AS `t1_c14`, `template`.`last_update` AS `t1_c15`, `template`.`owner_id` AS `t1_c16`, `template`.`extends` AS `t1_c17` FROM `lime_templates` `template` WHERE (`template`.`name`=:ypl0). Bound with :ypl0='skelvanilla')

GroupSettings : https://github.com/LimeSurvey/LimeSurvey/pull/3737
template : https://github.com/LimeSurvey/LimeSurvey/pull/3738

stull User :)

https://github.com/LimeSurvey/LimeSurvey/pull/3738

master https://github.com/LimeSurvey/LimeSurvey/pull/3738

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=36117

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=36116

For 5X

Fixed in Release 6.4.9+240226

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=36164

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=36163

For 5.X

5.x : https://github.com/LimeSurvey/LimeSurvey/pull/3786

Fixed in Release 6.4.12+240311

Fix committed to 5.x branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=36274

Fix committed to 5.x branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=36273