18465: ComfortUpdate fails with Server Error but can be continued without problems afterwards

This bug affects 1 person(s).

ID	Project	Category	View Status	Date Submitted	Last Update

18465	Bug reports	ComfortUpdate	public	2022-11-07 11:14	2023-06-26 12:02

Reporter	Mazi	Assigned To	c_schmitz
Priority	none	Severity	partial_block
Status	closed	Resolution	fixed
Product Version	5.4.x

Summary	18465: ComfortUpdate fails with Server Error but can be continued without problems afterwards
Description	Often when updating our systems the update first fails at the first run with a "Server Error" message and the note to contact the support, see screenshot. If you just start the update again, everything works fine. We had seen that behavior a dozen times at different systems. I have no idea what is causing the issue but you should definitely adjust the error message to something like "Please try again, usually it works at the second run." to prevent unnecessary support tickets.
Steps To Reproduce	Steps to reproduce Run ComfortUpdate Expected result On error show a note about trying again. Actual result Only the note to contact support is shown which is useless because usually running ComfortUpdate a second time fixes the problem.
Tags	No tags attached.
Attached Files	image.png (7,488 bytes) image.png (7,488 bytes)

Bug heat	6
Complete LimeSurvey version number (& build)	5.3.11
I will donate to the project if issue is resolved	No
Browser
Database type & version	MySQL
Server OS (if known)
Webserver software & version (if known)
PHP Version	8.1

User List	There are no users monitoring this issue.

Mazi 2022-11-07 11:15 updater ~72582	@c_schmitz, assigning this one to you so you can suggest a beautiful error message.

Mazi 2023-01-23 12:03 updater ~73527	I am continuously facing this issue when updating our test systems or customer systems. A minute ago this happened when updating from 5.2 to 5.6, see screenshot. But it is Independent from the versions used. After re-running the update, everything worked fine (as usual). ComfortUpdate is a great tool but with this mis-leading error message it looks like an unusable, buggy tool to Limesurvey users and customers. image-2.png (15,372 bytes) image-2.png (15,372 bytes)

Mazi 2023-06-07 13:55 updater ~75460	@c_schmitz, we are also facing the exact same behavior when updating LS 6.x Others have reported similar issues as well, see 18810. Re-running the ComfortUpdate procedure fixes this. But most users probably just skip it or later update manually. So why not adding a "Please try again" note?

c_schmitz 2023-06-14 16:53 administrator ~75634	Will have a look!

c_schmitz 2023-06-20 15:03 administrator ~75737	Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34859

c_schmitz 2023-06-20 15:18 administrator ~75738	Fix committed to 5.x branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34860

LimeBot 2023-06-26 12:02 administrator ~75859	Fixed in Release 6.1.5+230626

LimeSurvey: master 43b04449 2023-06-20 17:02 c_schmitz Details Diff	Fixed issue 18465: ComfortUpdate shows error message to contact the LimeSurvey team, while just retrying usually works	Affected Issues 18465
	mod - application/views/admin/update/updater/_error.php	Diff File
LimeSurvey: 5.x 16c748a9 2023-06-20 17:02 c_schmitz Details Diff	Fixed issue 18465: ComfortUpdate shows error message to contact the LimeSurvey team, while just retrying usually works	Affected Issues 18465
	mod - application/views/admin/update/updater/_error.php	Diff File

Date Modified	Username	Field	Change
2022-11-07 11:14	Mazi	New Issue
2022-11-07 11:14	Mazi	File Added: image.png
2022-11-07 11:15	Mazi	Assigned To	=> c_schmitz
2022-11-07 11:15	Mazi	Status	new => assigned
2022-11-07 11:15	Mazi	Note Added: 72582
2022-11-07 11:15	Mazi	Bug heat	0 => 2
2023-01-23 12:03	Mazi	Note Added: 73527
2023-01-23 12:03	Mazi	File Added: image-2.png
2023-06-07 13:54	Mazi	Relationship added	parent of 18810
2023-06-07 13:55	Mazi	Note Added: 75460
2023-06-14 16:53	c_schmitz	Note Added: 75634
2023-06-14 16:53	c_schmitz	Bug heat	2 => 4
2023-06-20 15:03	c_schmitz	Changeset attached	=> LimeSurvey master 43b04449
2023-06-20 15:03	c_schmitz	Note Added: 75737
2023-06-20 15:03	c_schmitz	Resolution	open => fixed
2023-06-20 15:04	c_schmitz	Relationship replaced	related to 18810
2023-06-20 15:05	c_schmitz	Status	assigned => resolved
2023-06-20 15:18	c_schmitz	Changeset attached	=> LimeSurvey 5.x 16c748a9
2023-06-20 15:18	c_schmitz	Note Added: 75738
2023-06-26 12:02	LimeBot	Note Added: 75859
2023-06-26 12:02	LimeBot	Status	resolved => closed
2023-06-26 12:02	LimeBot	Bug heat	4 => 6