View Issue Details

This issue affects 1 person(s).
 6
IDProjectCategoryView StatusLast Update
18226Bug reportsTheme editorpublic2024-11-19 18:15
Reporterc_schmitz Assigned Togabrieljenik  
PriorityurgentSeverityblock 
Status closedResolutionfixed 
Summary18226: Page title not changing
Description

The page title is always the same on every page
The page title is always output first by the screen reader. This title should always consist of a fixed and a variable component.
The pattern could be

{Survey title} - {Group title} - for group by group surveys
and
{Survey title} - {Question title} - for page by page surveys

Problem is that currently there is no group or question twig variable available in head.twig

Task:
This subtask is a part of 18225
1.) Quick and dynamic solution: Make question/group variables available to HEAD (if the are not empty). Hardcode the pattern "Survey Title - Group title" for now
2.) Maybe later: Make it a template option ?

  • Survey Title
  • Survey Title - Group title
  • Survey Title - Group title - Question title
  • Survey Title - Question title
Steps To Reproduce

Run any survey having several pages and check.

TagsNo tags attached.
Bug heat6
Complete LimeSurvey version number (& build)
I will donate to the project if issue is resolved
Browser
Database type & version
Server OS (if known)
Webserver software & version (if known)
PHP Version
Git branch / Pull Request URLN/A

Relationships

related to 18157 closed Feature requests Need more information for title of page 
child of 18225 closedc_schmitz Bug reports Make skel_vanilla a core theme 

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2022-06-30 13:52

developer   ~70627

1.) Quick and dynamic solution: Make question/group variables available to HEAD (if the are not empty). Hardcode the pattern "Survey Title - Group title" for now

https://gitlab.com/SondagesPro/SurveyThemes/skelvanilla/-/issues/44

I think same then old 26 lts :

  1. Add "step" info
  2. Update in vanilla

The issue is more because we do action after HTML is started …

c_schmitz

c_schmitz

2022-07-11 15:05

administrator   ~70853

We agreed to implement the page( (stepnumber) instead, because it is much easier to get the information.

gabrieljenik

gabrieljenik

2022-07-13 14:02

developer   ~70894

Done

image.png (29,483 bytes)   
image.png (29,483 bytes)   
DenisChenu

DenisChenu

2022-07-13 15:11

developer   ~70902

Hacked theme ?
I)here it's set only ?
You don't have the groupname etc ?

c_schmitz

c_schmitz

2022-07-14 11:03

administrator   ~70929

Need to add page.

gabrieljenik

gabrieljenik

2022-07-14 15:08

developer   ~70934

Page Number is there. On screenshot attached previosuly. Not getting that?

c_schmitz

c_schmitz

2022-07-14 17:11

administrator   ~70944

Last edited: 2022-07-15 15:09

Sorry for not being clear enough - I meant the word gT('page') before the page number (yes, in lowercase)

c_schmitz

c_schmitz

2022-07-15 16:31

administrator   ~70964

Also customer reported that on the page where you enter the token access key the title is broken, now.

c_schmitz

c_schmitz

2022-07-18 10:00

administrator   ~70983

Thanks, looks great now.

Issue History

Date Modified Username Field Change
2022-06-30 13:39 c_schmitz New Issue
2022-06-30 13:40 c_schmitz Description Updated
2022-06-30 13:40 c_schmitz Description Updated
2022-06-30 13:41 c_schmitz Description Updated
2022-06-30 13:41 c_schmitz Assigned To => DenisChenu
2022-06-30 13:41 c_schmitz Status new => assigned
2022-06-30 13:41 c_schmitz Relationship added child of 18225
2022-06-30 13:41 c_schmitz Description Updated
2022-06-30 13:42 c_schmitz Description Updated
2022-06-30 13:44 c_schmitz Steps to Reproduce Updated
2022-06-30 13:52 DenisChenu Note Added: 70627
2022-06-30 13:52 DenisChenu Bug heat 0 => 2
2022-06-30 13:52 DenisChenu Relationship added related to 18157
2022-06-30 13:53 c_schmitz Issue cloned: 18227
2022-06-30 15:02 c_schmitz Priority none => urgent
2022-07-11 15:05 c_schmitz Note Added: 70853
2022-07-11 15:05 c_schmitz Bug heat 2 => 4
2022-07-11 15:38 c_schmitz Assigned To DenisChenu => gabrieljenik
2022-07-13 14:02 gabrieljenik Note Added: 70894
2022-07-13 14:02 gabrieljenik File Added: image.png
2022-07-13 14:02 gabrieljenik Bug heat 4 => 6
2022-07-13 14:02 gabrieljenik Assigned To gabrieljenik => c_schmitz
2022-07-13 14:02 gabrieljenik Status assigned => ready for code review
2022-07-13 15:11 DenisChenu Note Added: 70902
2022-07-14 11:03 c_schmitz Note Added: 70929
2022-07-14 15:08 gabrieljenik Note Added: 70934
2022-07-14 17:11 c_schmitz Note Added: 70944
2022-07-14 17:11 c_schmitz Assigned To c_schmitz => gabrieljenik
2022-07-14 17:12 c_schmitz Status ready for code review => assigned
2022-07-15 15:09 c_schmitz Note Edited: 70944
2022-07-15 16:31 c_schmitz Note Added: 70964
2022-07-18 10:00 c_schmitz Status assigned => resolved
2022-07-18 10:00 c_schmitz Resolution open => fixed
2022-07-18 10:00 c_schmitz Note Added: 70983
2024-11-19 18:15 c_schmitz Status resolved => closed