View Issue Details

This bug affects 1 person(s).
 8
IDProjectCategoryView StatusLast Update
18092Bug reportsSurvey editingpublic2022-07-05 12:27
Reporterduvemyster Assigned Togabrieljenik  
PrioritynoneSeverityminor 
Status closedResolutionfixed 
Product Version5.3.x 
Summary18092: File upload show title/comment=off not yet fully respected
Description

When 'Show title' and 'Show comment' are set to 'off' and a file has been uploaded and saved, then Title and Comment columns are displayed to the respondent as they continue working through their survey.

Steps To Reproduce

Steps to reproduce

  1. Set a file-upload question's 'Show title' and 'Show comments' to 'off' in 'File metadata'.
  2. Upload a file and save.
  3. Title and Comment columns are displayed in the survey.

Expected result

Just the 'File name' column should be displayed.

Actual result

Empty/Blank Title and Comment columns are displayed.

TagsNo tags attached.
Attached Files
Show is off.PNG (5,804 bytes)   
Show is off.PNG (5,804 bytes)   
Title and Comment.PNG (12,465 bytes)   
Title and Comment.PNG (12,465 bytes)   
Bug heat8
Complete LimeSurvey version number (& build)Version 5.3.12+220502
I will donate to the project if issue is resolvedNo
BrowserAny
Database type & versionMySQL
Server OS (if known)Apache2
Webserver software & version (if known)Linux - Debian 4.19.181-1
PHP Version7.4.13

Users monitoring this issue

There are no users monitoring this issue.

Activities

duvemyster

duvemyster

2022-05-10 16:31

reporter   ~69547

See also https://forums.limesurvey.org/forum/can-i-do-this-with-limesurvey/127376-list-filenames-in-5-x-response#228182 and the discussion above it.

DenisChenu

DenisChenu

2022-05-13 15:34

developer   ~69625

@gabrieljenik you take this issue ?
It's a “reservation” ?

gabrieljenik

gabrieljenik

2022-05-13 15:58

manager   ~69628

I will have it confirmed

gabrieljenik

gabrieljenik

2022-05-18 20:39

manager   ~69802

https://github.com/LimeSurvey/LimeSurvey/pull/2427

In LTS the table was built in JS, and the columns were added only if appropriate. In master the structure is in a branch, so they always appear.

Now they are hidden by js/css.

gabrieljenik

gabrieljenik

2022-06-27 00:39

manager   ~70536

Tested OK

gabrieljenik

gabrieljenik

2022-07-01 14:56

manager   ~70672

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=33612

LimeBot

LimeBot

2022-07-05 12:27

administrator   ~70707

Fixed in Release 5.3.23+220705

Related Changesets

LimeSurvey: master b6cd3459

2022-07-01 14:36:48

gabrieljenik


Committer: GitHub Details Diff
Fixed issue 18092: File upload show title/comment=off not yet fully respected (#2427) Affected Issues
18092
mod - application/views/survey/questions/answer/file_upload/answer.twig Diff File

Issue History

Date Modified Username Field Change
2022-05-07 17:07 duvemyster New Issue
2022-05-07 17:07 duvemyster File Added: Show is off.PNG
2022-05-07 17:07 duvemyster File Added: Title and Comment.PNG
2022-05-10 16:31 duvemyster Note Added: 69547
2022-05-10 16:31 duvemyster Bug heat 0 => 2
2022-05-13 15:11 gabrieljenik Assigned To => gabrieljenik
2022-05-13 15:11 gabrieljenik Status new => assigned
2022-05-13 15:12 gabrieljenik Status assigned => new
2022-05-13 15:34 DenisChenu Note Added: 69625
2022-05-13 15:34 DenisChenu Bug heat 2 => 4
2022-05-13 15:58 gabrieljenik Note Added: 69628
2022-05-13 15:58 gabrieljenik Bug heat 4 => 6
2022-05-16 22:07 gabrieljenik Status new => confirmed
2022-05-18 20:39 gabrieljenik Status confirmed => ready for testing
2022-05-18 20:39 gabrieljenik Note Added: 69802
2022-06-27 00:39 gabrieljenik Status ready for testing => ready for merge
2022-06-27 00:39 gabrieljenik Note Added: 70536
2022-07-01 14:56 gabrieljenik Changeset attached => LimeSurvey master b6cd3459
2022-07-01 14:56 gabrieljenik Note Added: 70672
2022-07-01 14:56 gabrieljenik Resolution open => fixed
2022-07-05 12:27 LimeBot Note Added: 70707
2022-07-05 12:27 LimeBot Status ready for merge => closed
2022-07-05 12:27 LimeBot Bug heat 6 => 8