View Issue Details

This bug affects 1 person(s).
 6
IDProjectCategoryView StatusLast Update
17889Bug reportsSurvey participants (Tokens)public2022-05-19 17:18
ReporterMazi Assigned Togabrieljenik  
PrioritynoneSeverityblock 
Status closedResolutionfixed 
Product Version3.25.20 
Summary17889: Setting to correct server time not taken into account when sending email invitations
Description

At my server I adjusted the server time at the globanl settings to be +1, see screenshot.

If I create a new token entry and set the valid from date to today and the current time (e.g. 12:00h) and then try to send the invitation afterwards, I get an error:
"Email to XXXXXXXXX delayed: Token is not yet valid.
Not all emails were sent:
Some entries had a validity date set which was not yet valid or not valid anymore."

-> It looks like the adjusted server time is not taken into account when checking the valid from date.

If I change the valid from date to "now()" - 1h (e.g. 11:00h), I can send that email.

Steps To Reproduce

Steps to reproduce

Set your server time to e.g. +1h at the global settings.
Create a test survey with a single token and set the valid from date to the current date. It seems to be set correctly.
Directly send an email invitation. You should receive an error that the token is not yet valid.

Expected result

Check server time adjustment when checking valid from date.

Actual result

Email not sent because valid from is validated incorrectly.

TagsNo tags attached.
Bug heat6
Complete LimeSurvey version number (& build)Version 3.27.35+220208
I will donate to the project if issue is resolvedNo
BrowserChrome
Database type & versionMySQL
Server OS (if known)Ubuntu 18
Webserver software & version (if known)Apache 2.0
PHP Version7.4

Relationships

related to 18078 closedgabrieljenik Dump while sending invitations, there is a problem with the validity of a token and debug=2 

Users monitoring this issue

User List There are no users monitoring this issue.

Activities

Mazi

Mazi

2022-02-14 12:07

updater  

image.png (6,462 bytes)   
image.png (6,462 bytes)   
gabrieljenik

gabrieljenik

2022-04-18 22:34

manager   ~69110

PR: https://github.com/LimeSurvey/LimeSurvey/pull/2356

gabrieljenik

gabrieljenik

2022-05-04 06:39

manager   ~69382

Fix committed to 3.x-LTS branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=33463

gabrieljenik

gabrieljenik

2022-05-05 19:09

manager   ~69432

PR for master: https://github.com/LimeSurvey/LimeSurvey/pull/2401

LimeBot

LimeBot

2022-05-09 12:39

administrator   ~69514

Fixed in Release 3.28.10+220510

Mazi

Mazi

2022-05-17 12:15

updater   ~69713

@gabrieljenik, this one is marked as "Fixed at latest release" but the pull request at https://github.com/LimeSurvey/LimeSurvey/pull/2401 is not merged yet?! Or did I miss anything?

gabrieljenik

gabrieljenik

2022-05-17 14:06

manager   ~69723

I reopened it. For LTS is merged. For master is pending.

gabrieljenik

gabrieljenik

2022-05-18 02:12

manager   ~69758

Tested it PR for master. Pending to be merged.

gabrieljenik

gabrieljenik

2022-05-19 12:03

manager   ~69837

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=33493

LimeBot

LimeBot

2022-05-19 17:18

administrator   ~69867

Fixed in Release 5.3.15+220519

Related Changesets

LimeSurvey: 3.x-LTS d1983da4

2022-05-04 06:39:27

gabrieljenik


Committer: GitHub Details Diff
Fixed issue 17889: Setting to correct server time not taken into account when sending email invitations (#2356)

Co-authored-by: encuestabizdevgit <devgit@encuesta.biz>
Affected Issues
17889
mod - application/controllers/admin/tokens.php Diff File

LimeSurvey: master 7af93912

2022-05-19 12:03:09

gabrieljenik


Committer: GitHub Details Diff
Fixed issue 17889: Setting to correct server time not taken into account when sending email invitations (#2401)

* Fixed issue 17889: Setting to correct server time not taken into account when sending email invitations

* Fixed issue 17889: Setting to correct server time not taken into account when sending email invitations

- Restructured validations
- Fixed additional error when data validation fails (missing )

Co-authored-by: encuestabizdevgit <devgit@encuesta.biz>
Affected Issues
17889
mod - application/controllers/admin/Tokens.php Diff File

Issue History

Date Modified Username Field Change
2022-02-14 12:07 Mazi New Issue
2022-02-14 12:07 Mazi File Added: image.png
2022-02-17 09:30 galads Assigned To => galads
2022-02-17 09:30 galads Status new => confirmed
2022-02-17 09:30 galads Zoho Project Synchronization => |Yes|
2022-03-31 11:58 galads Assigned To galads => gabrieljenik
2022-03-31 11:58 galads Zoho Project Synchronization Yes =>
2022-04-18 22:34 gabrieljenik Status confirmed => ready for testing
2022-04-18 22:34 gabrieljenik Note Added: 69110
2022-04-18 22:34 gabrieljenik Bug heat 0 => 2
2022-05-04 06:39 gabrieljenik Changeset attached => LimeSurvey 3.x-LTS d1983da4
2022-05-04 06:39 gabrieljenik Note Added: 69382
2022-05-04 06:39 gabrieljenik Resolution open => fixed
2022-05-05 19:09 gabrieljenik Note Added: 69432
2022-05-05 19:12 gabrieljenik Issue cloned: 18078
2022-05-05 19:12 gabrieljenik Relationship added related to 18078
2022-05-09 12:39 LimeBot Note Added: 69514
2022-05-09 12:40 LimeBot Status ready for testing => closed
2022-05-09 12:40 LimeBot Bug heat 2 => 4
2022-05-09 17:22 gabrieljenik Status closed => ready for testing
2022-05-17 12:15 Mazi Note Added: 69713
2022-05-17 12:15 Mazi Bug heat 4 => 6
2022-05-17 14:06 gabrieljenik Note Added: 69723
2022-05-18 02:12 gabrieljenik Note Added: 69758
2022-05-18 02:19 gabrieljenik Status ready for testing => resolved
2022-05-19 12:03 gabrieljenik Changeset attached => LimeSurvey master 7af93912
2022-05-19 12:03 gabrieljenik Note Added: 69837
2022-05-19 17:18 LimeBot Note Added: 69867
2022-05-19 17:18 LimeBot Status resolved => closed