View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
17817 | Bug reports | Survey editing | public | 2021-12-22 16:13 | 2023-06-16 11:07 |
Reporter | DenisChenu | Assigned To | galads | ||
Priority | none | Severity | minor | ||
Status | closed | Resolution | fixed | ||
Product Version | 3.25.20 | ||||
Summary | 17817: Activate survey 2 times with MSSQL can break | ||||
Description | When survey is activated for a second time, it throw error with debug = 2 In 3.27.26, not in 3.27.9 (unsure of exact issue number) | ||||
Steps To Reproduce | Steps to reproduceFound a IIS server with pdo_mssql Expected resultSurvey is activated a second time Actual resultThrow an error | ||||
Tags | No tags attached. | ||||
Attached Files | PHP notice.htm (21,019 bytes)
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"> <html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en"><head> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"> <title>PHP notice</title> <style type="text/css"> /*<![CDATA[*/ html,body,div,span,applet,object,iframe,h1,h2,h3,h4,h5,h6,p,blockquote,pre,a,abbr,acronym,address,big,cite,code,del,dfn,em,font,img,ins,kbd,q,s,samp,small,strike,strong,sub,sup,tt,var,b,u,i,center,dl,dt,dd,ol,ul,li,fieldset,form,label,legend,table,caption,tbody,tfoot,thead,tr,th,td{border:0;outline:0;font-size:100%;vertical-align:baseline;background:transparent;margin:0;padding:0;} body{line-height:1;} ol,ul{list-style:none;} blockquote,q{quotes:none;} blockquote:before,blockquote:after,q:before,q:after{content:none;} :focus{outline:0;} ins{text-decoration:none;} del{text-decoration:line-through;} table{border-collapse:collapse;border-spacing:0;} body { font: normal 9pt "Verdana"; color: #000; background: #fff; } h1 { font: normal 18pt "Verdana"; color: #f00; margin-bottom: .5em; } h2 { font: normal 14pt "Verdana"; color: #800000; margin-bottom: .5em; } h3 { font: bold 11pt "Verdana"; } pre { font: normal 11pt Menlo, Consolas, "Lucida Console", Monospace; } pre span.error { display: block; background: #fce3e3; } pre span.ln { color: #999; padding-right: 0.5em; border-right: 1px solid #ccc; } pre span.error-ln { font-weight: bold; } .container { margin: 1em 4em; } .version { color: gray; font-size: 8pt; border-top: 1px solid #aaa; padding-top: 1em; margin-bottom: 1em; } .message { color: #000; padding: 1em; font-size: 11pt; background: #f3f3f3; -webkit-border-radius: 10px; -moz-border-radius: 10px; border-radius: 10px; margin-bottom: 1em; line-height: 160%; } .source { margin-bottom: 1em; } .code pre { background-color: #ffe; margin: 0.5em 0; padding: 0.5em; line-height: 125%; border: 1px solid #eee; } .source .file { margin-bottom: 1em; font-weight: bold; } .traces { margin: 2em 0; } .trace { margin: 0.5em 0; padding: 0.5em; } .trace.app { border: 1px dashed #c00; } .trace .number { text-align: right; width: 2em; padding: 0.5em; } .trace .content { padding: 0.5em; } .trace .plus, .trace .minus { display:inline; vertical-align:middle; text-align:center; border:1px solid #000; color:#000; font-size:10px; line-height:10px; margin:0; padding:0 1px; width:10px; height:10px; } .trace.collapsed .minus, .trace.expanded .plus, .trace.collapsed pre { display: none; } .trace-file { cursor: pointer; padding: 0.2em; } .trace-file:hover { background: #f0ffff; } /*]]>*/ </style> </head> <body> <div class="container"> <h1>PHP notice</h1> <p class="message"> Trying to access array offset on value of type bool </p> <div class="source"> <p class="file">E:\WebSite\limesurvey\application\helpers\admin\activate_helper.php(528)</p> <div class="code"><pre><span class="ln">516</span> global $modifyoutput; <span class="ln">517</span> Yii::app()->loadHelper("database"); <span class="ln">518</span> <span class="ln">519</span> // find out the name of the default constraint <span class="ln">520</span> // Did I already mention that this is the most suckiest thing I have ever seen in MSSQL database? <span class="ln">521</span> $dfquery = "SELECT c_obj.name AS constraint_name <span class="ln">522</span> FROM sys.sysobjects AS c_obj INNER JOIN <span class="ln">523</span> sys.sysobjects AS t_obj ON c_obj.parent_obj = t_obj.id INNER JOIN <span class="ln">524</span> sys.sysconstraints AS con ON c_obj.id = con.constid INNER JOIN <span class="ln">525</span> sys.syscolumns AS col ON t_obj.id = col.id AND con.colid = col.colid <span class="ln">526</span> WHERE (c_obj.xtype = 'D') AND (col.name = '$fieldname') AND (t_obj.name='{{{$tablename}}}')"; <span class="ln">527</span> $result = dbExecuteAssoc($dfquery)->read(); <span class="error"><span class="ln error-ln">528</span> $defaultname = $result['CONTRAINT_NAME']; </span><span class="ln">529</span> if ($defaultname != false) { <span class="ln">530</span> modifyDatabase("", "ALTER TABLE {{{$tablename}}} DROP CONSTRAINT {$defaultname[0]}"); echo $modifyoutput; flush(); <span class="ln">531</span> } <span class="ln">532</span> } <span class="ln">533</span> <span class="ln">534</span> <span class="ln">535</span> /** <span class="ln">536</span> * @param string $tablename <span class="ln">537</span> */ <span class="ln">538</span> function mssql_drop_primary_index($tablename) <span class="ln">539</span> { <span class="ln">540</span> Yii::app()->loadHelper("database"); </pre></div> </div> <div class="traces"> <h2>Stack Trace</h2> <table style="width:100%;"> <tbody><tr class="trace app expanded"> <td class="number"> #0 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> E:\WebSite\limesurvey\application\helpers\admin\activate_helper.php(449): <strong>mssql_drop_constraint</strong>("id", "survey_127298") </div> <div class="code"><pre><span class="ln">444</span> $iAutoNumberStart = Yii::app()->db->createCommand($sQuery)->queryScalar(); <span class="ln">445</span> //if there is an autonumber_start field, start auto numbering here <span class="ln">446</span> if ($iAutoNumberStart !== false && $iAutoNumberStart > 0) { <span class="ln">447</span> if (Yii::app()->db->driverName == 'mssql' || Yii::app()->db->driverName == 'sqlsrv' || Yii::app()->db->driverName == 'dblib') { <span class="ln">448</span> mssql_drop_primary_index('survey_'.$iSurveyID); <span class="error"><span class="ln error-ln">449</span> mssql_drop_constraint('id', 'survey_'.$iSurveyID); </span><span class="ln">450</span> $sQuery = "ALTER TABLE {{survey_{$iSurveyID}}} drop column id "; <span class="ln">451</span> Yii::app()->db->createCommand($sQuery)->execute(); <span class="ln">452</span> $sQuery = "ALTER TABLE {{survey_{$iSurveyID}}} ADD [id] int identity({$iAutoNumberStart},1)"; <span class="ln">453</span> Yii::app()->db->createCommand($sQuery)->execute(); <span class="ln">454</span> // Add back the primaryKey </pre></div> </td> </tr> <tr class="trace app expanded"> <td class="number"> #1 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> E:\WebSite\limesurvey\application\controllers\admin\surveyadmin.php(930): <strong>activateSurvey</strong>(127298) </div> <div class="code"><pre><span class="ln">925</span> $survey->savetimings = Yii::app()->request->getPost('savetimings'); <span class="ln">926</span> $survey->save(); <span class="ln">927</span> Survey::model()->resetCache(); // Make sure the saved values will be picked up <span class="ln">928</span> } <span class="ln">929</span> <span class="error"><span class="ln error-ln">930</span> $aResult = activateSurvey($iSurveyID); </span><span class="ln">931</span> $aViewUrls = array(); <span class="ln">932</span> if ((isset($aResult['error']) && $aResult['error'] == 'plugin') <span class="ln">933</span> || (isset($aResult['blockFeedback']) && $aResult['blockFeedback'])) { <span class="ln">934</span> // Got false from plugin, redirect to survey front-page <span class="ln">935</span> $this->getController()->redirect(array('admin/survey', 'sa'=>'view', 'surveyid'=>$iSurveyID)); </pre></div> </td> </tr> <tr class="trace core collapsed"> <td class="number"> #2 </td> <td class="content"> <div class="trace-file"> unknown(0): <strong>SurveyAdmin</strong>-><strong>activate</strong>(127298) </div> </td> </tr> <tr class="trace core collapsed"> <td class="number"> #3 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> E:\WebSite\limesurvey\framework\web\actions\CAction.php(115): <strong>ReflectionMethod</strong>-><strong>invokeArgs</strong>(SurveyAdmin, array("127298")) </div> <div class="code"><pre><span class="ln">110</span> elseif($param->isDefaultValueAvailable()) <span class="ln">111</span> $ps[]=$param->getDefaultValue(); <span class="ln">112</span> else <span class="ln">113</span> return false; <span class="ln">114</span> } <span class="error"><span class="ln error-ln">115</span> $method->invokeArgs($object,$ps); </span><span class="ln">116</span> return true; <span class="ln">117</span> } <span class="ln">118</span> } </pre></div> </td> </tr> <tr class="trace app expanded"> <td class="number"> #4 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> E:\WebSite\limesurvey\application\core\Survey_Common_Action.php(83): <strong>CAction</strong>-><strong>runWithParamsInternal</strong>(SurveyAdmin, ReflectionMethod, array("r" => "admin/survey/sa/activate/surveyid/127298", "sa" => "activate", "surveyid" => "127298", "iSurveyId" => "127298", ...)) </div> <div class="code"><pre><span class="ln">78</span> $oMethod = new ReflectionMethod($this, $sDefault); <span class="ln">79</span> } <span class="ln">80</span> <span class="ln">81</span> // We're all good to go, let's execute it <span class="ln">82</span> // runWithParamsInternal would automatically get the parameters of the method and populate them as required with the params <span class="error"><span class="ln error-ln">83</span> return parent::runWithParamsInternal($this, $oMethod, $params); </span><span class="ln">84</span> } <span class="ln">85</span> <span class="ln">86</span> /** <span class="ln">87</span> * Some functions have different parameters, which are just an alias of the <span class="ln">88</span> * usual parameters we're getting in the url. This function just populates </pre></div> </td> </tr> <tr class="trace core collapsed"> <td class="number"> #5 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> E:\WebSite\limesurvey\framework\web\CController.php(308): <strong>Survey_Common_Action</strong>-><strong>runWithParams</strong>(array("r" => "admin/survey/sa/activate/surveyid/127298", "sa" => "activate", "surveyid" => "127298", "iSurveyId" => "127298", ...)) </div> <div class="code"><pre><span class="ln">303</span> { <span class="ln">304</span> $priorAction=$this->_action; <span class="ln">305</span> $this->_action=$action; <span class="ln">306</span> if($this->beforeAction($action)) <span class="ln">307</span> { <span class="error"><span class="ln error-ln">308</span> if($action->runWithParams($this->getActionParams())===false) </span><span class="ln">309</span> $this->invalidActionParams($action); <span class="ln">310</span> else <span class="ln">311</span> $this->afterAction($action); <span class="ln">312</span> } <span class="ln">313</span> $this->_action=$priorAction; </pre></div> </td> </tr> <tr class="trace core collapsed"> <td class="number"> #6 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> E:\WebSite\limesurvey\framework\web\CController.php(286): <strong>CController</strong>-><strong>runAction</strong>(SurveyAdmin) </div> <div class="code"><pre><span class="ln">281</span> * @see runAction <span class="ln">282</span> */ <span class="ln">283</span> public function runActionWithFilters($action,$filters) <span class="ln">284</span> { <span class="ln">285</span> if(empty($filters)) <span class="error"><span class="ln error-ln">286</span> $this->runAction($action); </span><span class="ln">287</span> else <span class="ln">288</span> { <span class="ln">289</span> $priorAction=$this->_action; <span class="ln">290</span> $this->_action=$action; <span class="ln">291</span> CFilterChain::create($this,$action,$filters)->run(); </pre></div> </td> </tr> <tr class="trace core collapsed"> <td class="number"> #7 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> E:\WebSite\limesurvey\framework\web\CController.php(265): <strong>CController</strong>-><strong>runActionWithFilters</strong>(SurveyAdmin, array()) </div> <div class="code"><pre><span class="ln">260</span> { <span class="ln">261</span> if(($parent=$this->getModule())===null) <span class="ln">262</span> $parent=Yii::app(); <span class="ln">263</span> if($parent->beforeControllerAction($this,$action)) <span class="ln">264</span> { <span class="error"><span class="ln error-ln">265</span> $this->runActionWithFilters($action,$this->filters()); </span><span class="ln">266</span> $parent->afterControllerAction($this,$action); <span class="ln">267</span> } <span class="ln">268</span> } <span class="ln">269</span> else <span class="ln">270</span> $this->missingAction($actionID); </pre></div> </td> </tr> <tr class="trace app collapsed"> <td class="number"> #8 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> E:\WebSite\limesurvey\application\controllers\AdminController.php(165): <strong>CController</strong>-><strong>run</strong>("survey") </div> <div class="code"><pre><span class="ln">160</span> $this->redirect(array('/admin/authentication/sa/login')); <span class="ln">161</span> } <span class="ln">162</span> } <span class="ln">163</span> } <span class="ln">164</span> <span class="error"><span class="ln error-ln">165</span> return parent::run($action); </span><span class="ln">166</span> } <span class="ln">167</span> <span class="ln">168</span> /** <span class="ln">169</span> * Routes all the actions to their respective places <span class="ln">170</span> * </pre></div> </td> </tr> <tr class="trace core collapsed"> <td class="number"> #9 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> E:\WebSite\limesurvey\framework\web\CWebApplication.php(282): <strong>AdminController</strong>-><strong>run</strong>("survey") </div> <div class="code"><pre><span class="ln">277</span> { <span class="ln">278</span> list($controller,$actionID)=$ca; <span class="ln">279</span> $oldController=$this->_controller; <span class="ln">280</span> $this->_controller=$controller; <span class="ln">281</span> $controller->init(); <span class="error"><span class="ln error-ln">282</span> $controller->run($actionID); </span><span class="ln">283</span> $this->_controller=$oldController; <span class="ln">284</span> } <span class="ln">285</span> else <span class="ln">286</span> throw new CHttpException(404,Yii::t('yii','Unable to resolve the request "{route}".', <span class="ln">287</span> array('{route}'=>$route===''?$this->defaultController:$route))); </pre></div> </td> </tr> <tr class="trace core collapsed"> <td class="number"> #10 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> E:\WebSite\limesurvey\framework\web\CWebApplication.php(141): <strong>CWebApplication</strong>-><strong>runController</strong>("admin/survey/sa/activate/surveyid/127298") </div> <div class="code"><pre><span class="ln">136</span> foreach(array_splice($this->catchAllRequest,1) as $name=>$value) <span class="ln">137</span> $_GET[$name]=$value; <span class="ln">138</span> } <span class="ln">139</span> else <span class="ln">140</span> $route=$this->getUrlManager()->parseUrl($this->getRequest()); <span class="error"><span class="ln error-ln">141</span> $this->runController($route); </span><span class="ln">142</span> } <span class="ln">143</span> <span class="ln">144</span> /** <span class="ln">145</span> * Registers the core application components. <span class="ln">146</span> * This method overrides the parent implementation by registering additional core components. </pre></div> </td> </tr> <tr class="trace core collapsed"> <td class="number"> #11 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> E:\WebSite\limesurvey\framework\base\CApplication.php(185): <strong>CWebApplication</strong>-><strong>processRequest</strong>() </div> <div class="code"><pre><span class="ln">180</span> public function run() <span class="ln">181</span> { <span class="ln">182</span> if($this->hasEventHandler('onBeginRequest')) <span class="ln">183</span> $this->onBeginRequest(new CEvent($this)); <span class="ln">184</span> register_shutdown_function(array($this,'end'),0,false); <span class="error"><span class="ln error-ln">185</span> $this->processRequest(); </span><span class="ln">186</span> if($this->hasEventHandler('onEndRequest')) <span class="ln">187</span> $this->onEndRequest(new CEvent($this)); <span class="ln">188</span> } <span class="ln">189</span> <span class="ln">190</span> /** </pre></div> </td> </tr> <tr class="trace app collapsed"> <td class="number"> #12 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> E:\WebSite\limesurvey\index.php(194): <strong>CApplication</strong>-><strong>run</strong>() </div> <div class="code"><pre><span class="ln">189</span> require_once APPPATH . 'core/LSYii_Application' . EXT; <span class="ln">190</span> <span class="ln">191</span> $config = require_once(APPPATH . 'config/internal' . EXT); <span class="ln">192</span> <span class="ln">193</span> Yii::$enableIncludePath = false; <span class="error"><span class="ln error-ln">194</span> Yii::createApplication('LSYii_Application', $config)->run(); </span><span class="ln">195</span> <span class="ln">196</span> /* End of file index.php */ <span class="ln">197</span> /* Location: ./index.php */ </pre></div> </td> </tr> </tbody></table> </div> <div class="version"> 2021-12-21 12:40:38 Microsoft-IIS/10.0 <a href="http://www.yiiframework.com/">Yii Framework</a>/1.1.24-dev </div> </div> <script type="text/javascript"> /*<![CDATA[*/ var traceReg = new RegExp("(^|\\s)trace-file(\\s|$)"); var collapsedReg = new RegExp("(^|\\s)collapsed(\\s|$)"); var e = document.getElementsByTagName("div"); for(var j=0,len=e.length;j<len;j++){ if(traceReg.test(e[j].className)){ e[j].onclick = function(){ var trace = this.parentNode.parentNode; if(collapsedReg.test(trace.className)) trace.className = trace.className.replace("collapsed", "expanded"); else trace.className = trace.className.replace("expanded", "collapsed"); } } } /*]]>*/ </script> </body></html> | ||||
Bug heat | 4 | ||||
Complete LimeSurvey version number (& build) | 3.27.26 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | not relevant | ||||
Database type & version | not relevant | ||||
Server OS (if known) | not relevant | ||||
Webserver software & version (if known) | not relevant | ||||
PHP Version | not relevant | ||||
Maybe the survey was activated but no tests was done ? |
|
Hello DenisChenu, c_schmitz |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2021-12-22 16:13 | DenisChenu | New Issue | |
2021-12-22 16:13 | DenisChenu | File Added: PHP notice.htm | |
2021-12-22 16:15 | DenisChenu | Note Added: 67845 | |
2021-12-22 16:15 | DenisChenu | Bug heat | 0 => 2 |
2021-12-27 09:06 | galads | Assigned To | => galads |
2021-12-27 09:06 | galads | Status | new => acknowledged |
2023-06-16 11:07 | c_schmitz | Status | acknowledged => closed |
2023-06-16 11:07 | c_schmitz | Resolution | open => fixed |
2023-06-16 11:07 | c_schmitz | Note Added: 75666 | |
2023-06-16 11:07 | c_schmitz | Bug heat | 2 => 4 |