View Issue Details

This bug affects 1 person(s).
 6
IDProjectCategoryView StatusLast Update
17374Bug reportsTheme editorpublic2021-10-01 15:33
ReporterDenisChenu Assigned Togabrieljenik  
PrioritynoneSeverityminor 
Status assignedResolutionopen 
Product Version5.x 
Summary17374: aSurveyInfo.datasecurity_notice_label do not return only the label
DescriptionaSurveyInfo.datasecurity_notice_label return the real label for inline text , nut with collapsible text : it's updated.
This make harder for theme dev to have a different sentence
Steps To ReproduceImport inluded survey and included template, try to update or find sentence "Afficher la politique" in model.

This come from updated aSurveyInfo.datasecurity_notice_label
With inline : aSurveyInfo.datasecurity_notice_label return the real clean value.


Additional InformationReturn clean value is always needed if you want Theme developer make great theme.

Same variable must return same value always.

Sentence : https://github.com/LimeSurvey/LimeSurvey/blob/86d4a00c551c1f11e91991eadcd635ec9514486c/themes/survey/vanilla/views/subviews/privacy/privacy_modal.twig#L22
«Same» sentence : https://github.com/LimeSurvey/LimeSurvey/blob/86d4a00c551c1f11e91991eadcd635ec9514486c/themes/survey/vanilla/views/subviews/privacy/privacy_text.twig#L27
TagsNo tags attached.
Bug heat6
Complete LimeSurvey version number (& build)3.27.2
I will donate to the project if issue is resolvedNo
Browsernot relevant
Database type & versionnot relevant
Server OS (if known)not relevant
Webserver software & version (if known)not relevant
PHP Versionnot relevant

Users monitoring this issue

User List There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2021-06-20 18:41

developer   ~64955

https://github.com/LimeSurvey/LimeSurvey/blob/d0b555b6afac21281d1ba8a7e258082b4067b9aa/application/models/Survey.php#L2045
galads

galads

2021-07-12 12:53

administrator   ~65373

Last edited: 2021-09-10 09:08

Want to create a PR?
DenisChenu

DenisChenu

2021-07-12 13:00

developer   ~65374

Last edited: 2021-09-10 09:08



Not really ... if report issue make me make a PR each time, maybe i don't report new issue
galads

galads

2021-07-12 13:03

administrator   ~65375

Last edited: 2021-09-10 09:08

I will create a task in the backlog. It will be assigned according to priority.
gabrieljenik

gabrieljenik

2021-10-01 15:33

manager   ~66726

The problem here is that this requires themes to be updated and will make non updated themes to no work anymore (if they have overriden the related twig)

How should we handle this?
Maybe adding a new option NoticeLabelTitle (which always returns the raw value)?

Thanks!

Issue History

Date Modified Username Field Change
2021-06-20 18:34 DenisChenu New Issue
2021-06-20 18:34 DenisChenu Issue generated from: 17370
2021-06-20 18:41 DenisChenu Note Added: 64955
2021-07-12 12:53 galads Note Added: 65373
2021-07-12 12:54 galads Assigned To => DenisChenu
2021-07-12 12:54 galads Status new => assigned
2021-07-12 13:00 DenisChenu Note Added: 65374
2021-07-12 13:03 galads Note Added: 65375
2021-07-12 13:04 galads Status assigned => confirmed
2021-07-12 13:04 galads Assigned To DenisChenu => galads
2021-09-10 09:05 galads Assigned To galads => gabrieljenik
2021-09-10 09:05 galads Status confirmed => assigned
2021-10-01 15:33 gabrieljenik Note Added: 66726
2021-10-01 15:33 gabrieljenik Bug heat 4 => 6