17237: Zip attachments on email templates are not attached to the email

This bug affects 1 person(s).

ID	Project	Category	View Status	Date Submitted	Last Update

17237	Bug reports	Survey taking	public	2021-04-12 14:20	2021-07-12 11:53

Reporter	Jmantysalo	Assigned To	gabrieljenik
Priority	none	Severity	partial_block
Status	closed	Resolution	fixed
Product Version	4.4.15

Summary	17237: Zip attachments on email templates are not attached to the email
Description	When the email is sent it doesn't contain the attachment. The zip file is attached on the template, before sending? Or that fails as well? File is attached, template seems to be fine. So, it fails in the sending phase. Reported while testing 17220
Steps To Reproduce	OK. I deleted & re-created the database, deleted LS files, unzipped newest version and installed with default values. In first login I created a survey, clicked default question group & question, added participants table, activated, added user with email "jm58660@localhost.localdomain" (jm58660 is my account), added a zip-file to invitation email template, went to participants list, and clicked "sent email invitation" -icon. And got a mail without attachment. So I think I did everything as directly as I could, not changed anything from defaults.
Tags	No tags attached.

Bug heat	4
Complete LimeSurvey version number (& build)	4.4.16+210406
I will donate to the project if issue is resolved	No
Browser	not relevant
Database type & version	not relevant
Server OS (if known)
Webserver software & version (if known)
PHP Version	not relevant

User List	There are no users monitoring this issue.

gabrieljenik 2021-04-23 15:34 manager ~64131	PR: https://github.com/LimeSurvey/LimeSurvey/pull/1856 The issue was with LimeMailer: It tried to "json_decode" the attributes, which are actually serialized. Even then, it was trying to use the "path" property of the attachment, which doesn't exist (it's "url"). Finally, although this is not related to the issue, if the attachment had an invalid path it tried to throw a "CErrorEvent".

gabrieljenik 2021-04-26 17:39 manager ~64158	Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=31635

c_schmitz 2021-07-12 11:53 administrator ~65365	Release done.

Date Modified	Username	Field	Change
2021-04-12 14:20	gabrieljenik	New Issue
2021-04-12 14:20	gabrieljenik	Status	new => assigned
2021-04-12 14:20	gabrieljenik	Assigned To	=> gabrieljenik
2021-04-12 14:20	gabrieljenik	Issue generated from: 17220
2021-04-12 14:20	gabrieljenik	Relationship added	related to 17220
2021-04-12 14:22	gabrieljenik	Reporter	gabrieljenik => Jmantysalo
2021-04-12 14:22	gabrieljenik	Sync to Zoho Project	Yes => \|Yes\|
2021-04-12 14:23	gabrieljenik	Description Updated
2021-04-12 14:23	gabrieljenik	Sync to Zoho Project	Yes => \|Yes\|
2021-04-23 15:34	gabrieljenik	Note Added: 64131
2021-04-23 15:34	gabrieljenik	Status	assigned => ready for testing
2021-04-26 17:39	gabrieljenik	Changeset attached	=> LimeSurvey master d4b0376b
2021-04-26 17:39	gabrieljenik	Note Added: 64158
2021-04-26 17:39	gabrieljenik	Resolution	open => fixed
2021-04-26 19:04	ollehar	Status	ready for testing => resolved
2021-07-12 11:53	c_schmitz	Note Added: 65365
2021-07-12 11:53	c_schmitz	Status	resolved => closed

LimeSurvey: master d4b0376b 2021-04-26 19:39 gabrieljenik Committer: GitHub Details Diff	Fixed issue 17237: Zip attachments on email templates are not attached to the email (#1856) Co-authored-by: encuestabizdevgit <devgit@encuesta.biz>		Affected Issues 17237
	mod - application/core/LimeMailer.php		Diff File