View Issue Details

This bug affects 1 person(s).
 8
IDProjectCategoryView StatusLast Update
17038Bug reportsImport/Exportpublic2021-08-12 20:58
Reportergabrieljenik Assigned Togabrieljenik  
PrioritynormalSeverityblock 
Status closedResolutionfixed 
Product Version3.25.10 
Summary17038: templateurl placeholder not being replaced
Description

"templateurl" placeholder won't work here: https://github.com/LimeSurvey/LimeSurvey/blob/3.x-LTS/themes/survey/vanilla/views/layout_errors.twig#L51

Steps To Reproduce

When I add that line to custom_header.twig all I get is this:
<link rel="shortcut icon" href="favicon.ico">

TagsNo tags attached.
Bug heat8
Complete LimeSurvey version number (& build)3.25.10
I will donate to the project if issue is resolvedNo
BrowserChrome
Database type & versionMySQL
Server OS (if known)Linux
Webserver software & version (if known)Apache
PHP Version5.6.40

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2021-01-30 09:37

developer   ~61813

2 questions

gabrieljenik

gabrieljenik

2021-06-15 23:19

manager   ~64923

So we concluded the problem is that some template screens were not migrated properly from legacy.
We are updating them.

LTS: https://github.com/LimeSurvey/LimeSurvey/pull/1924
Master: https://github.com/LimeSurvey/LimeSurvey/pull/1925

ollehar

ollehar

2021-06-16 13:52

administrator   ~64925

Weird, can't find the task in Zoho, despite being migrated. Will create a new manually.

gabrieljenik

gabrieljenik

2021-06-17 11:20

manager   ~64940

Fix committed to 3.x-LTS branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&amp;id=32090

gabrieljenik

gabrieljenik

2021-06-17 12:35

manager   ~64941

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&amp;id=32091

Mazi

Mazi

2021-08-10 18:54

updater   ~65900

@gabrieljenik: But the fix at https://github.com/LimeSurvey/LimeSurvey/commit/77ef9e43a449691ac6ab7fb21069ec6c5cafc23a is actually not fixing the " templateurl placeholder not being replaced" problem. It just includes the image in a different way.
Did you double check that {TEMPLATEURL} is still being replaced within all twig files? I think I remember a similar problem a while ago.

gabrieljenik

gabrieljenik

2021-08-12 16:29

manager   ~65929

@mazi:

That variable is from EM but it is not a variable in twig.

Twig gets that info like this:
{{aSurveyInfo.oTemplate.sTemplateurl}}

Mazi

Mazi

2021-08-12 20:58

updater   ~65952

Thanks for clarifying, Gabriel!

Related Changesets

LimeSurvey: 3.x-LTS 77ef9e43

2021-06-17 11:20:34

gabrieljenik


Committer: GitHub Details Diff
Fixed issue 17038: templateurl placeholder not being replaced (#1924)

Co-authored-by: encuestabizdevgit <devgit@encuesta.biz>
Affected Issues
17038
mod - themes/survey/vanilla/views/layout_errors.twig Diff File

LimeSurvey: master e448b18f

2021-06-17 11:20:50

gabrieljenik


Committer: GitHub Details Diff
Fixed issue 17038: templateurl placeholder not being replaced (#1925)

Co-authored-by: encuestabizdevgit <devgit@encuesta.biz>
Affected Issues
17038
mod - themes/survey/vanilla/views/layout_errors.twig Diff File

Issue History

Date Modified Username Field Change
2021-01-29 18:08 gabrieljenik New Issue
2021-01-29 18:08 gabrieljenik Issue generated from: 16720
2021-01-30 09:37 DenisChenu Note Added: 61813
2021-01-30 18:08 cdorin Priority none => low
2021-01-30 18:08 cdorin Status new => confirmed
2021-01-30 18:08 cdorin Sync to Zoho Project => |Yes|
2021-06-05 11:20 ollehar Priority low => normal
2021-06-05 11:20 ollehar Sync to Zoho Project Yes => |Yes|
2021-06-15 23:19 gabrieljenik Assigned To => gabrieljenik
2021-06-15 23:19 gabrieljenik Status confirmed => ready for testing
2021-06-15 23:19 gabrieljenik Note Added: 64923
2021-06-16 13:52 ollehar Note Added: 64925
2021-06-17 11:20 gabrieljenik Changeset attached => LimeSurvey 3.x-LTS 77ef9e43
2021-06-17 11:20 gabrieljenik Note Added: 64940
2021-06-17 11:20 gabrieljenik Resolution open => fixed
2021-06-17 12:35 gabrieljenik Changeset attached => LimeSurvey master e448b18f
2021-06-17 12:35 gabrieljenik Note Added: 64941
2021-07-21 16:51 ollehar Status ready for testing => resolved
2021-08-10 18:54 Mazi Note Added: 65900
2021-08-10 18:54 Mazi Bug heat 6 => 8
2021-08-12 08:46 c_schmitz Status resolved => closed
2021-08-12 16:29 gabrieljenik Note Added: 65929
2021-08-12 20:58 Mazi Note Added: 65952