| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 16791 | Bug reports | Expression Manager | public | 2020-10-26 15:30 | 2021-03-04 16:41 |
| Reporter | Mazi | Assigned To | ollehar | ||
| Priority | normal | Severity | partial_block | ||
| Status | confirmed | Resolution | open | ||
| Product Version | 3.24.3 | ||||
| Summary | 16791: strlen() function for counting characters has problems with special characters | ||||
| Description | The strlen() function acutally counts the byte size of a string, not the number of characters. Since special characters requires more bytes, counting characters using the EM strlen() function leads to wrong results, see attached screenshot or test this demo survey: https://ls300demo.survey-consulting.com/index.php/survey/index/sid/29488/newtest/Y/lang/en I recommend to NOT replace the strlen() function but keep it for backwards compatibility. Instead, can we add a new mb_strlen() function to EM (see https://www.php.net/manual/de/function.mb-strlen.php)? That should support correct counting of special characters. | ||||
| Steps To Reproduce | Import the attached survey. | ||||
| Additional Information | |||||
| Tags | No tags attached. | ||||
| Bug heat | 6 | ||||
| Complete LimeSurvey version number (& build) | Version 3.24 | ||||
| I will donate to the project if issue is resolved | No | ||||
| Browser | Chrome | ||||
| Database type & version | MySQL 5 | ||||
| Server OS (if known) | Ubuntu 18 | ||||
| Webserver software & version (if known) | Apache | ||||
| PHP Version | 7.2.26 | ||||
 |
@DenisChenu, you fixed a similar problem at the core code base a while ago: https://bugs.limesurvey.org/view.php?id=9785#c32724 |
 |
multibyte strlen? |
 |
2015-07-21 11:21 … yes a while ago … And seems i update strlmen to use mb_strlen : https://github.com/LimeSurvey/LimeSurvey/commit/c031c7d24d1fecf21dc970e8bccb38eb4abe0a9f#diff-a974f1aca3b64170e04f9ac415aadb10d9108696f0ae4ce07caee89d8a1447d3R2570 seems currently too : https://github.com/LimeSurvey/LimeSurvey/blob/70507e27f6d1886bb50d52d3833284450639c684/application/helpers/expressions/em_core_helper.php#L2678 |
|
|
<s>JS function need to be fixed/updated BUT</s> locutus/phpjs didn't have mb_strlen And the only fix seem : https://stackoverflow.com/questions/2482907/javascript-string-length-differs-from-php-mb-strlen :/ In act : js.length are already mb_strlen … |
|
|
Someone broke this in 3.X or 2.50x Working in 2.6lts : It's not the 1st time something broken in javascript expression … between 2.6lts and 2.5X Capture d’écran du 2020-10-27 10-31-25.png (53,422 bytes) |
|
|
Interesting that this worked before. So probably all we need to do is finding out which commit caused the problem and then revert to the previous code/function?! |
|
|
Surely in LEMval … |
|
|
https://github.com/LimeSurvey/LimeSurvey/blob/70507e27f6d1886bb50d52d3833284450639c684/assets/packages/expressions/em_javascript.js#L1169 |
|
|
Please check if this bug still exists in the latest patch release. Thank you. |
|
|
@ollehar, why don't you simply import the atteched test survey and test. That only takes a minute. I just did that and yes, this issue still exists, see https://ls3.my-survey.host/index.php/29488?newtest=Y&lang=en |
|
|
Classic Mazi. ^^ Because we have hundreds of tickets. It's more efficient if I spread out the testing. Obviously. |
|
|
Thanks! We'll look at this issue. |
