View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 16758 | Bug reports | Survey taking | public | 2020-10-20 08:38 | 2020-10-26 08:16 |
| Reporter | DenisChenu | Assigned To | DenisChenu | ||
| Priority | none | Severity | minor | ||
| Status | closed | Resolution | fixed | ||
| Product Version | 4.3.22 | ||||
| Fixed in Version | 4.3.22 | ||||
| Summary | 16758: PHP7.1 + debug set : PHP Warning A non-numeric value encountered | ||||
| Description | When import included lss and launch : public part can receive PHP Warning | ||||
| Steps To Reproduce | Import included survey | ||||
| Additional Information | PHP7.1 introduce integre checking/number checking. LimeSurvey 2.73 show a text input, The fix : check if it's integer (between 0 and 100) seems the best Checked with 4 too | ||||
| Tags | No tags attached. | ||||
| Bug heat | 4 | ||||
| Complete LimeSurvey version number (& build) | 4.3.22 git | ||||
| I will donate to the project if issue is resolved | No | ||||
| Browser | not relevant ? | ||||
| Database type & version | not relevant? | ||||
| Server OS (if known) | fedora/linux | ||||
| Webserver software & version (if known) | nginx | ||||
| PHP Version | 7.4.9 | ||||
| related to | 16659 | closed | DenisChenu | PHP7.1 + debug set : PHP Warning A non-numeric value encountered |
|
PHP warning.html (22,457 bytes)
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en"><head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<title>PHP warning</title>
<style type="text/css">
/*<![CDATA[*/
html,body,div,span,applet,object,iframe,h1,h2,h3,h4,h5,h6,p,blockquote,pre,a,abbr,acronym,address,big,cite,code,del,dfn,em,font,img,ins,kbd,q,s,samp,small,strike,strong,sub,sup,tt,var,b,u,i,center,dl,dt,dd,ol,ul,li,fieldset,form,label,legend,table,caption,tbody,tfoot,thead,tr,th,td{border:0;outline:0;font-size:100%;vertical-align:baseline;background:transparent;margin:0;padding:0;}
body{line-height:1;}
ol,ul{list-style:none;}
blockquote,q{quotes:none;}
blockquote:before,blockquote:after,q:before,q:after{content:none;}
:focus{outline:0;}
ins{text-decoration:none;}
del{text-decoration:line-through;}
table{border-collapse:collapse;border-spacing:0;}
body {
font: normal 9pt "Verdana";
color: #000;
background: #fff;
}
h1 {
font: normal 18pt "Verdana";
color: #f00;
margin-bottom: .5em;
}
h2 {
font: normal 14pt "Verdana";
color: #800000;
margin-bottom: .5em;
}
h3 {
font: bold 11pt "Verdana";
}
pre {
font: normal 11pt Menlo, Consolas, "Lucida Console", Monospace;
}
pre span.error {
display: block;
background: #fce3e3;
}
pre span.ln {
color: #999;
padding-right: 0.5em;
border-right: 1px solid #ccc;
}
pre span.error-ln {
font-weight: bold;
}
.container {
margin: 1em 4em;
}
.version {
color: gray;
font-size: 8pt;
border-top: 1px solid #aaa;
padding-top: 1em;
margin-bottom: 1em;
}
.message {
color: #000;
padding: 1em;
font-size: 11pt;
background: #f3f3f3;
-webkit-border-radius: 10px;
-moz-border-radius: 10px;
border-radius: 10px;
margin-bottom: 1em;
line-height: 160%;
}
.source {
margin-bottom: 1em;
}
.code pre {
background-color: #ffe;
margin: 0.5em 0;
padding: 0.5em;
line-height: 125%;
border: 1px solid #eee;
}
.source .file {
margin-bottom: 1em;
font-weight: bold;
}
.traces {
margin: 2em 0;
}
.trace {
margin: 0.5em 0;
padding: 0.5em;
}
.trace.app {
border: 1px dashed #c00;
}
.trace .number {
text-align: right;
width: 2em;
padding: 0.5em;
}
.trace .content {
padding: 0.5em;
}
.trace .plus,
.trace .minus {
display:inline;
vertical-align:middle;
text-align:center;
border:1px solid #000;
color:#000;
font-size:10px;
line-height:10px;
margin:0;
padding:0 1px;
width:10px;
height:10px;
}
.trace.collapsed .minus,
.trace.expanded .plus,
.trace.collapsed pre {
display: none;
}
.trace-file {
cursor: pointer;
padding: 0.2em;
}
.trace-file:hover {
background: #f0ffff;
}
/*]]>*/
</style>
</head>
<body>
<div class="container">
<h1>PHP warning</h1>
<p class="message">
A non-numeric value encountered </p>
<div class="source">
<p class="file">/mnt/data/shnoulle/nginx/www/master/application/core/QuestionTypes/ArrayFlexibleRow/RenderArrayFlexibleRow.php(82)</p>
<div class="code"><pre><span class="ln">70</span> if (preg_match("/^[^|]+\|[^|]+$/", $oSubQuestions->questionl10ns[$this->sLanguage]->question)) {
<span class="ln">71</span> $combined++;
<span class="ln">72</span> }
<span class="ln">73</span> return $combined;
<span class="ln">74</span> }, 0);
<span class="ln">75</span> // $right_exists is a flag to find out if there are any right hand answer parts.
<span class="ln">76</span> // If there arent we can leave out the right td column
<span class="ln">77</span> $this->rightExists = ($iCount > 0);
<span class="ln">78</span>
<span class="ln">79</span> $this->answerwidth = $this->setDefaultIfEmpty($this->getQuestionAttribute('answer_width'), 33);
<span class="ln">80</span> $this->defaultWidth = ($this->answerwidth===33);
<span class="ln">81</span>
<span class="error"><span class="ln error-ln">82</span> $this->columnswidth = 100 - $this->answerwidth;
</span><span class="ln">83</span>
<span class="ln">84</span> if($this->rightExists) {
<span class="ln">85</span> /* put the right answer to same width : take place in answer width only if it's not default */
<span class="ln">86</span> if ($this->defaultWidth) {
<span class="ln">87</span> $this->columnswidth -= $this->answerwidth;
<span class="ln">88</span> } else {
<span class="ln">89</span> $this->answerwidth = $this->answerwidth / 2;
<span class="ln">90</span> }
<span class="ln">91</span> }
<span class="ln">92</span> if($this->getQuestionCount() > 0) {
<span class="ln">93</span> $this->cellwidth = round(($this->columnswidth / $this->getAnswerCount()), 1);
<span class="ln">94</span> }
</pre></div> </div>
<div class="traces">
<h2>Stack Trace</h2>
<table style="width:100%;">
<tbody><tr class="trace app expanded">
<td class="number">
#0 </td>
<td class="content">
<div class="trace-file">
<div class="plus">+</div>
<div class="minus">–</div>
/mnt/data/shnoulle/nginx/www/master/application/models/Question.php(1159): <strong>RenderArrayFlexibleRow</strong>-><strong>__construct</strong>(array("5246", "275575X344X5246", "Q00", "A first example question. Please answer this question:", ...)) </div>
<div class="code"><pre><span class="ln">1154</span> case Question::QT_K_MULTIPLE_NUMERICAL_QUESTION: $oRenderer = new RenderMultipleNumerical($aFieldArray); break;
<span class="ln">1155</span> case Question::QT_A_ARRAY_5_CHOICE_QUESTIONS: $oRenderer = new RenderArray5ChoiceQuestion($aFieldArray); break;
<span class="ln">1156</span> case Question::QT_B_ARRAY_10_CHOICE_QUESTIONS: $oRenderer = new RenderArray10ChoiceQuestion($aFieldArray); break;
<span class="ln">1157</span> case Question::QT_C_ARRAY_YES_UNCERTAIN_NO: $oRenderer = new RenderArrayYesUncertainNo($aFieldArray); break;
<span class="ln">1158</span> case Question::QT_E_ARRAY_OF_INC_SAME_DEC_QUESTIONS: $oRenderer = new RenderArrayOfIncSameDecQuestions($aFieldArray); break;
<span class="error"><span class="ln error-ln">1159</span> case Question::QT_F_ARRAY_FLEXIBLE_ROW: $oRenderer = new RenderArrayFlexibleRow($aFieldArray); break;
</span><span class="ln">1160</span> case Question::QT_G_GENDER_DROPDOWN: $oRenderer = new RenderGenderDropdown($aFieldArray); break;
<span class="ln">1161</span> case Question::QT_H_ARRAY_FLEXIBLE_COLUMN: $oRenderer = new RendererArrayFlexibleColumn($aFieldArray); break;
<span class="ln">1162</span> case Question::QT_N_NUMERICAL: $oRenderer = new RenderNumerical($aFieldArray); break;
<span class="ln">1163</span> case Question::QT_S_SHORT_FREE_TEXT: $oRenderer = new RenderShortFreeText($aFieldArray); break;
<span class="ln">1164</span> case Question::QT_Y_YES_NO_RADIO: $oRenderer = new RenderYesNoRadio($aFieldArray); break;
</pre></div> </td>
</tr>
<tr class="trace app expanded">
<td class="number">
#1 </td>
<td class="content">
<div class="trace-file">
<div class="plus">+</div>
<div class="minus">–</div>
/mnt/data/shnoulle/nginx/www/master/application/helpers/qanda_helper.php(152): <strong>Question</strong>-><strong>getRenderererObject</strong>(array("5246", "275575X344X5246", "Q00", "A first example question. Please answer this question:", ...)) </div>
<div class="code"><pre><span class="ln">147</span> );
<span class="ln">148</span>
<span class="ln">149</span> $oQuestion = Question::model()->findByPk($ia[0]);
<span class="ln">150</span> $oQuestionTemplate = QuestionTemplate::getNewInstance($oQuestion);
<span class="ln">151</span> $oQuestionTemplate->registerAssets(); // Register the custom assets of the question template, if needed
<span class="error"><span class="ln error-ln">152</span> $oRenderer = $oQuestion->getRenderererObject($ia);
</span><span class="ln">153</span> $values = $oRenderer->render();
<span class="ln">154</span>
<span class="ln">155</span>
<span class="ln">156</span> if (isset($values)) {
<span class="ln">157</span> //Break apart $values array returned from switch
</pre></div> </td>
</tr>
<tr class="trace app expanded">
<td class="number">
#2 </td>
<td class="content">
<div class="trace-file">
<div class="plus">+</div>
<div class="minus">–</div>
/mnt/data/shnoulle/nginx/www/master/application/helpers/SurveyRuntimeHelper.php(280): <strong>retrieveAnswers</strong>(array("5246", "275575X344X5246", "Q00", "A first example question. Please answer this question:", ...)) </div>
<div class="code"><pre><span class="ln">275</span> }
<span class="ln">276</span>
<span class="ln">277</span> //Get the answers/inputnames
<span class="ln">278</span> // TMSW - can content of retrieveAnswers() be provided by LEM? Review scope of what it provides.
<span class="ln">279</span> // TODO - retrieveAnswers is slow - queries database separately for each question. May be fixed in _CI or _YII ports, so ignore for now
<span class="error"><span class="ln error-ln">280</span> list($plus_qanda, $plus_inputnames) = retrieveAnswers($ia);
</span><span class="ln">281</span>
<span class="ln">282</span> if ($plus_qanda) {
<span class="ln">283</span> $plus_qanda[] = $ia[4];
<span class="ln">284</span> $plus_qanda[] = $ia[6]; // adds madatory identifyer for adding mandatory class to question wrapping div
<span class="ln">285</span>
</pre></div> </td>
</tr>
<tr class="trace app collapsed">
<td class="number">
#3 </td>
<td class="content">
<div class="trace-file">
<div class="plus">+</div>
<div class="minus">–</div>
/mnt/data/shnoulle/nginx/www/master/application/controllers/survey/index.php(610): <strong>SurveyRuntimeHelper</strong>-><strong>run</strong>("275575",
array("surveyid" => "275575", "thissurvey" => array("htmlemail"
=> "Y", "format" => "G", "tokenencryptionoptions" => "",
"template" => "vanilla", ...), "thisstep" => null, "tokensexist"
=> 0, ...)) </div>
<div class="code"><pre><span class="ln">605</span> unset($redata);
<span class="ln">606</span> $redata = compact(array_keys(get_defined_vars()));
<span class="ln">607</span> Yii::import('application.helpers.SurveyRuntimeHelper');
<span class="ln">608</span> $tmp = new SurveyRuntimeHelper();
<span class="ln">609</span> // try {
<span class="error"><span class="ln error-ln">610</span> $tmp->run($surveyid, $redata);
</span><span class="ln">611</span> // } catch (WrongTemplateVersionException $ex) {
<span class="ln">612</span> // echo $ex->getMessage();
<span class="ln">613</span> // }
<span class="ln">614</span> }
<span class="ln">615</span>
</pre></div> </td>
</tr>
<tr class="trace app collapsed">
<td class="number">
#4 </td>
<td class="content">
<div class="trace-file">
<div class="plus">+</div>
<div class="minus">–</div>
/mnt/data/shnoulle/nginx/www/master/application/controllers/survey/index.php(24): <strong>index</strong>-><strong>action</strong>() </div>
<div class="code"><pre><span class="ln">19</span> public $oTemplate;
<span class="ln">20</span>
<span class="ln">21</span> public function run()
<span class="ln">22</span> {
<span class="ln">23</span> useFirebug();
<span class="error"><span class="ln error-ln">24</span> $this->action();
</span><span class="ln">25</span> }
<span class="ln">26</span>
<span class="ln">27</span> public function action()
<span class="ln">28</span> {
<span class="ln">29</span> global $surveyid;
</pre></div> </td>
</tr>
<tr class="trace core collapsed">
<td class="number">
#5 </td>
<td class="content">
<div class="trace-file">
<div class="plus">+</div>
<div class="minus">–</div>
/mnt/data/shnoulle/nginx/www/master/framework/web/actions/CAction.php(76): <strong>index</strong>-><strong>run</strong>() </div>
<div class="code"><pre><span class="ln">71</span> {
<span class="ln">72</span> $method=new ReflectionMethod($this, 'run');
<span class="ln">73</span> if($method->getNumberOfParameters()>0)
<span class="ln">74</span> return $this->runWithParamsInternal($this, $method, $params);
<span class="ln">75</span>
<span class="error"><span class="ln error-ln">76</span> $this->run();
</span><span class="ln">77</span> return true;
<span class="ln">78</span> }
<span class="ln">79</span>
<span class="ln">80</span> /**
<span class="ln">81</span> * Executes a method of an object with the supplied named parameters.
</pre></div> </td>
</tr>
<tr class="trace core collapsed">
<td class="number">
#6 </td>
<td class="content">
<div class="trace-file">
<div class="plus">+</div>
<div class="minus">–</div>
/mnt/data/shnoulle/nginx/www/master/framework/web/CController.php(308): <strong>CAction</strong>-><strong>runWithParams</strong>(array("action" => "previewgroup", "sid" => "275575", "gid" => "344")) </div>
<div class="code"><pre><span class="ln">303</span> {
<span class="ln">304</span> $priorAction=$this->_action;
<span class="ln">305</span> $this->_action=$action;
<span class="ln">306</span> if($this->beforeAction($action))
<span class="ln">307</span> {
<span class="error"><span class="ln error-ln">308</span> if($action->runWithParams($this->getActionParams())===false)
</span><span class="ln">309</span> $this->invalidActionParams($action);
<span class="ln">310</span> else
<span class="ln">311</span> $this->afterAction($action);
<span class="ln">312</span> }
<span class="ln">313</span> $this->_action=$priorAction;
</pre></div> </td>
</tr>
<tr class="trace core collapsed">
<td class="number">
#7 </td>
<td class="content">
<div class="trace-file">
<div class="plus">+</div>
<div class="minus">–</div>
/mnt/data/shnoulle/nginx/www/master/framework/web/CController.php(286): <strong>CController</strong>-><strong>runAction</strong>(index) </div>
<div class="code"><pre><span class="ln">281</span> * @see runAction
<span class="ln">282</span> */
<span class="ln">283</span> public function runActionWithFilters($action,$filters)
<span class="ln">284</span> {
<span class="ln">285</span> if(empty($filters))
<span class="error"><span class="ln error-ln">286</span> $this->runAction($action);
</span><span class="ln">287</span> else
<span class="ln">288</span> {
<span class="ln">289</span> $priorAction=$this->_action;
<span class="ln">290</span> $this->_action=$action;
<span class="ln">291</span> CFilterChain::create($this,$action,$filters)->run();
</pre></div> </td>
</tr>
<tr class="trace core collapsed">
<td class="number">
#8 </td>
<td class="content">
<div class="trace-file">
<div class="plus">+</div>
<div class="minus">–</div>
/mnt/data/shnoulle/nginx/www/master/framework/web/CController.php(265): <strong>CController</strong>-><strong>runActionWithFilters</strong>(index, array()) </div>
<div class="code"><pre><span class="ln">260</span> {
<span class="ln">261</span> if(($parent=$this->getModule())===null)
<span class="ln">262</span> $parent=Yii::app();
<span class="ln">263</span> if($parent->beforeControllerAction($this,$action))
<span class="ln">264</span> {
<span class="error"><span class="ln error-ln">265</span> $this->runActionWithFilters($action,$this->filters());
</span><span class="ln">266</span> $parent->afterControllerAction($this,$action);
<span class="ln">267</span> }
<span class="ln">268</span> }
<span class="ln">269</span> else
<span class="ln">270</span> $this->missingAction($actionID);
</pre></div> </td>
</tr>
<tr class="trace core collapsed">
<td class="number">
#9 </td>
<td class="content">
<div class="trace-file">
<div class="plus">+</div>
<div class="minus">–</div>
/mnt/data/shnoulle/nginx/www/master/framework/web/CWebApplication.php(282): <strong>CController</strong>-><strong>run</strong>("index") </div>
<div class="code"><pre><span class="ln">277</span> {
<span class="ln">278</span> list($controller,$actionID)=$ca;
<span class="ln">279</span> $oldController=$this->_controller;
<span class="ln">280</span> $this->_controller=$controller;
<span class="ln">281</span> $controller->init();
<span class="error"><span class="ln error-ln">282</span> $controller->run($actionID);
</span><span class="ln">283</span> $this->_controller=$oldController;
<span class="ln">284</span> }
<span class="ln">285</span> else
<span class="ln">286</span> throw new CHttpException(404,Yii::t('yii','Unable to resolve the request "{route}".',
<span class="ln">287</span> array('{route}'=>$route===''?$this->defaultController:$route)));
</pre></div> </td>
</tr>
<tr class="trace core collapsed">
<td class="number">
#10 </td>
<td class="content">
<div class="trace-file">
<div class="plus">+</div>
<div class="minus">–</div>
/mnt/data/shnoulle/nginx/www/master/framework/web/CWebApplication.php(141): <strong>CWebApplication</strong>-><strong>runController</strong>("survey/index/action/previewgroup/sid/275575/gid/344") </div>
<div class="code"><pre><span class="ln">136</span> foreach(array_splice($this->catchAllRequest,1) as $name=>$value)
<span class="ln">137</span> $_GET[$name]=$value;
<span class="ln">138</span> }
<span class="ln">139</span> else
<span class="ln">140</span> $route=$this->getUrlManager()->parseUrl($this->getRequest());
<span class="error"><span class="ln error-ln">141</span> $this->runController($route);
</span><span class="ln">142</span> }
<span class="ln">143</span>
<span class="ln">144</span> /**
<span class="ln">145</span> * Registers the core application components.
<span class="ln">146</span> * This method overrides the parent implementation by registering additional core components.
</pre></div> </td>
</tr>
<tr class="trace core collapsed">
<td class="number">
#11 </td>
<td class="content">
<div class="trace-file">
<div class="plus">+</div>
<div class="minus">–</div>
/mnt/data/shnoulle/nginx/www/master/framework/base/CApplication.php(185): <strong>CWebApplication</strong>-><strong>processRequest</strong>() </div>
<div class="code"><pre><span class="ln">180</span> public function run()
<span class="ln">181</span> {
<span class="ln">182</span> if($this->hasEventHandler('onBeginRequest'))
<span class="ln">183</span> $this->onBeginRequest(new CEvent($this));
<span class="ln">184</span> register_shutdown_function(array($this,'end'),0,false);
<span class="error"><span class="ln error-ln">185</span> $this->processRequest();
</span><span class="ln">186</span> if($this->hasEventHandler('onEndRequest'))
<span class="ln">187</span> $this->onEndRequest(new CEvent($this));
<span class="ln">188</span> }
<span class="ln">189</span>
<span class="ln">190</span> /**
</pre></div> </td>
</tr>
<tr class="trace app collapsed">
<td class="number">
#12 </td>
<td class="content">
<div class="trace-file">
<div class="plus">+</div>
<div class="minus">–</div>
/mnt/data/shnoulle/nginx/www/master/index.php(182): <strong>CApplication</strong>-><strong>run</strong>() </div>
<div class="code"><pre><span class="ln">177</span> require_once APPPATH . 'core/LSYii_Application' . EXT;
<span class="ln">178</span>
<span class="ln">179</span> $config = require_once(APPPATH . 'config/internal' . EXT);
<span class="ln">180</span>
<span class="ln">181</span> Yii::$enableIncludePath = false;
<span class="error"><span class="ln error-ln">182</span> Yii::createApplication('LSYii_Application', $config)->run();
</span><span class="ln">183</span>
<span class="ln">184</span> /* End of file index.php */
<span class="ln">185</span> /* Location: ./index.php */
</pre></div> </td>
</tr>
</tbody></table>
</div>
<div class="version">
2020-10-20 06:37:42 nginx/1.18.0 <a href="http://www.yiiframework.com/">Yii Framework</a>/1.1.22-dev </div>
</div>
<script type="text/javascript">
/*<![CDATA[*/
var traceReg = new RegExp("(^|\\s)trace-file(\\s|$)");
var collapsedReg = new RegExp("(^|\\s)collapsed(\\s|$)");
var e = document.getElementsByTagName("div");
for(var j=0,len=e.length;j<len;j++){
if(traceReg.test(e[j].className)){
e[j].onclick = function(){
var trace = this.parentNode.parentNode;
if(collapsedReg.test(trace.className))
trace.className = trace.className.replace("collapsed", "expanded");
else
trace.className = trace.className.replace("expanded", "collapsed");
}
}
}
/*]]>*/
</script>
<div id="grammalecte_menu_main_button_shadow_host" style="width: 0px; height: 0px;"></div></body><script src="PHP%20warning_fichiers/api.js"></script></html> |
|
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=30632 |
|
|
Fixed in Release 4.3.23+201026 |
|
|
LimeSurvey: master b849e036 2020-10-20 11:15 Details Diff |
Fixed issue 16758: PHP7.1 + debug set : PHP Warning A non-numeric value encountered Dev: ctype_digit check |
Affected Issues 16758 |
|
| mod - application/core/QuestionTypes/ArrayFlexibleRow/RenderArrayFlexibleRow.php | Diff File | ||
| mod - application/core/QuestionTypes/ArrayMultiscale/RenderArrayMultiscale.php | Diff File | ||
| mod - application/helpers/qanda_helper.php | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2020-10-20 08:38 | DenisChenu | New Issue | |
| 2020-10-20 08:38 | DenisChenu | Status | new => assigned |
| 2020-10-20 08:38 | DenisChenu | Assigned To | => DenisChenu |
| 2020-10-20 08:38 | DenisChenu | Issue generated from: 16659 | |
| 2020-10-20 08:39 | DenisChenu | Note Added: 60282 | |
| 2020-10-20 08:39 | DenisChenu | File Added: PHP warning.html | |
| 2020-10-20 08:39 | DenisChenu | Relationship added | related to 16659 |
| 2020-10-20 09:15 | DenisChenu | Changeset attached | => LimeSurvey master b849e036 |
| 2020-10-20 09:15 | DenisChenu | Note Added: 60284 | |
| 2020-10-20 09:15 | DenisChenu | Resolution | open => fixed |
| 2020-10-20 09:47 | DenisChenu | Status | assigned => resolved |
| 2020-10-20 09:47 | DenisChenu | Fixed in Version | => 4.3.22 |
| 2020-10-26 08:16 | lime_release_bot | Note Added: 60402 | |
| 2020-10-26 08:16 | lime_release_bot | Status | resolved => closed |