View Issue Details

IDProjectCategoryView StatusLast Update
16573Bug reportsSurvey editingpublic2020-08-20 10:56
Reporterbbraeuer Assigned Togabrieljenik  
PrioritynoneSeveritypartial_block 
Status closedResolutionfixed 
Product Version4.3.9 
Summary16573: Others than the survey owners are not allowed to edit questions anymore
Description

Hi,

since one of the last updates this week the functionality of other survey editors are broken. Except for the set owner it is not possible to edit questions anymore.
The editors have full rights for their surveys and can edit the settings, but the questions do not have buttons for editing / saving anymore.

Steps To Reproduce

Create a new survey admin
Go to a survey and add him in "survey permissions"
Cannot edit questions with this account.

TagsNo tags attached.
Complete LimeSurvey version number (& build)4.3.9+200806
I will donate to the project if issue is resolvedNo
BrowserCurrent Chrome
Database & DB-VersionMySQL 5.6.47-log
Server OS (if known)Ubuntu 18.04
Webserver software & version (if known)Apache
PHP Version7.2.24-0ubuntu0.18.04.6

Activities

user225042

2020-08-07 16:45

  ~59371

Was able to replicate the issue successfully. When User has Global access to surveys user can edit but when access is restricted to survey level Question Overview and Editor are not displayed hence not able to do any edits.
Please refer the attachment for more details.

gabrieljenik

gabrieljenik

2020-08-11 22:24

developer   ~59416

Last edited: 2020-08-12 09:55

actionGetQuestionPermissions was checking the 'survey' permission instead of 'surveycontent'.

PR: https://github.com/LimeSurvey/LimeSurvey/pull/1547

user225042

2020-08-18 17:30

  ~59512

Tested the issue after pulling the PR, below are my findings:
When user as access restricted to survey level Question Overview and Editor are displayed and able to edit successfully.Please refer the attachment for more details

16573_Tim_Surveylevel.png (248,831 bytes)
gabrieljenik

gabrieljenik

2020-08-19 19:05

developer   ~59535

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=30390

lime_release_bot

lime_release_bot

2020-08-20 10:56

administrator   ~59549

Fixed in Release 4.3.12+200820

Related Changesets

LimeSurvey: master 9d096074

2020-08-19 19:03:37

gabrieljenik


Committer: GitHub Details Diff
Fixed issue 16573: Others than the survey owners are not allowed to edit questions anymore (#1547)

Dev: actionGetQuestionPermissions was checking the 'survey' permission instead of 'surveycontent'.
Affected Issues
16573
mod - application/controllers/QuestionEditorController.php Diff File

Issue History

Date Modified Username Field Change
2020-08-07 15:22 bbraeuer New Issue
2020-08-07 16:45 user225042 Note Added: 59371
2020-08-07 16:45 user225042 File Added: 16573_Tim Edit_SurveyLevelAccess.png
2020-08-07 16:46 user225042 Status new => confirmed
2020-08-11 22:24 gabrieljenik Note Added: 59416
2020-08-18 17:30 user225042 Note Added: 59512
2020-08-18 17:30 user225042 File Added: 16573_Tim_Surveylevel.png
2020-08-19 19:05 gabrieljenik Changeset attached => LimeSurvey master 9d096074
2020-08-19 19:05 gabrieljenik Note Added: 59535
2020-08-19 19:05 gabrieljenik Assigned To => gabrieljenik
2020-08-19 19:05 gabrieljenik Resolution open => fixed
2020-08-20 10:56 lime_release_bot Note Added: 59549
2020-08-20 10:56 lime_release_bot Status confirmed => closed