View Issue Details

IDProjectCategoryView StatusLast Update
16507Bug reportsSecuritypublic2020-08-20 10:56
Reportergabrieljenik Assigned Togabrieljenik  
PrioritynormalSeveritypartial_block 
Status closedResolutionfixed 
Product Version4.3.4 
Summary16507: Mass permissions are not being saved
Description

When setting permissions for multiple users using the mass users, permissions don't get saved.

TagsNo tags attached.
Complete LimeSurvey version number (& build)4.3.4
I will donate to the project if issue is resolvedNo
Browser
Database & DB-VersionMysql
Server OS (if known)
Webserver software & version (if known)
PHP Version7

Relationships

related to 15749 resolvedcdorin Adding new users as superadmins doesn't check all boxes 

Activities

gabrieljenik

gabrieljenik

2020-07-20 23:08

developer   ~59002

This was discovered while reviewing 15749

gabrieljenik

gabrieljenik

2020-08-10 19:09

developer   ~59400

Last edited: 2020-08-19 09:49

If updating permissions for 2 different users, after applying mass permissions:

  • both users should have the same permissions
  • the script should "remove" prior permissions and set the new ones write?
    @cdorin?
cdorin

cdorin

2020-08-10 19:14

manager   ~59401

Last edited: 2020-08-19 09:49

  1. Yes, both users should have the same permissions
  2. Yes, the script should remove prior permissions and apply the new ones to the selected group.
gabrieljenik

gabrieljenik

2020-08-11 22:08

developer   ~59415

Last edited: 2020-08-19 09:49

View 2 revisions

Reworked how custom-data is posted to the controller. Specially on checkboxes (which were always sent as TRUE)
Reviewed how checkbox are linked: "general" permission for an activity with the "read"/"update"/"delete"/.... checkboxes.
Reviewed results view

The file listActions.js was updated and that could affect other massive action modals as well.
We haven't found other massive modals which use checkboxes for posting data to the controllers.
Still, would be nice to double check.

PR: https://github.com/LimeSurvey/LimeSurvey/pull/1546/

user225042

2020-08-18 15:57

  ~59504

Last edited: 2020-08-19 09:49

Tested the issue before pulling the PR, Issue exist. Tested the issue after pulling the PR, below are my findings:
Before PR:https://screencast-o-matic.com/watch/cYjFIpG8oV
After PR: https://screencast-o-matic.com/watch/cYjFIKG8bO
Issue is been fixed I tested by adding and editing the permissions for multiple users from edit permissions, I also logged into user and cross-checked. Working as expected
Please refer the recordings and attachment for more details

16507_EditMasspermissions.png (81,485 bytes)   
16507_EditMasspermissions.png (81,485 bytes)   
gabrieljenik

gabrieljenik

2020-08-18 16:14

developer   ~59505

Last edited: 2020-08-19 09:49

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=30382

lime_release_bot

lime_release_bot

2020-08-20 10:56

administrator   ~59550

Fixed in Release 4.3.12+200820

Related Changesets

LimeSurvey: master 2819688c

2020-08-18 16:14:40

gabrieljenik


Committer: GitHub Details Diff
Fixed issue 16507: Mass permissions are not being saved (#1546)

Dev: Reworked how custom-data is posted to the controller. Specially on checkboxes (which were always sent as TRUE)
Dev: Reviewed how checkbox are linked: "general" permission for an activity with the "read"/"update"/"delete"/.... checkboxes.
Dev: Reviewed results view
Affected Issues
16507
mod - application/controllers/UserManagementController.php Diff File
mod - application/extensions/admin/grid/MassiveActionsWidget/assets/listActions.js Diff File
mod - application/views/userManagement/massiveAction/_updatepermissions.php Diff File
mod - assets/packages/usermanagement/js/usermanagement.js Diff File

Issue History

Date Modified Username Field Change
2020-07-20 23:08 gabrieljenik New Issue
2020-07-20 23:08 gabrieljenik Relationship added related to 15749
2020-07-20 23:08 gabrieljenik Note Added: 59002
2020-07-29 22:59 cdorin Status new => confirmed
2020-08-10 19:09 gabrieljenik Note Added: 59400
2020-08-10 19:14 cdorin Note Added: 59401
2020-08-10 19:16 cdorin Priority none => normal
2020-08-11 22:08 gabrieljenik Note Added: 59415
2020-08-11 22:08 gabrieljenik Note Edited: 59415 View Revisions
2020-08-18 15:57 user225042 Note Added: 59504
2020-08-18 15:57 user225042 File Added: 16507_EditMasspermissions.png
2020-08-18 16:14 gabrieljenik Changeset attached => LimeSurvey master 2819688c
2020-08-18 16:14 gabrieljenik Note Added: 59505
2020-08-18 16:14 gabrieljenik Assigned To => gabrieljenik
2020-08-18 16:14 gabrieljenik Resolution open => fixed
2020-08-18 16:29 ollehar Status confirmed => resolved
2020-08-20 10:56 lime_release_bot Note Added: 59550
2020-08-20 10:56 lime_release_bot Status resolved => closed