View Issue Details

IDProjectCategoryView StatusLast Update
16328Bug reportsRemoteControlpublic2020-05-29 11:22
ReporterJmantysalo Assigned To 
PrioritynoneSeveritypartial_block 
Status newResolutionopen 
Product Version4.2.4 
Summary16328: invite_participants exits on first error
Description

In the API the function invite_participants ends at the first non-valid participants, for example when a participant token is not yet valid.

Additional Information

I suppose this is because in application/helpers/admin/token_helper.php the function emailTokens() has code

foreach ($aResultTokens as $aTokenRow) {
if (isset($aTokenRow['validfrom']) . . .
'error'=>'Token not valid yet'
break 1;
. . .
}

but it should be 'continue', not 'break'.

TagsNo tags attached.
Complete LimeSurvey version number (& build)Versio 4.2.4+20052
I will donate to the project if issue is resolvedNo
Sync to Zoho Project
Browser
Database & DB-VersionN/A
Server OS (if known)
Webserver software & version (if known)
PHP VersionN/A

Activities

ollehar

ollehar

2020-05-28 17:27

administrator   ~58081

Depends. If you have continue, you have to collect all errors and report them back.

Jmantysalo

Jmantysalo

2020-05-28 18:17

reporter   ~58082

Depends. If you have continue, you have to collect all errors and report them back.

Ah, true. But at the minimun it should be documented that the function stops on first error, where "error" may be a token not yet valid etc. I used some time when looking for error from my own code.

ollehar

ollehar

2020-05-29 10:28

administrator   ~58087

It should. You have the link to its manual page?

Jmantysalo

Jmantysalo

2020-05-29 11:22

reporter   ~58090

Here:

https://api.limesurvey.org/classes/remotecontrol_handle.html#method_invite_participants
https://api.limesurvey.org/classes/remotecontrol_handle.html#method_remind_participants

Issue History

Date Modified Username Field Change
2020-05-24 20:07 Jmantysalo New Issue
2020-05-28 17:27 ollehar Note Added: 58081
2020-05-28 18:17 Jmantysalo Note Added: 58082
2020-05-29 10:28 ollehar Note Added: 58087
2020-05-29 11:22 Jmantysalo Note Added: 58090