View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|16236||Bug reports||Theme editor||public||2020-05-06 18:15||2020-07-02 12:37|
|Summary||16236: Option of Vanilla theme are not saved|
When try to set an option on Vanilla theme : nothing are saved
|Steps To Reproduce|
Seems to ba saved in Global part
|Tags||No tags attached.|
|Complete LimeSurvey version number (& build)||4.2.2 github|
|I will donate to the project if issue is resolved||No|
|Database & DB-Version||not relevant?|
|Server OS (if known)||not relevant ?|
|Webserver software & version (if known)||not relevant ?|
|PHP Version||not relevant ?|
Peek 06-05-2020 18-13.gif (1,072,123 bytes)
@cdorin, this also seems to break all our templates which are based on vanilla. Please fix soon!
it is in our to-do for this sprint
Thanks for the feedback!
Tested in latest version. When i click on Save it is redirected to the attached screen
VanillaTheme_16236.png (114,160 bytes)
@cdorin, this should have been included at a sprint last month. Sushmanadendla has tested but it looks like this is still not working as expected, did I get that right?
@mazi Yeah well it was included in the last sprint but there is lot of workaround required to fix the issue it is taking time,hopefully it will be available in next sprint.
Vanilla is not using the core options page, and the custom one is not properly triggering the form submit. So there are two options:
I think option 2 is the best one as to have
What do you think?
With option 2 : you broke all theme (again and again and again …)
NO ! because there are system that can NOT BE DONE WITH CURENT OPTION.
Option #1 implemented:
BTW, I have tried option 2 twice and haven't had any problems.
I understand themes which inherited from Vanilla maybe imepacted (not sure, I am doubting about that) .
OK : if it comes by
I think you replace core part, not template part
Tested issue by pulling the PR. Able to save the changes successfully. Please refer the screenshot for more details
16236_Vanillatheme_edit.png (104,987 bytes)
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=30239
LimeSurvey: master 14a8d26f
Committer: GitHub Details Diff
|Fixed issue 16236: Vanilla survey theme options are not saved (#1457)
Dev: The custom options page is not properly triggering the form submit.
|mod - themes/survey/vanilla/options/options.js||Diff File|
|2020-05-06 18:15||DenisChenu||New Issue|
|2020-05-06 18:15||DenisChenu||File Added: Peek 06-05-2020 18-13.gif|
|2020-05-07 13:35||ollehar||Priority||none => high|
|2020-05-07 13:35||ollehar||Severity||minor => crash|
|2020-05-17 23:48||cdorin||Status||new => confirmed|
|2020-05-19 15:47||Mazi||Note Added: 57936|
|2020-05-19 16:46||cdorin||Note Added: 57940|
|2020-05-19 17:50||Mazi||Note Added: 57944|
|2020-06-03 16:27||sushmanadendla||Note Added: 58160|
|2020-06-03 16:27||sushmanadendla||File Added: VanillaTheme_16236.png|
|2020-06-03 16:29||sushmanadendla||Note Edited: 58160||View Revisions|
|2020-06-24 17:25||Mazi||Note Added: 58425|
|2020-06-24 17:29||sushmanadendla||Note Added: 58426|
|2020-06-29 21:18||gabrieljenik||Note Added: 58564|
|2020-06-30 08:18||DenisChenu||Note Added: 58568|
|2020-06-30 08:18||DenisChenu||Note Edited: 58568||View Revisions|
|2020-06-30 17:50||gabrieljenik||Note Added: 58594|
|2020-06-30 18:14||DenisChenu||Note Added: 58598|
|2020-07-01 14:45||sushmanadendla||Note Added: 58614|
|2020-07-01 14:45||sushmanadendla||File Added: 16236_Vanillatheme_edit.png|
|2020-07-01 15:21||gabrieljenik||Changeset attached||=> LimeSurvey master 14a8d26f|
|2020-07-01 15:21||guest||Note Added: 58616|
|2020-07-02 12:37||swendrich||Status||confirmed => resolved|