View Issue Details

IDProjectCategoryView StatusLast Update
16235Bug reportsSurvey takingpublic2020-08-07 12:20
ReporterDenisChenu Assigned To 
PrioritynormalSeverityminor 
Status confirmedResolutionopen 
Product Version4.2.2 
Summary16235: Welcome page show again if cookies are enable and survey is already done
Description

If « Set cookie to prevent repeated participation: » is on, after survey was completed, laucnh again the survey show the welcome page.

Steps To Reproduce

Import included survey
Activate
Launch (with newtest=Y)
Submit
Laucch again : see welcome page
Move next : Error about cookie (it's OK)

Additional Information

3.X have same issue
If survey are All in one : all survey can be shown, but disable submit

TagsNo tags attached.
Complete LimeSurvey version number (& build)3.22.15 AND 4.2.2
I will donate to the project if issue is resolvedNo
Browserff
Database & DB-Versionnot relevant?
Server OS (if known)not relevant ?
Webserver software & version (if known)not relevant ?
PHP Versionnot relevant ?

Relationships

related to 16219 closed Testing a question will not be possible if admin participated in the survey. 
related to 16569 assignedgabrieljenik Welcome page show again if cookies are enable and survey is already done 

Activities

DenisChenu

DenisChenu

2020-05-06 15:27

developer  

Peek 06-05-2020 15-22.gif (148,656 bytes)
DenisChenu

DenisChenu

2020-05-06 15:28

developer   ~57588

A lss in all in one with cookie enable

DenisChenu

DenisChenu

2020-05-06 15:28

developer   ~57589

Last edited: 2020-07-29 23:08

DenisChenu

DenisChenu

2020-05-06 15:37

developer   ~57592

Last edited: 2020-07-29 23:08

Faulty lines : https://github.com/LimeSurvey/LimeSurvey/blob/79683baa01edbec5ae2dfde4af82fc0b86a0da58/application/controllers/survey/index.php#L349

But if newtest=Y allow to do survey again : must remove cookie …

cdorin

cdorin

2020-07-09 17:09

manager   ~58876

Last edited: 2020-07-29 23:08

hmm, wasn't this one recently solved? Or Gabriel made a PR recently?

DenisChenu

DenisChenu

2020-07-09 17:36

developer   ~58877

Last edited: 2020-07-29 23:08

There are a related fix or PR, but clerly : must remove (!isset($param['newtest']) || $param['newtest'] != "Y")

sushmanadendla

sushmanadendla

2020-07-14 14:42

manager   ~58944

Last edited: 2020-07-29 23:08

Issue exist in the latest version(4.3.4) also

gabrieljenik

gabrieljenik

2020-08-05 00:49

developer   ~59315

@cdorin There was an issue related to it. I think it was about cookies and admin previews.
Will review.

gabrieljenik

gabrieljenik

2020-08-06 22:22

developer   ~59357

newTest param shouldn't be considered for this validation
PR: https://github.com/LimeSurvey/LimeSurvey/pull/1538

sushmanadendla

sushmanadendla

2020-08-07 10:41

manager   ~59365

Tested the issue before pulling the PR, Issue exist. Tested the issue after pulling the PR, below are my findings:
When I test either with or without pull request I still see this error message.
Please refer the attachment for more details

16235_ErrorMessage.png (39,621 bytes)   
16235_ErrorMessage.png (39,621 bytes)   
sushmanadendla

sushmanadendla

2020-08-07 12:20

manager   ~59367

Before PR: https://screencast-o-matic.com/watch/cYji6iGlVB
After PR: https://screencast-o-matic.com/watch/cYji62Gln2
Before the PR I was able to navigate to welcome page and take the survey for second time when "set cookie to prevent repetition" is enabled.
After pulling the PR when I click on survey for second time I get the error message.
Please refer the recordings for more details, working as expected.

Issue History

Date Modified Username Field Change
2020-05-06 15:27 DenisChenu New Issue
2020-05-06 15:27 DenisChenu File Added: Peek 06-05-2020 15-22.gif
2020-05-06 15:28 DenisChenu Note Added: 57588
2020-05-06 15:28 DenisChenu Note Added: 57589
2020-05-06 15:28 DenisChenu File Added: limesurvey_survey_cookiesAllinone3X.lss
2020-05-06 15:28 DenisChenu Relationship added related to 16219
2020-05-06 15:37 DenisChenu Note Added: 57592
2020-05-11 09:51 ollehar Priority none => normal
2020-07-09 17:09 cdorin Note Added: 58876
2020-07-09 17:36 DenisChenu Note Added: 58877
2020-07-14 14:42 sushmanadendla Note Added: 58944
2020-07-14 14:43 sushmanadendla Status new => confirmed
2020-08-05 00:49 gabrieljenik Note Added: 59315
2020-08-05 00:50 gabrieljenik Issue cloned: 16569
2020-08-05 00:50 gabrieljenik Relationship added related to 16569
2020-08-06 22:22 gabrieljenik Note Added: 59357
2020-08-07 10:41 sushmanadendla Note Added: 59365
2020-08-07 10:41 sushmanadendla File Added: 16235_ErrorMessage.png
2020-08-07 12:20 sushmanadendla Note Added: 59367