View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
16217 | Bug reports | Survey editing | public | 2020-05-03 00:29 | 2020-08-24 11:40 |
Reporter | ymca | Assigned To | gabrieljenik | ||
Priority | low | Severity | partial_block | ||
Status | closed | Resolution | fixed | ||
Product Version | 4.2.1 | ||||
Summary | 16217: Survey will not show is the "inherit on" is chosen. | ||||
Description | When choosing "Inherit on" the survey will not show in the homepage. | ||||
Tags | No tags attached. | ||||
Attached Files | |||||
Bug heat | 6 | ||||
Complete LimeSurvey version number (& build) | Version 4.2.1+200428 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | |||||
Database type & version | same | ||||
Server OS (if known) | |||||
Webserver software & version (if known) | |||||
PHP Version | same | ||||
Removed "public" scope from Survey model, because it doesn't work with inheritance (DBCriteria can't manage inheritance recurrency). Added a "findAllPublic" method to the model to use in public listing. |
|
Tested the issue before pulling the PR, Issue exist. Tested the issue after pulling the PR, below are my findings: |
|
Tested the scenario's below:
|
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=30399 |
|
Fixed in Release 4.3.13+200824 |
|
LimeSurvey: master 3949c00c 2020-08-05 00:33:13 Details Diff |
Fixed issue 16217: Survey will not show is the "inherit on" is chosen. Removed "public" scope from Survey model, because it doesn't work with inheritance (DBCriteria can't manage inheritance recurrency). Added a "findAllPublic" method to the model to use in public listing. Also fixed survey overview. |
Affected Issues 16217 |
|
mod - application/controllers/SurveysController.php | Diff File | ||
mod - application/models/Survey.php | Diff File | ||
mod - application/views/admin/survey/subview/surveydashboard/003-publicationpanel.twig | Diff File | ||
LimeSurvey: master 2c59a34c 2020-08-18 18:42:48 Details Diff |
Revert "Fixed issue 16217: Survey will not show is the "inherit on" is chosen." This reverts commit fa5801bd6ebc2bf50a163a3c9823daf74963a301. |
Affected Issues 16217 |
|
mod - application/controllers/SurveysController.php | Diff File | ||
mod - application/models/Survey.php | Diff File | ||
mod - application/views/admin/survey/subview/surveydashboard/003-publicationpanel.twig | Diff File | ||
LimeSurvey: master 3972733c 2020-08-18 18:43:40 Details Diff |
Fixed issue 16217: Survey will not show is the "inherit on" is chosen. Removed "public" scope from Survey model, because it doesn't work with inheritance (DBCriteria can't manage inheritance recurrency). Added a "findAllPublic" method to the model to use in public listing. Also fixed survey overview. |
Affected Issues 16217 |
|
mod - application/controllers/SurveysController.php | Diff File | ||
mod - application/models/Survey.php | Diff File | ||
mod - application/views/admin/survey/subview/surveydashboard/003-publicationpanel.twig | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2020-05-03 00:29 | ymca | New Issue | |
2020-05-03 00:29 | ymca | File Added: inherit on.png | |
2020-05-03 00:29 | ymca | File Added: Not listed.png | |
2020-07-29 21:50 | cdorin | Priority | none => low |
2020-07-29 21:50 | cdorin | Status | new => confirmed |
2020-07-29 21:50 | cdorin | Description Updated | |
2020-07-29 21:50 | cdorin | Zoho Sprints | => |Yes| |
2020-07-29 21:50 |
|
Zoho Sprints ID | => 14469000000201001 |
2020-08-05 00:34 | gabrieljenik | Note Added: 59312 | |
2020-08-11 15:23 |
|
Note Added: 59407 | |
2020-08-11 15:23 |
|
File Added: 16217_ListPublicly_Off.png | |
2020-08-11 15:23 |
|
File Added: 16217_ListPublicly_On.png | |
2020-08-11 15:23 |
|
File Added: 16217_ListPublicly_InheritOn.png | |
2020-08-11 15:23 |
|
File Added: 16217_BeforePR.png | |
2020-08-20 17:29 |
|
Note Added: 59567 | |
2020-08-20 17:36 | gabrieljenik | Changeset attached | => LimeSurvey master 3972733c |
2020-08-20 17:36 | gabrieljenik | Changeset attached | => LimeSurvey master 2c59a34c |
2020-08-20 17:36 | gabrieljenik | Changeset attached | => LimeSurvey master 3949c00c |
2020-08-20 17:36 | gabrieljenik | Note Added: 59568 | |
2020-08-20 17:36 | gabrieljenik | Assigned To | => gabrieljenik |
2020-08-20 17:36 | gabrieljenik | Resolution | open => fixed |
2020-08-21 14:02 | ollehar | Status | confirmed => resolved |
2020-08-24 11:40 | lime_release_bot | Zoho Sprints | Yes => |Yes| |
2020-08-24 11:40 | lime_release_bot | Note Added: 59584 | |
2020-08-24 11:40 | lime_release_bot | Status | resolved => closed |