View Issue Details

Jump to NotesJump to History
This bug affects 1 person(s).
 8
IDProjectCategoryView StatusDate SubmittedLast Update
16144Bug reportsSurvey editingpublic2020-04-16 19:002022-06-07 14:02
ReporterDenisChenu Assigned To 
PrioritynormalSeverityminor 
Status confirmedResolutionreopened 
Product Version4.1.18 
Summary16144: Question editor allow submit invalid data : loose extra data
Description

When try to submit invalid title (empty or exsiting) : the form stil submitted : the loose extra data (for example 100 sub-questions)

Steps To Reproduce

See screencast,
Compare with 3.X screencast

Additional Information

We need to use "Client-side form validation" , browser can do job for us : why try to recreate browser system ? They are more than us.

TagsNo tags attached.
Attached Files
3.X.gif (503,114 bytes)
4.X.gif (927,157 bytes)
Bug heat8
Complete LimeSurvey version number (& build)5.3.18
I will donate to the project if issue is resolvedNo
Browsernot relevant
Database type & versionnot relevant
Server OS (if known)not relevant
Webserver software & version (if known)not relevant
PHP Versionnot relevant

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2020-04-16 19:03

developer   ~57200

  1. Don't submit invalid form (again and again : why broke browser system ...)
  2. Add required to title
  3. Add pattern for start by alpha and contains alphanum only
  4. Use setCustomValidity() for ajax request (unique title)
ollehar

ollehar

2020-04-16 22:31

administrator   ~57208

Is this a solution for the corrupt database values you had?
DenisChenu

DenisChenu

2020-04-17 10:48

developer   ~57216

Is this a solution for the corrupt database values you had?

Not related at all ....
DenisChenu

DenisChenu

2020-10-22 18:31

developer   ~60376

$form[0].checkValidity(); before submit please …
cdorin

cdorin

2020-12-29 19:12

reporter   ~61308

Fixed in 4.4.0 RC1 Denis?
DenisChenu

DenisChenu

2020-12-29 19:17

developer   ~61310

No : ajax request seems OK : but not "start with number" and maybe other.

Rreally not fixed : see screenshot and screencast

Peek 29-12-2020 19-16.gif (325,352 bytes)
DenisChenu

DenisChenu

2020-12-29 19:17

developer   ~61311

Capture d’écran du 2020-12-29 19-17-16.png (47,405 bytes)   
Capture d’écran du 2020-12-29 19-17-16.png (47,405 bytes)   
gabrieljenik

gabrieljenik

2022-06-06 15:02

manager   ~70237

Hello DenisChenu,
This ticket has been open for quite some time.
I think this is no longer an issue, right?
Thank you!
DenisChenu

DenisChenu

2022-06-06 16:15

developer   ~70247

Still an issue in 5.3.18

This pull request fix it partially : https://github.com/LimeSurvey/LimeSurvey/pull/2440
(not for duplicate subquestion code for example)
DenisChenu

DenisChenu

2022-06-06 16:17

developer   ~70248

It's not difficult to test …

Peek 06-06-2022 16-16.gif (238,211 bytes)

Issue History

Date Modified Username Field Change
2020-04-16 19:00 DenisChenu New Issue
2020-04-16 19:00 DenisChenu File Added: 3.X.gif
2020-04-16 19:00 DenisChenu File Added: 4.X.gif
2020-04-16 19:03 DenisChenu Note Added: 57200
2020-04-16 22:31 ollehar Note Added: 57208
2020-04-17 10:48 DenisChenu Note Added: 57216
2020-04-17 19:05 cdorin Priority none => normal
2020-04-17 19:05 cdorin Status new => confirmed
2020-10-22 18:31 DenisChenu Note Added: 60376
2020-12-29 19:12 cdorin Note Added: 61308
2020-12-29 19:13 cdorin Status confirmed => feedback
2020-12-29 19:17 DenisChenu Note Added: 61310
2020-12-29 19:17 DenisChenu File Added: Peek 29-12-2020 19-16.gif
2020-12-29 19:17 DenisChenu Status feedback => new
2020-12-29 19:17 DenisChenu Note Added: 61311
2020-12-29 19:17 DenisChenu File Added: Capture d’écran du 2020-12-29 19-17-16.png
2022-06-06 15:02 gabrieljenik Assigned To => gabrieljenik
2022-06-06 15:02 gabrieljenik Status new => closed
2022-06-06 15:02 gabrieljenik Resolution open => fixed
2022-06-06 15:02 gabrieljenik Note Added: 70237
2022-06-06 15:02 gabrieljenik Bug heat 6 => 8
2022-06-06 16:15 DenisChenu Status closed => feedback
2022-06-06 16:15 DenisChenu Resolution fixed => reopened
2022-06-06 16:15 DenisChenu Note Added: 70247
2022-06-06 16:17 DenisChenu Status feedback => confirmed
2022-06-06 16:17 DenisChenu Complete LimeSurvey version number (& build) 4.1.18 github => 5.3.18
2022-06-06 16:17 DenisChenu Note Added: 70248
2022-06-06 16:17 DenisChenu File Added: Peek 06-06-2022 16-16.gif
2022-06-07 14:02 gabrieljenik Assigned To gabrieljenik =>