|
|
Same issue with https://github.com/LimeSurvey/LimeSurvey/commit/4f948560635dbbecdd5755628430a653218d0637
Then : not related to your fix .... |
|
|
|
https://github.com/LimeSurvey/LimeSurvey/commit/7c04afd2ebe2dca98f89e036d180afcc3c3bb387 : same issue ...
The a 4.0.0 issue ..... |
|
|
|
Assigned to @cdorin : urgent issue ..... |
|
|
|
@cdorin : maybe move severity to more than minor ? |
|
|
|
Does this work in LS3? |
|
|
|
All tests should be done without newtest, right? |
|
|
|
Can't reproduce on latest master. More info? |
|
|
|
All tests should be done without newtest, right?
??? I start with or without newtes.
Still can reproduce
See Peek debug0.gif : exactly same issue
- get the start link (with or without newtest)
- Start browser (no session)
- Past the link
- Update language on welcome page
- Move next : nothing happen
- Move next : this survey was already submitted ...
I make a screencast with 2 window maybe ? |
|
|
|
New screencast : showing submitted with start page at 0 |
|
|
|
Works perfectly fine for me:
- Import demo survey
- Activate survey
- Copy link for FR
- Open private window
- Paste link, come to welcome page
- Change to Dutch
- Click next
- Next page is shown as expected
|
|
|
|
session ? PHP version ?
Did you try with brower private mode or a new clean browser ? because if you use admin browser : it work.
Undefined index: fr
$questionarray[3] = $arQuestion->questionl10ns[$_SESSION['survey_'.$surveyid]['s_lang']]->question;
See PHP Notice
PHP notice-2.html (17,139 bytes)
<!DOCTYPE html PUBLIC
"-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8"/>
<title>PHP notice</title>
<style type="text/css">
/*<![CDATA[*/
html,body,div,span,applet,object,iframe,h1,h2,h3,h4,h5,h6,p,blockquote,pre,a,abbr,acronym,address,big,cite,code,del,dfn,em,font,img,ins,kbd,q,s,samp,small,strike,strong,sub,sup,tt,var,b,u,i,center,dl,dt,dd,ol,ul,li,fieldset,form,label,legend,table,caption,tbody,tfoot,thead,tr,th,td{border:0;outline:0;font-size:100%;vertical-align:baseline;background:transparent;margin:0;padding:0;}
body{line-height:1;}
ol,ul{list-style:none;}
blockquote,q{quotes:none;}
blockquote:before,blockquote:after,q:before,q:after{content:none;}
:focus{outline:0;}
ins{text-decoration:none;}
del{text-decoration:line-through;}
table{border-collapse:collapse;border-spacing:0;}
body {
font: normal 9pt "Verdana";
color: #000;
background: #fff;
}
h1 {
font: normal 18pt "Verdana";
color: #f00;
margin-bottom: .5em;
}
h2 {
font: normal 14pt "Verdana";
color: #800000;
margin-bottom: .5em;
}
h3 {
font: bold 11pt "Verdana";
}
pre {
font: normal 11pt Menlo, Consolas, "Lucida Console", Monospace;
}
pre span.error {
display: block;
background: #fce3e3;
}
pre span.ln {
color: #999;
padding-right: 0.5em;
border-right: 1px solid #ccc;
}
pre span.error-ln {
font-weight: bold;
}
.container {
margin: 1em 4em;
}
.version {
color: gray;
font-size: 8pt;
border-top: 1px solid #aaa;
padding-top: 1em;
margin-bottom: 1em;
}
.message {
color: #000;
padding: 1em;
font-size: 11pt;
background: #f3f3f3;
-webkit-border-radius: 10px;
-moz-border-radius: 10px;
border-radius: 10px;
margin-bottom: 1em;
line-height: 160%;
}
.source {
margin-bottom: 1em;
}
.code pre {
background-color: #ffe;
margin: 0.5em 0;
padding: 0.5em;
line-height: 125%;
border: 1px solid #eee;
}
.source .file {
margin-bottom: 1em;
font-weight: bold;
}
.traces {
margin: 2em 0;
}
.trace {
margin: 0.5em 0;
padding: 0.5em;
}
.trace.app {
border: 1px dashed #c00;
}
.trace .number {
text-align: right;
width: 2em;
padding: 0.5em;
}
.trace .content {
padding: 0.5em;
}
.trace .plus,
.trace .minus {
display:inline;
vertical-align:middle;
text-align:center;
border:1px solid #000;
color:#000;
font-size:10px;
line-height:10px;
margin:0;
padding:0 1px;
width:10px;
height:10px;
}
.trace.collapsed .minus,
.trace.expanded .plus,
.trace.collapsed pre {
display: none;
}
.trace-file {
cursor: pointer;
padding: 0.2em;
}
.trace-file:hover {
background: #f0ffff;
}
/*]]>*/
</style>
</head>
<body>
<div class="container">
<h1>PHP notice</h1>
<p class="message">
Undefined index: fr </p>
<div class="source">
<p class="file">/mnt/data/shnoulle/nginx/www/master/application/helpers/frontend_helper.php(1641)</p>
<div class="code"><pre><span class="ln">1629</span> */
<span class="ln">1630</span> function updateFieldArray()
<span class="ln">1631</span> {
<span class="ln">1632</span> global $surveyid;
<span class="ln">1633</span>
<span class="ln">1634</span>
<span class="ln">1635</span> if (isset($_SESSION['survey_'.$surveyid]['fieldarray'])) {
<span class="ln">1636</span> foreach ($_SESSION['survey_'.$surveyid]['fieldarray'] as $key => $value) {
<span class="ln">1637</span> $questionarray = &$_SESSION['survey_'.$surveyid]['fieldarray'][$key];
<span class="ln">1638</span> $arQuestion = Question::model()->findByPk($questionarray[0]);
<span class="ln">1639</span> if (!empty($arQuestion)) {
<span class="ln">1640</span> $questionarray[2] = $arQuestion->title;
<span class="error"><span class="ln error-ln">1641</span> $questionarray[3] = $arQuestion->questionl10ns[$_SESSION['survey_'.$surveyid]['s_lang']]->question;
</span><span class="ln">1642</span> }
<span class="ln">1643</span> unset($questionarray);
<span class="ln">1644</span> }
<span class="ln">1645</span> }
<span class="ln">1646</span> }
<span class="ln">1647</span>
<span class="ln">1648</span> /**
<span class="ln">1649</span> * checkCompletedQuota() returns matched quotas information for the current response
<span class="ln">1650</span> * @param integer $surveyid - Survey identification number
<span class="ln">1651</span> * @param bool $return - set to true to return information, false do the quota
<span class="ln">1652</span> * @return array|void - nested array, Quotas->Members->Fields, includes quota information matched in session.
<span class="ln">1653</span> */
</pre></div> </div>
<div class="traces">
<h2>Stack Trace</h2>
<table style="width:100%;">
<tr class="trace app expanded">
<td class="number">
#0 </td>
<td class="content">
<div class="trace-file">
<div class="plus">+</div>
<div class="minus">–</div>
/mnt/data/shnoulle/nginx/www/master/application/controllers/survey/index.php(301): <strong>updateFieldArray</strong>() </div>
<div class="code"><pre><span class="ln">296</span> }
<span class="ln">297</span>
<span class="ln">298</span> // Update the Session var only if needed
<span class="ln">299</span> if (App()->language != $sOldLang) {
<span class="ln">300</span> UpdateGroupList($surveyid, App()->language); // to refresh the language strings in the group list session variable
<span class="error"><span class="ln error-ln">301</span> updateFieldArray(); // to refresh question titles and question text
</span><span class="ln">302</span> }
<span class="ln">303</span> }
<span class="ln">304</span>
<span class="ln">305</span> //GET BASIC INFORMATION ABOUT THIS SURVEY
<span class="ln">306</span> $thissurvey = getSurveyInfo($surveyid, $_SESSION['survey_'.$surveyid]['s_lang']);
</pre></div> </td>
</tr>
<tr class="trace app expanded">
<td class="number">
#1 </td>
<td class="content">
<div class="trace-file">
<div class="plus">+</div>
<div class="minus">–</div>
/mnt/data/shnoulle/nginx/www/master/application/controllers/survey/index.php(24): <strong>index</strong>-><strong>action</strong>() </div>
<div class="code"><pre><span class="ln">19</span> public $oTemplate;
<span class="ln">20</span>
<span class="ln">21</span> public function run()
<span class="ln">22</span> {
<span class="ln">23</span> useFirebug();
<span class="error"><span class="ln error-ln">24</span> $this->action();
</span><span class="ln">25</span> }
<span class="ln">26</span>
<span class="ln">27</span> public function action()
<span class="ln">28</span> {
<span class="ln">29</span> global $surveyid;
</pre></div> </td>
</tr>
<tr class="trace core collapsed">
<td class="number">
#2 </td>
<td class="content">
<div class="trace-file">
<div class="plus">+</div>
<div class="minus">–</div>
/mnt/data/shnoulle/nginx/www/master/framework/web/actions/CAction.php(76): <strong>index</strong>-><strong>run</strong>() </div>
<div class="code"><pre><span class="ln">71</span> {
<span class="ln">72</span> $method=new ReflectionMethod($this, 'run');
<span class="ln">73</span> if($method->getNumberOfParameters()>0)
<span class="ln">74</span> return $this->runWithParamsInternal($this, $method, $params);
<span class="ln">75</span>
<span class="error"><span class="ln error-ln">76</span> $this->run();
</span><span class="ln">77</span> return true;
<span class="ln">78</span> }
<span class="ln">79</span>
<span class="ln">80</span> /**
<span class="ln">81</span> * Executes a method of an object with the supplied named parameters.
</pre></div> </td>
</tr>
<tr class="trace core collapsed">
<td class="number">
#3 </td>
<td class="content">
<div class="trace-file">
<div class="plus">+</div>
<div class="minus">–</div>
/mnt/data/shnoulle/nginx/www/master/framework/web/CController.php(308): <strong>CAction</strong>-><strong>runWithParams</strong>(array("sid" => "994978")) </div>
<div class="code"><pre><span class="ln">303</span> {
<span class="ln">304</span> $priorAction=$this->_action;
<span class="ln">305</span> $this->_action=$action;
<span class="ln">306</span> if($this->beforeAction($action))
<span class="ln">307</span> {
<span class="error"><span class="ln error-ln">308</span> if($action->runWithParams($this->getActionParams())===false)
</span><span class="ln">309</span> $this->invalidActionParams($action);
<span class="ln">310</span> else
<span class="ln">311</span> $this->afterAction($action);
<span class="ln">312</span> }
<span class="ln">313</span> $this->_action=$priorAction;
</pre></div> </td>
</tr>
<tr class="trace core collapsed">
<td class="number">
#4 </td>
<td class="content">
<div class="trace-file">
<div class="plus">+</div>
<div class="minus">–</div>
/mnt/data/shnoulle/nginx/www/master/framework/web/CController.php(286): <strong>CController</strong>-><strong>runAction</strong>(index) </div>
<div class="code"><pre><span class="ln">281</span> * @see runAction
<span class="ln">282</span> */
<span class="ln">283</span> public function runActionWithFilters($action,$filters)
<span class="ln">284</span> {
<span class="ln">285</span> if(empty($filters))
<span class="error"><span class="ln error-ln">286</span> $this->runAction($action);
</span><span class="ln">287</span> else
<span class="ln">288</span> {
<span class="ln">289</span> $priorAction=$this->_action;
<span class="ln">290</span> $this->_action=$action;
<span class="ln">291</span> CFilterChain::create($this,$action,$filters)->run();
</pre></div> </td>
</tr>
<tr class="trace core collapsed">
<td class="number">
#5 </td>
<td class="content">
<div class="trace-file">
<div class="plus">+</div>
<div class="minus">–</div>
/mnt/data/shnoulle/nginx/www/master/framework/web/CController.php(265): <strong>CController</strong>-><strong>runActionWithFilters</strong>(index, array()) </div>
<div class="code"><pre><span class="ln">260</span> {
<span class="ln">261</span> if(($parent=$this->getModule())===null)
<span class="ln">262</span> $parent=Yii::app();
<span class="ln">263</span> if($parent->beforeControllerAction($this,$action))
<span class="ln">264</span> {
<span class="error"><span class="ln error-ln">265</span> $this->runActionWithFilters($action,$this->filters());
</span><span class="ln">266</span> $parent->afterControllerAction($this,$action);
<span class="ln">267</span> }
<span class="ln">268</span> }
<span class="ln">269</span> else
<span class="ln">270</span> $this->missingAction($actionID);
</pre></div> </td>
</tr>
<tr class="trace core collapsed">
<td class="number">
#6 </td>
<td class="content">
<div class="trace-file">
<div class="plus">+</div>
<div class="minus">–</div>
/mnt/data/shnoulle/nginx/www/master/framework/web/CWebApplication.php(282): <strong>CController</strong>-><strong>run</strong>("index") </div>
<div class="code"><pre><span class="ln">277</span> {
<span class="ln">278</span> list($controller,$actionID)=$ca;
<span class="ln">279</span> $oldController=$this->_controller;
<span class="ln">280</span> $this->_controller=$controller;
<span class="ln">281</span> $controller->init();
<span class="error"><span class="ln error-ln">282</span> $controller->run($actionID);
</span><span class="ln">283</span> $this->_controller=$oldController;
<span class="ln">284</span> }
<span class="ln">285</span> else
<span class="ln">286</span> throw new CHttpException(404,Yii::t('yii','Unable to resolve the request "{route}".',
<span class="ln">287</span> array('{route}'=>$route===''?$this->defaultController:$route)));
</pre></div> </td>
</tr>
<tr class="trace core collapsed">
<td class="number">
#7 </td>
<td class="content">
<div class="trace-file">
<div class="plus">+</div>
<div class="minus">–</div>
/mnt/data/shnoulle/nginx/www/master/framework/web/CWebApplication.php(141): <strong>CWebApplication</strong>-><strong>runController</strong>("survey/index/sid/994978") </div>
<div class="code"><pre><span class="ln">136</span> foreach(array_splice($this->catchAllRequest,1) as $name=>$value)
<span class="ln">137</span> $_GET[$name]=$value;
<span class="ln">138</span> }
<span class="ln">139</span> else
<span class="ln">140</span> $route=$this->getUrlManager()->parseUrl($this->getRequest());
<span class="error"><span class="ln error-ln">141</span> $this->runController($route);
</span><span class="ln">142</span> }
<span class="ln">143</span>
<span class="ln">144</span> /**
<span class="ln">145</span> * Registers the core application components.
<span class="ln">146</span> * This method overrides the parent implementation by registering additional core components.
</pre></div> </td>
</tr>
<tr class="trace core collapsed">
<td class="number">
#8 </td>
<td class="content">
<div class="trace-file">
<div class="plus">+</div>
<div class="minus">–</div>
/mnt/data/shnoulle/nginx/www/master/framework/base/CApplication.php(185): <strong>CWebApplication</strong>-><strong>processRequest</strong>() </div>
<div class="code"><pre><span class="ln">180</span> public function run()
<span class="ln">181</span> {
<span class="ln">182</span> if($this->hasEventHandler('onBeginRequest'))
<span class="ln">183</span> $this->onBeginRequest(new CEvent($this));
<span class="ln">184</span> register_shutdown_function(array($this,'end'),0,false);
<span class="error"><span class="ln error-ln">185</span> $this->processRequest();
</span><span class="ln">186</span> if($this->hasEventHandler('onEndRequest'))
<span class="ln">187</span> $this->onEndRequest(new CEvent($this));
<span class="ln">188</span> }
<span class="ln">189</span>
<span class="ln">190</span> /**
</pre></div> </td>
</tr>
<tr class="trace app expanded">
<td class="number">
#9 </td>
<td class="content">
<div class="trace-file">
<div class="plus">+</div>
<div class="minus">–</div>
/mnt/data/shnoulle/nginx/www/master/index.php(182): <strong>CApplication</strong>-><strong>run</strong>() </div>
<div class="code"><pre><span class="ln">177</span> require_once APPPATH . 'core/LSYii_Application' . EXT;
<span class="ln">178</span>
<span class="ln">179</span> $config = require_once(APPPATH . 'config/internal' . EXT);
<span class="ln">180</span>
<span class="ln">181</span> Yii::$enableIncludePath = false;
<span class="error"><span class="ln error-ln">182</span> Yii::createApplication('LSYii_Application', $config)->run();
</span><span class="ln">183</span>
<span class="ln">184</span> /* End of file index.php */
<span class="ln">185</span> /* Location: ./index.php */
</pre></div> </td>
</tr>
</table>
</div>
<div class="version">
2020-04-16 14:01:18 nginx/1.16.1 <a href="http://www.yiiframework.com/">Yii Framework</a>/1.1.22-dev </div>
</div>
<script type="text/javascript">
/*<![CDATA[*/
var traceReg = new RegExp("(^|\\s)trace-file(\\s|$)");
var collapsedReg = new RegExp("(^|\\s)collapsed(\\s|$)");
var e = document.getElementsByTagName("div");
for(var j=0,len=e.length;j<len;j++){
if(traceReg.test(e[j].className)){
e[j].onclick = function(){
var trace = this.parentNode.parentNode;
if(collapsedReg.test(trace.className))
trace.className = trace.className.replace("collapsed", "expanded");
else
trace.className = trace.className.replace("expanded", "collapsed");
}
}
}
/*]]>*/
</script>
</body>
</html>
|
|
|
|
Session what? PHP is 7.4.
Admin interface is in normal window, survey taking in private window. |
|
|
|
Arg ...
Check DB : the S question didn't seems to exist ... in fr
I sedn my DB because
- Update question (qid = 3282 (Survey 994978)) and save dodn't shown any error or fix the issue
- Check integrety didn't fix the issue.
|
|
|
|
OK, so it's a problem in question editor? |
|
|
|
Question id can be different, what's the question code? |
|
|
|
I'm not too eager to debug your corrupt database, sorry. xD |
|
|
|
S
No : in questionl10ns : qid are same for all language
Else : more a check integrity here (in my opinion)
But : better if question editor throw an error or something like this : see screencast |
|
|
|
PS : it's not to fix my corrupted database (it's my test DB ... dev DB , no real data): but
- checkintegrtity MUST fix this issue (it does in 3.X : create unexisting question language etc ..)
- question editor must show something different
|
|
|
|
That bug is so bad... (in your gif) |
|
|
|
Maybe some other strange issue can came from simple error like this
Some vue error
[Vue warn]: Error in render: "TypeError: this.$store.state.currentQuestionI10N[this.$store.state.activeLanguage] is undefined"
found in
---> <MainEditor> at src/components/mainEditor.vue
<TransitionGroup>
<Lsnextquestioneditor> at src/App.vue
<Root> vue.esm.js:628
TypeError: "this.$store.state.currentQuestionI10N[this.$store.state.activeLanguage] is undefined"
get mainEditor.vue:218
VueJS 4
render mainEditor.vue:88
VueJS 7
vue.esm.js:1897
|
|
|
|
admin/questioneditor/sa/saveQuestionData/gid/189/sid/994978 return a success ...
Maybe start by it |
|
|
|
Cannot reproduce your editor bug. Clear assets? |
|
|
|
And browser cache... And try with debug = 2 (don't use asset manager cache). |
|
|
|
With my DB ? |
|
|
|
The editor bug is due to a broken DB .....
Just delete fr and de question in you DB for sample survey .... |
|
|
|
No. Why try with a corrupt db? How did it get corrupt in the first place? |
|
|
|
I update title to
16025: Broken survey language (lack of questionl10ns) unfixable
|
|
|
|
OK, sure, but that's low priority. We have a bunch of blocking issue, this is fine-tuning. |
|
|
|
No time, and seems there are more possibility than DB export … |
|
|
|
Decreased the priority so that it does not pop up on the top when filtering.
Used your last comments to decrease its priority |
|
