View Issue Details

IDProjectCategoryView StatusLast Update
15994Bug reportsSurvey participants (Tokens)public2020-09-22 10:46
Reportergalads Assigned Togabrieljenik  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version3.22.7 
Summary15994: Batch-Edit shows "lskeep" after modification of email status
Description

when batch editing email status in the participants table, the email adress gets overwritten with 'lskeep'.

Steps To Reproduce

Show survey participants
Select some participants
Batch edit
Check "Modify email"
Enter something in "Email status", leave "Email" input empty
Click "Apply"

TagsNo tags attached.
Complete LimeSurvey version number (& build)3.22.9 github
I will donate to the project if issue is resolvedNo
Browser
Database & DB-Versionunknown
Server OS (if known)
Webserver software & version (if known)
PHP Versionunknown

Activities

galads

galads

2020-03-17 17:52

updater  

galads

galads

2020-03-17 17:57

updater   ~56619

@c_dorin

DenisChenu

DenisChenu

2020-03-18 09:25

developer   ~56629

Last edited: 2020-03-30 22:03

@cdorin : i can get it, but what to do :

  1. Create a checkbox for "emailstatus" edit only
  2. Don't update "email" if email is empty even if checkbox is checked (no way to set [empty string] to email with Batch edit

I think both must be done, +

  1. Add a placeholder on email input "Don't update current email"
  2. Allow automatic for emailstatus (maybe if empty)
  3. Then add a placeholder on emailstatus : "Automatic according to LimeSurvey email checker"
gabrieljenik

gabrieljenik

2020-09-08 16:28

developer   ~59747

PR: https://github.com/LimeSurvey/LimeSurvey/pull/1584

gabrieljenik

gabrieljenik

2020-09-22 09:39

developer   ~59919

Fix committed to 3.x-LTS branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=30501

lime_release_bot

lime_release_bot

2020-09-22 10:46

administrator   ~59922

Fixed in Release 3.23.5+200923

Related Changesets

LimeSurvey: 3.x-LTS 539e6c9f

2020-09-22 09:39:02

gabrieljenik


Committer: GitHub Details Diff
Fixed issue 15994: Batch-Edit shows "lskeep" after modification of email status (#1584)

Code Review.
Created a checkbox for "emailstatus" edit only
Don't update "email" if email is empty even if checkbox is checked (no way to set [empty string] to email with Batch edit
Removed placeholder for emailstatus. It was confusing.
Affected Issues
15994
mod - application/controllers/admin/tokens.php Diff File
mod - application/views/admin/token/massive_actions/_update.php Diff File

Issue History

Date Modified Username Field Change
2020-03-17 17:52 galads New Issue
2020-03-17 17:52 galads File Added: Screenshot 2020-03-17 at 17.50.56.png
2020-03-17 17:52 galads File Added: Screenshot 2020-03-17 at 17.51.45.png
2020-03-17 17:52 galads File Added: Screenshot 2020-03-17 at 17.52.13.png
2020-03-17 17:57 galads Note Added: 56619
2020-03-17 19:11 DenisChenu Assigned To => cdorin
2020-03-17 19:11 DenisChenu Status new => confirmed
2020-03-17 19:11 DenisChenu Complete LimeSurvey version number (& build) Not relevant => 3.22.9 github
2020-03-18 09:25 DenisChenu Note Added: 56629
2020-03-18 12:40 cdorin Priority none => normal
2020-03-18 12:40 cdorin Steps to Reproduce Updated View Revisions
2020-09-08 16:28 gabrieljenik Note Added: 59747
2020-09-22 09:39 gabrieljenik Changeset attached => LimeSurvey 3.x-LTS 539e6c9f
2020-09-22 09:39 gabrieljenik Note Added: 59919
2020-09-22 09:39 gabrieljenik Assigned To cdorin => gabrieljenik
2020-09-22 09:39 gabrieljenik Resolution open => fixed
2020-09-22 10:46 lime_release_bot Note Added: 59922
2020-09-22 10:46 lime_release_bot Status confirmed => closed